Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753758AbXIDI1K (ORCPT ); Tue, 4 Sep 2007 04:27:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752573AbXIDI0z (ORCPT ); Tue, 4 Sep 2007 04:26:55 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:40018 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752085AbXIDI0x (ORCPT ); Tue, 4 Sep 2007 04:26:53 -0400 Date: Tue, 4 Sep 2007 14:09:47 +0530 (IST) From: Satyam Sharma X-X-Sender: satyam@enigma.security.iitk.ac.in To: Steffen Klassert cc: Linux Kernel Mailing List , Linux Netdev Mailing List , Jeff Garzik , Mark Hindley Subject: Re: [PATCH -mm 1/2] 3c59x: Fix uninitialized variable bug In-Reply-To: <20070904081602.GB4241@newton.mathematik.tu-chemnitz.de> Message-ID: References: <20070904081602.GB4241@newton.mathematik.tu-chemnitz.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1269 Lines: 35 Hi Steffen, On Tue, 4 Sep 2007, Steffen Klassert wrote: > On Tue, Sep 04, 2007 at 03:45:55AM +0530, Satyam Sharma wrote: > > > > drivers/net/3c59x.c: In function 'vortex_up': > > drivers/net/3c59x.c:1495: warning: 'err' may be used uninitialized in this function > > This came in with the recently applied 3c59x-check-return-of-pci_enable_device patch > from Mark Hindley. I just compiled it on a PCI only machine so far, therefore I did > not notice the warning yet. Hmm, the .config I built with had PCI=y as well. Probably a compiler version difference -- Jeff also mentioned yesterday that some newer GCC versions fail to warn about uninitialized variables cases. > > is a genuine bug. The function returns an uninitialized value of 'err' > > back to the caller, which expects it to be 0 for success cases. Let's > > fix this by explicitly initializing 'err' to zero. > > > > Signed-off-by: Satyam Sharma > Acked-by: Steffen Klassert Thanks, Satyam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/