Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4FD3C05027 for ; Thu, 9 Feb 2023 09:32:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230182AbjBIJcK (ORCPT ); Thu, 9 Feb 2023 04:32:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229699AbjBIJcI (ORCPT ); Thu, 9 Feb 2023 04:32:08 -0500 Received: from formenos.hmeau.com (167-179-156-38.a7b39c.syd.nbn.aussiebb.net [167.179.156.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 666F33B0EB; Thu, 9 Feb 2023 01:32:07 -0800 (PST) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1pQ3Hd-009DvA-Jf; Thu, 09 Feb 2023 17:32:02 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Thu, 09 Feb 2023 17:32:01 +0800 Date: Thu, 9 Feb 2023 17:32:01 +0800 From: Herbert Xu To: Weili Qian Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, wangzhou1@hisilicon.com, liulongfang@huawei.com Subject: Re: [PATCH 2/5] crypto: hisilicon/qm - change data type in min_t Message-ID: References: <20230203093730.49314-1-qianweili@huawei.com> <20230203093730.49314-3-qianweili@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230203093730.49314-3-qianweili@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 03, 2023 at 05:37:27PM +0800, Weili Qian wrote: > 'act_q_num = min_t(int, act_q_num, max_qp_num)', 'act_q_num' > and 'max_qp_num' are 'u32' type, change min_t() to use 'u32' > type instead of 'int'. If they are of the same type, why not just do min? Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt