Date:   Thu, 9 Feb 2023 11:38:04 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     =?utf-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= <clement.leger@bootlin.com>
Cc:     Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        Herve Codina <herve.codina@bootlin.com>,
        =?utf-8?Q?Miqu=C3=A8l?= Raynal <miquel.raynal@bootlin.com>,
        Milan Stevanovic <milan.stevanovic@se.com>,
        Jimmy Lalande <jimmy.lalande@se.com>,
        Pascal Eberhard <pascal.eberhard@se.com>,
        Arun Ramadoss <Arun.Ramadoss@microchip.com>,
        linux-renesas-soc@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] net: dsa: rzn1-a5psw: add vlan support
Message-ID: <Y+TNDFovmcjy+ctb@corigine.com>
References: <20230208160453.325783-1-clement.leger@bootlin.com>
 <20230208160453.325783-4-clement.leger@bootlin.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230208160453.325783-4-clement.leger@bootlin.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QVBEOUt0eTkwNnpBVnYwZmtxR0hQN3JCamdnZFdWY1RJemg3M3VpVWFtU0lG?=
 =?utf-8?B?emZmYnQ2NDM0djZwbSszeVJIM0hFMm52YStPUXcxbDlvRCtwNGkzSmREMkZO?=
 =?utf-8?B?TDBlWEM4QWhkeHczaWRoY2czVzVVRHJLSXVMaExIeWJib3gzNmxJUVljRFhY?=
 =?utf-8?B?UnFsdmJDUC8rSHhZeHdMdWp5bTVqZlhYei9mN1VlRlppbGwwbmtZcE10YkEz?=
 =?utf-8?B?VkFISFJmU2JzaVZTS3Y0MlVkV1JwRjg4OGdiM0trL1Z1YkZ4VXVnVHovdG5w?=
 =?utf-8?B?TnlqblNZcHJjZ2VxR3F1U0J0NTIwcldCcXRxVmc4MjBnZHV6c0VjUnh5U2JO?=
 =?utf-8?B?MnRQMlBORStRYWpLb0dKZDFMbCthRk4xYjV5SFlUaHBEUmh1NUp5OHhiYk9l?=
 =?utf-8?B?SFkrbnNnaWhpam9COXhNZDhuVnRQUmlIb1JaZUtIcGlBck5NTnhwOTdQNnFs?=
 =?utf-8?B?ZnFheDlVazVPZU5KZ0VoWm5ZQlprdE4yNS9BT200Y2VvUDA2YjhqVzhlS1F3?=
 =?utf-8?B?eWNkbWdhUWlIZmNqSkY0VytzWkc1cHYzVHovNWxCZ1VIaUpSd093WThYaUVX?=
 =?utf-8?B?dFMwT0p6RlJaYlhWbCszSER0K1BqWjRSTUdYSVJub3o2dlF1ZkkvakdyN2pv?=
 =?utf-8?B?UmxNQXFtTE53SzFCUHNucDB5eFBvL2l2eWp6cExXN09ZL3JCbGF3RVN3Rkcy?=
 =?utf-8?B?cUl2b3B4UEc1YXgzbFhpdTBTTDVWbkVVNzAwL01MZkNNeGk1ODg4ZVNTalRV?=
 =?utf-8?B?WWdhYjUwNlczMnliR0ljSUlrcmx5S2dKNFdkVnVYWitDbFZiL0s4RVFIV3Jh?=
 =?utf-8?B?akJtVmZpc3FFWHJqMzVxZ01XTXhCTmxFQXVSNGhOckxmZThHOWp6QjhsdnlG?=
 =?utf-8?B?d2N4NnhjejFIUk52Nm5zanJ6VkJEa2FHYUlxaG1nN0lZSy90RTZRYXB1SnJH?=
 =?utf-8?B?Zm1SeFc0OVhvOEV5SzhnL3hSa0M3czBPUGduN0JKZks4TGpJZmFRNHZwU0Rj?=
 =?utf-8?B?TE9UWW5OZGhhN0FlZ0NuWWl5bm0xRC90dGtnNHJJblgyOWgxbmRsbEp3ZDhs?=
 =?utf-8?B?Rytwc0xObnhzZmZDQkt2elVZYlgzdVZRVEdCVkVyWE01dEhFS1o4Tyt1czFB?=
 =?utf-8?B?SWZaQ2Fra1d0THBsYmVzaTNvbWZwckRLa2p4N2ZSWEVpMjdPdzlsZUdxNGNk?=
 =?utf-8?B?MDE2YUZOSlhVc2crR0w3RWZlRkc1Ylk2bmZ1bnlrYUdKTHBXckRKZzNnYkJz?=
 =?utf-8?B?VngvaHdXSXhycEw0L0pDZUNTdWxnaWhqS3B4aEVuMVY0VEJ6bXZ0L2ZLeDNM?=
 =?utf-8?B?d0t6SGZucnFmN2p4cDdiQVpCUDhreEFqVFpXYmtmdktNaWF6NERlbVRrakUx?=
 =?utf-8?B?RndtbHVWaTB0NzJTK0x2VmxJcU1STi9Fb0JpV0Z2MWtONzZZdTFnRStnTmVM?=
 =?utf-8?B?ODQ4enRoTDB0dVdJRnhJZVRLUkNTbzdUTjd1emU5dlhoakg2Z1FORjhVS2ZX?=
 =?utf-8?B?SGRaYnFXdFpMT1U1MllZeGJNeWZPN2pBRlF3dkNyM3E5U0tmMlRUT2hidmtp?=
 =?utf-8?B?TFRSWnZoSTNydTBvaEQwYnlGT2lIRjlqVThkM1Nxc0IzM2cxeC90c1dMeC9P?=
 =?utf-8?B?TlJUU0hMcFREeGVZZXZZSS9mWjdKNjZFUWk0Y0w5Y0cyUkJQT3B3WVFrbGZN?=
 =?utf-8?B?RHUxcm9QSURkNzRoZkZJSTFUN013MllMRXhmWnVZR04wMTJKTW82VlNPdXJi?=
 =?utf-8?B?OTNHU1NGV0JlRSsrb3pDYkhPZUFaanhZQ0pIdDhIejkvMXdaUDhXakxrbXpl?=
 =?utf-8?B?TG53MVA4Y1FJTy9EZU5QbFRCK2F2Y2lqQkJEQ3pyRVptSURUK05ZUUkzeml0?=
 =?utf-8?B?Tk5lRFRuOFYwTzFUdlpMZlhKVkNzOHo1ZmFuWWc5TzNNVktMeVRReFA0RnUz?=
 =?utf-8?B?VlY1MjlIS3MvakJmRGlxWG1EYjdmMjFtR3dqQktUb2RrNXV6RE05OWoveU9j?=
 =?utf-8?B?N0k2b2dBWFFoNzAxSFhiR2o0VUMzMzJ2RFpwNU5Mc0NaL1pXMHlFSUxLeFNT?=
 =?utf-8?B?REtSenEwT2l5WVh1UWV0RnF6OW8xRmgwc2h0TnpQSmVJblh5bE11b0ZPS3k4?=
 =?utf-8?B?Z05JeFlkNTN2M0Jjd2RPcENlVnYzYU5LMGE0L2VhcGEyZG80T3dPdkJXY09v?=
 =?utf-8?B?SmhGaktuUmNHYlp1dnE3N05EallJREU0ai9pYjkvVlJEV0llSTd5TFJwV0dB?=
 =?utf-8?B?KzF0dE4zOXQwTDl3dlU5NC9BQ3pRPT0=?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 06e09885-e5e0-44c8-37d5-08db0a89bdee
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 10:38:11.8859
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: J6fT5rjeh+kqark4FemUrcCf1Paujh45Yq53O3UlI8OAgedg4L2NaXpmkvjDt+HgyYomakrYqP9EmDhDrz2gmwePxyUJPM92PkUkBmFVDRc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR13MB4057
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Feb 08, 2023 at 05:04:53PM +0100, Clément Léger wrote:
> Add support for vlan operation (add, del, filtering) on the RZN1
> driver. The a5psw switch supports up to 32 VLAN IDs with filtering,
> tagged/untagged VLANs and PVID for each ports.
> 
> Signed-off-by: Clément Léger <clement.leger@bootlin.com>
> ---
>  drivers/net/dsa/rzn1_a5psw.c | 167 +++++++++++++++++++++++++++++++++++
>  drivers/net/dsa/rzn1_a5psw.h |   8 +-
>  2 files changed, 172 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/dsa/rzn1_a5psw.c b/drivers/net/dsa/rzn1_a5psw.c
> index 0ce3948952db..de6b18ec647d 100644
> --- a/drivers/net/dsa/rzn1_a5psw.c
> +++ b/drivers/net/dsa/rzn1_a5psw.c
> @@ -583,6 +583,147 @@ static int a5psw_port_fdb_dump(struct dsa_switch *ds, int port,
>  	return ret;
>  }
>  
> +static int a5psw_port_vlan_filtering(struct dsa_switch *ds, int port,
> +				     bool vlan_filtering,
> +				     struct netlink_ext_ack *extack)
> +{
> +	u32 mask = BIT(port + A5PSW_VLAN_VERI_SHIFT) |
> +		   BIT(port + A5PSW_VLAN_DISC_SHIFT);
> +	struct a5psw *a5psw = ds->priv;
> +	u32 val = 0;
> +
> +	if (vlan_filtering)
> +		val = BIT(port + A5PSW_VLAN_VERI_SHIFT) |
> +		      BIT(port + A5PSW_VLAN_DISC_SHIFT);

nit: could this be expressed as follows?

	val = vlan_filtering ? mask : 0 ?

> +
> +	a5psw_reg_rmw(a5psw, A5PSW_VLAN_VERIFY, mask, val);
> +
> +	return 0;
> +}

...