Date:   Thu, 9 Feb 2023 11:45:39 +0100
From:   Thierry Reding <treding@nvidia.com>
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     linux-kernel@vger.kernel.org, Joerg Roedel <jroedel@suse.de>,
        Will Deacon <will@kernel.org>, iommu@lists.linux.dev
Subject: Re: [PATCH] iommu/of: mark an unused function as __maybe_unused
Message-ID: <Y+TO0yEdUNzWUUrA@orome>
References: <20230209010359.23831-1-rdunlap@infradead.org>
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="zIyMWYSQYQZxu/NB"
Content-Disposition: inline
In-Reply-To: <20230209010359.23831-1-rdunlap@infradead.org>
User-Agent: Mutt/2.2.9 (2022-11-12)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VYCs6ineGDgQKprC+hzJKoNktoPmz26hvM9UjEtiHI/JOuNtwR5O5pt0JOSN?=
 =?us-ascii?Q?cs8EAR32J9KWLcc514658jNoB/PsCbBtvAdLgpSZ3VZ0rxWF6R5rYnPiP9di?=
 =?us-ascii?Q?I1f46c3QRCrTCrx5xKxbXMNAGWqr7WNhSf3YT7wzyGUQBz7xH6qVMLS6Pyub?=
 =?us-ascii?Q?CawgE8H+I7QKd5GEBrb7kqajQhnYdn8KEFo2OBf1SQoonUMYtkNj1JQ7cesn?=
 =?us-ascii?Q?OIBMkBndpk1xSqXoBH/BzYevBBMeUJSlEqpt19kScUNqCngdpjloGBVqiQA0?=
 =?us-ascii?Q?ZL6/KQLQe+oJBazdEWIhvpJne8hxiEqIw59HuIZ92t+MMvobDZJK95VVDuNI?=
 =?us-ascii?Q?mnofZtWhlJMtO6Buw7ZpMO2N7RvhFdgvvxgNrSzlwocY+iNmSDeeZypiFuDN?=
 =?us-ascii?Q?lyGRYOhT1xTFjNNXDMV88eAwfsuW8vUlWF9Ft9UGa+tjauOoF02LiC6/8lGa?=
 =?us-ascii?Q?zacWLMShyBnq8FK/zOtRXT+xLVOg9xMpnqkigjU1iBOaRQnCg2twP8QlzMnZ?=
 =?us-ascii?Q?X0sG79xP69mSV1jfxDSCJndrXBCqsNFW1fgP9i8jWQrcIxV/r2pWUh8jJMZg?=
 =?us-ascii?Q?gq1otq6dfdqtXrGuYkPsOLpfCOGTdbFKfn6+m8aSJkhaOogbqnjkUvDcywZr?=
 =?us-ascii?Q?IFN65gECf3DIWCBYeyh2pX/s4FmhqPnZHu/h9uLgKxigOPhE5PkAm3os19Ui?=
 =?us-ascii?Q?v+IMXCvqsZCfiagRdRoZPGvaAGffAp+TaSE6tK9yrqv0QX0w9b6D256Or2RS?=
 =?us-ascii?Q?b2YL5a/msRoGloE9TYQTFIboR8kKMd4oULByasujKj580XuisfXZ7yWtnf+r?=
 =?us-ascii?Q?UN9DH/jTQbD3PlIYAPZD0TQ2/k/pnYD2qfDu1FMHGEbqpNlP+DjzXJzRikiC?=
 =?us-ascii?Q?pGdRIHN7FYieHT8Eeh1R1hsfYz8qTcu6I0kkDHT1jWoAckqo7QZwXO+yqF/p?=
 =?us-ascii?Q?uFH4Gy/1jQsHm/NaJAorb+U0zK+QoVBsH48ETk6hMnXEi1W4qm1llXVKYAcw?=
 =?us-ascii?Q?JSB30+x5hW5pcvnX8H8PxDWys849FkfFw8YbSSmz5C8w/XIjRBOV93Dr+FHL?=
 =?us-ascii?Q?+R1oH3bBoLX/eU/2rNalqZR0PXia5siScPfkMnYEdY/n1vc2yeeWq/mxDLDY?=
 =?us-ascii?Q?2R83y1lnzC+e/LPQrJaZmQsLaB1CV9D+Pwu53lTdOm2z3GSnz/PcxTct0Beu?=
 =?us-ascii?Q?B9edJnQMzvKtG+yqi0ItRL+Q+ODYADvpczMQ9w9W7Iuja4n5ykNrheooITzp?=
 =?us-ascii?Q?8fNqfip+Wf/I++lfz6OUc0bRAb6yJ3+iAkTNWVFToXTkLygcFZjUVRqqOnsU?=
 =?us-ascii?Q?zj1xmw6Ovxl9Iyj4qLFMZxw0kDc/xnihMY/qxxs1/QViRO+KAdTOs8zKOmwX?=
 =?us-ascii?Q?a8nKyzTrU5ZREY/jzlztyXNLxRsxLKI8F136rXv/Xe75OfjL2fiZZmAqV7MG?=
 =?us-ascii?Q?5MckpKOpHF07ZQGKMZcj8BzTFpkemzf17287L2ohyhGJ0kJrbUtxEBc1u6dV?=
 =?us-ascii?Q?HXMoAdX2yhhyp21U7YMIKhmoE8HztD8k/czuiFoSqFAn7lji8vYa5JEwV/tQ?=
 =?us-ascii?Q?u2J8vuwBirLkyQK9IRq3rahwmdfP7MbdP0n8i+Q0bo25FoWa8bafycpAvi1y?=
 =?us-ascii?Q?KUZti+yTrBtYQox61X2/JWvh65KVwnx/4JYZUskEfnjA?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 57422fc5-4734-4f90-d370-08db0a8acc88
X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5413.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 10:45:45.8215
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ls4wRLKhMdNTtfeGtDTFvFryFHji0vPOy/75QQch45mS5a1kgeslbup8MX9AsTRqtDPz8Cz9Tfd4mwoYvAi/+g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7792
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--zIyMWYSQYQZxu/NB
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 08, 2023 at 05:03:59PM -0800, Randy Dunlap wrote:
> When CONFIG_OF_ADDRESS is not set, there is a build warning/error
> about an unused function.
> Annotate the function to quieten the warning/error.
>=20
> ../drivers/iommu/of_iommu.c:176:29: warning: 'iommu_resv_region_get_type'=
 defined but not used [-Wunused-function]
>   176 | static enum iommu_resv_type iommu_resv_region_get_type(struct dev=
ice *dev, struct resource *phys,
>       |                             ^~~~~~~~~~~~~~~~~~~~~~~~~~
>=20
> Fixes: a5bf3cfce8cb ("iommu: Implement of_iommu_get_resv_regions()")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Thierry Reding <treding@nvidia.com>
> Cc: Joerg Roedel <jroedel@suse.de>
> Cc: Will Deacon <will@kernel.org>
> Cc: iommu@lists.linux.dev
> ---
>  drivers/iommu/of_iommu.c |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>=20
> diff -- a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c
> --- a/drivers/iommu/of_iommu.c
> +++ b/drivers/iommu/of_iommu.c
> @@ -173,8 +173,9 @@ const struct iommu_ops *of_iommu_configu
>  	return ops;
>  }
> =20
> -static enum iommu_resv_type iommu_resv_region_get_type(struct device *de=
v, struct resource *phys,
> -						       phys_addr_t start, size_t length)
> +static enum iommu_resv_type __maybe_unused iommu_resv_region_get_type(st=
ruct device *dev,
> +						struct resource *phys,
> +						phys_addr_t start, size_t length)

Maybe this is one of those cases where we should wrap after the return
type/attributes to keep this somewhat readable?

Either way:

Reviewed-by: Thierry Reding <treding@nvidia.com>

--zIyMWYSQYQZxu/NB
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmPkztMACgkQ3SOs138+
s6HHGQ//QoL+mGw1QUVwpdjWVREnT+jOyOPd0Y8gbVXHdkV6J58abv/qZyV+4jef
ckvwJOgt25kKKJYSnoeL+nt0Cths2tdgYiWaEkeYnx73JAeb40/22lGf/w9nbmVT
FJmHFIeJS3Wqygni9ltTkRB6Z6kSj+xuNo6CD/VBFO9E9nc6pI9ThS9g+z2B5ST8
FfksCRJa0LYYoKay8gr5gXD0uZ5yQzrHuc92BAkXOJibPPE5PQ0n6LKY1+pem4Rl
gy6g4Q/4EeY8KpR4JwaAfsmU+A1gSZiXEg1YkBLIhVye/mUzY4rJiEH2wYHGXNLi
czf3TSfpt9A8ENIvUcbXaKtJKPZU6++NEACBFOArileQymR1MqlSrAxHJYmlhOuh
MRGtmz0cVyH5zMsY7QorP+re2Q/jhW/HvAehpnGca8xAyMIR2AVjBe+yOcDVNMmn
xpK1GM8rLxgAwSu9Klag3fFFriu48XsHiqBcsY5U+7xPHLTOyG1e2EO8d/xS9pLF
BWcWSC6YMtXJske32knIL9HK4fcDuFP4uIeN66lhjdUz6eKXHThVJ0pIl4PIlkO/
OHXN0zwqkc6+VaA9Zk2zfrLacN/kujO/a6g2n4b93sZXVlM6w3Tj+3TcQzJ3Hb4r
+RM1I810/x/Pqiwi0FfaN22NAv7JWvi22/53/xEa6uN7iY1h/+0=
=yZj+
-----END PGP SIGNATURE-----

--zIyMWYSQYQZxu/NB--