From:   Thomas Gleixner <tglx@linutronix.de>
To:     Sergey Shtylyov <s.shtylyov@omp.ru>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] irq: ipi: fix NULL pointer deref in
 irq_data_get_affinity_mask()
In-Reply-To: <774e2812-2856-f146-b8b3-e4f772c5e38a@omp.ru>
References: <b541232d-c2b6-1fe9-79b4-a7129459e4d0@omp.ru>
 <774e2812-2856-f146-b8b3-e4f772c5e38a@omp.ru>
Date:   Thu, 09 Feb 2023 11:49:37 +0100
Message-ID: <875ycb2jwe.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On Wed, Feb 08 2023 at 21:35, Sergey Shtylyov wrote:
> On 8/17/22 11:00 PM, Sergey Shtylyov wrote:
>
>> Iff ipi_send_{mask|single}() get called with e.g. an invalid IRQ #, all the
>> local variables there will be NULL -- the problem is that ipi_send_verify()
>> (that's called first thing) doesn't verify its 'data' parameter, resulting
>> in a kernel oops in irq_data_get_affinity_mask() as the passed NULL pointer
>> gets dereferenced.  Add a missing NULL check in ipi_send_verify()...
>> 
>> Found by Linux Verification Center (linuxtesting.org) with the SVACE static
>> analysis tool.
>> 
>> Fixes: 3b8e29a82dd1 ("genirq: Implement ipi_send_mask/single()")
>> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>
>    Patch fell thru the cracks? :-/

Obviously :)

/me goes to find trash tongs to pick it up