Date:   Thu, 9 Feb 2023 11:57:19 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Oliver Graute <oliver.graute@kococonnector.com>
Cc:     andrew@lunn.ch, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH RFC] linux: net: phy: realtek: changing LED behaviour for
 RTL8211F
Message-ID: <Y+TRj2hehU76+Ytu@corigine.com>
References: <20230209094405.12462-1-oliver.graute@kococonnector.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230209094405.12462-1-oliver.graute@kococonnector.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jBYeNMFqE06phw8b5E3O+/MYRUC8VZQcJDOYbOmgiY65PEEFmy8IQGlwIt/X?=
 =?us-ascii?Q?w5wuD1jLPMi1bUNmU8fRDqyPDnKtoLh1u8GzsDZ8XSL0zlMZzN5C7ntl2/bq?=
 =?us-ascii?Q?2nbMZmHRnIY6EAt5VPyGJ8y5QZg6luX/hptYtz0mlTFI/QdfAqWg7t+pkZuP?=
 =?us-ascii?Q?qGjs4e5RUhycuLNvKaHs21+Dpb2v3rjjpnDZqGudpl6bo4TKmb20wRNShRWT?=
 =?us-ascii?Q?hj0omQ0731F+gWaBDluVOG2AxF0ZhxO+uT41hS42oGvajVtAFaooX42SOYr7?=
 =?us-ascii?Q?hUarNy91wHwdnyZWpiZzMSEu5FsA1Azi3JP0B7qPTkM0qpYFG2RyKVfMncOL?=
 =?us-ascii?Q?xy5orqFjAfpcWMUtUEFPQMXBat97tFjHR5azok+UCUebT7odd8RFD+xtvJoo?=
 =?us-ascii?Q?yp+LsfLSMP5ATPakx8ERi6PE2Wk2PIt60RvUQCxLxN03eYgDN7Pupl8tOqTv?=
 =?us-ascii?Q?mZXpz4qsqA094ae3uYbQ6Mf8/T/RgLNt+pkmuyfIR32BX9//oRMlDccOWE7h?=
 =?us-ascii?Q?ZfFG81zFbkPwuqcS5ddSgqJVoW7NBg8Cad3b+SuptEW6swZXwXx0bQ+dGXHm?=
 =?us-ascii?Q?fwfjK63dm+ujgLB6GqOlyFzvFpSwFiIHIdtyAJo++5VCCUJQctIX3gvOdyLu?=
 =?us-ascii?Q?E73tcsAfp5vHhqecYci4V9L99gEu+cGDrXEMLXPZgokHbBb+E+xwx7NvryH6?=
 =?us-ascii?Q?WTnfJiQYPKPrNfrZTt4EaIYOJGEs93EjqbL0q9U2v+HRMB22tt6Nm3bZjQVN?=
 =?us-ascii?Q?ljBx+YOshSFy9FMu/fnt8gKjOg4rEgL8l36IEQ5Nl6OqvmD3r3eXX+zN5/Bs?=
 =?us-ascii?Q?2BNlXyLH7OsXYMEmSUV9NkI2XxPSkcllXj562SyOV5HvxkJCBgbcAdvO3XXh?=
 =?us-ascii?Q?wkaUeIW95gMS+lHp+HZnY537j0hl5jLxFIPzw/IMXHTxmyK5L5zrfjbCmzMs?=
 =?us-ascii?Q?c1UJpRTiYcb+/dv7dF6GeGnl6SBp9PpEEjqQ7KMgkWfJjQAIyPl47ysLqYC9?=
 =?us-ascii?Q?pW8vWZG+5OTHhdImJOWMxphX50wFad38L2s/j+zzjOI0iNOPlsdiNHnVvXHu?=
 =?us-ascii?Q?Tm8a8Ky8dslW2z13ICufvS52FzIcUCdW8fZy7yVmwqm8hLRVipMtOkm/1MSh?=
 =?us-ascii?Q?lbOvoqmPrk5drm0Nq5rdxIOOFxq+f5gYoxbVRKJBetIxA+V05XhQBppWseII?=
 =?us-ascii?Q?x61ZSA4quKIhjpYH7RYOAuBZpRcV7TDREjgu03BUcC6F6B5C0nMFo/mG+XUE?=
 =?us-ascii?Q?HllyU2JXW6nHEhdbD9Zq9/+1jGMcYJlYJXj9QIPWWp2RKnk2enYaN9Fq+92g?=
 =?us-ascii?Q?gfd6uU5nJUWA4PyBnsx6f6Hx8TlPSTMr12wLlePF+63z3Frep24lzELe9Rn0?=
 =?us-ascii?Q?ZOwlkHFm6cK9CJzMpkR0RVTPnMkmlq4l9IRR85LKidH7ZoE5P3mY+ckaNPaX?=
 =?us-ascii?Q?e6HzlUlvDdc9aN96PsX/ddm6mErQDkQZnVJRDqCbM0YpxeJi6tgmpCxLyHH/?=
 =?us-ascii?Q?jep1ZIFvkh750KP7vkwnCMOGC1WAETqSIDMbFfjzCx5ej3TZ7J8/6FqwQK76?=
 =?us-ascii?Q?yI1sRClqJOkTsYr/KQ1FKoGxjF1V1edFtgt6T2mUibOcYN3kxuAnN1HkglTU?=
 =?us-ascii?Q?Y4df1HxM0ElooY2A4JSlMdKpeFE4jhVsHxvffH83uerZo+E2EzHhJiQo1d47?=
 =?us-ascii?Q?Fjllew=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 058e1db7-53ea-4a1e-b3d8-08db0a8c6dd6
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 10:57:25.8962
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NPoxQpiSCS9NvqameoTNQQna2Vc0iwYOVn9261+2Vv8y00/GlGDjgpX337QNPF+djM+89NsJlCDrQHgHMLl+pI5OTbhfNRbRsijEZWdWxHA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR13MB4974
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 09, 2023 at 10:44:05AM +0100, Oliver Graute wrote:
> This enable the LEDs for network activity and 100/1000Link for the RTL8211F
> 
> Signed-off-by: Oliver Graute <oliver.graute@kococonnector.com>
> ---
>  drivers/net/phy/realtek.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c
> index 3d99fd6664d7..5c796883cad3 100644
> --- a/drivers/net/phy/realtek.c
> +++ b/drivers/net/phy/realtek.c
> @@ -416,6 +416,11 @@ static int rtl8211f_config_init(struct phy_device *phydev)
>  		}
>  	}
>  
> +        phy_write(phydev, RTL821x_PAGE_SELECT, 0xd04);
> +        phy_write(phydev, 0x10, 0x15B);
> +
> +        phy_write(phydev, RTL821x_PAGE_SELECT, 0x0);
> +

nit: it looks like the indentation in the new lines above should
     be using a single tab rather than 8 spaces.

>  	return genphy_soft_reset(phydev);
>  }
>  
> -- 
> 2.17.1
>