Subject: Re: [PATCH 2/5] crypto: hisilicon/qm - change data type in min_t
To:     Herbert Xu <herbert@gondor.apana.org.au>
References: <20230203093730.49314-1-qianweili@huawei.com>
 <20230203093730.49314-3-qianweili@huawei.com>
 <Y+S9kS8cElGRGysn@gondor.apana.org.au>
CC:     <linux-kernel@vger.kernel.org>, <linux-crypto@vger.kernel.org>,
        <wangzhou1@hisilicon.com>, <liulongfang@huawei.com>
From:   Weili Qian <qianweili@huawei.com>
Message-ID: <658e62e1-2337-32df-3641-03a4789f30a0@huawei.com>
Date:   Thu, 9 Feb 2023 19:12:48 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <Y+S9kS8cElGRGysn@gondor.apana.org.au>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2023/2/9 17:32, Herbert Xu wrote:
> On Fri, Feb 03, 2023 at 05:37:27PM +0800, Weili Qian wrote:
>> 'act_q_num = min_t(int, act_q_num, max_qp_num)', 'act_q_num'
>> and 'max_qp_num' are 'u32' type, change min_t() to use 'u32'
>> type instead of 'int'.
> 
> If they are of the same type, why not just do min?
> 
> Thanks,
> 

Thanks for your reminder. I will fix it in next version.

Best regards,
Weili