Date:   Thu, 9 Feb 2023 12:13:26 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Daniil Tatianin <d-tatianin@yandex-team.ru>
Cc:     Ariel Elior <aelior@marvell.com>,
        Manish Chopra <manishc@marvell.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Yuval Mintz <Yuval.Mintz@qlogic.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v0] qed/qed_dev: guard against a possible division by zero
Message-ID: <Y+TVVuLgF+V7iTO1@corigine.com>
References: <20230209103813.2500486-1-d-tatianin@yandex-team.ru>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230209103813.2500486-1-d-tatianin@yandex-team.ru>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PwE0jpIQ4OH0eaxrrA6BV1runafqmqwP0aTQXGE4pRY4AT6C/i80uYndmHjG?=
 =?us-ascii?Q?V9aX6FOiseWsY6mCtezg+lmhWyNknJsRZ+pSNEIoe44Fj+09k/S4HBxlpntT?=
 =?us-ascii?Q?M+HU5gb5vkAJW4E0VcBLzysiMZ3B5Y22xrFiRterQEoKytBhIP9YbWyhtlNN?=
 =?us-ascii?Q?8OK//AFBftwSWvcpe4efEJFc44hhdYOHGadl8uNSmUsThR4jp1ekKuAcAUZr?=
 =?us-ascii?Q?G06AQQDz/CaGNkkDNFGM+eXys/FWUizShFheS981kwaEpC8E1mShhV9PsjxE?=
 =?us-ascii?Q?sfOHkJvS2v9i04v82rERpzjmU5813r5x+OwvJm0DGKIouSwvIW9LZ+BKE92k?=
 =?us-ascii?Q?CJfqk3wRT+SA9F2AzR5j8e+L8aRgrSOmSPPDS8OvCxjm9pDGtGlG//CeWObG?=
 =?us-ascii?Q?Y8A1BHlYDMcahZNjaA2mpWr+K50Q+pIAHUxJKyGEXTKcdw5d674+axY3YskX?=
 =?us-ascii?Q?L+7HMXyENssmacUm0m05H3y0BcO2bdvH5MJ4BjK6g2TsPXNtm9D6H7hfu3P0?=
 =?us-ascii?Q?CoM7fU1oHFynh/GgUDbcHucWyBRs5rlt0VwtuXNN+UeTOPQ4+oCr7F1VfBy7?=
 =?us-ascii?Q?L4W47npTyViNKsO11FL005GvxHwDBxyJpXMZ+8kRJerie11fYozoU2sXyOq6?=
 =?us-ascii?Q?yk423pL+1ZrsMG0M3bWvU1K2mLxGIKxSAnEgqBa4HLbqDeITaM22DAXr136C?=
 =?us-ascii?Q?uC+Al5hsbYX5dgsx6qCasLUogdiOGxfPIi7xYcdHMbWCO25Dgj+XtdDBcxK/?=
 =?us-ascii?Q?fIX+a8VrJRAXciu+toWoJ5zElnKS8BHKmUNIr9WbmwghygJNOUpW0QW94h4f?=
 =?us-ascii?Q?TYAzSi39Mslz5sfGrlJaqiQjxu9MCgW6N0csTktY91Y0tS9mxJnMgfk35nmv?=
 =?us-ascii?Q?4tZ1NVB36U6Ooi/l0dlAQjJCwnAr3LSjTGh5vX4ekekv4pxm3zLkDkSqKH1f?=
 =?us-ascii?Q?YdpYPb0EMc2RJx7wGoSfG/uNyQ8DUAk1ZrQSZGnlOG8xrw0kcYd3WGL87NnZ?=
 =?us-ascii?Q?fihOKH0Ej1bGiZmIWkBR/D4Te/0NUn/eqAnwuC0QlDUJsazppgfhmxmIkj8+?=
 =?us-ascii?Q?H4ZcixICeC1dAza/gC5c7E0f6VXNDL8QWjw7e4+iO9gImWYPpIJlwgziuUDT?=
 =?us-ascii?Q?dLYUX8ZU2mO7bT+bKrCYYy/QuWfUfWG7GhokhFKG6fQHmU2HOnYpXVSmkNxy?=
 =?us-ascii?Q?H4uqn1cylT0f0PDy961q8daobVCukVQGKxkgpGSX/1zHtODoXEFZJgRSO6Fz?=
 =?us-ascii?Q?pambh4UhprWfZz8Sfjcmd1zojzlCkHcssfTXJkSBJ4wvYSFw8rUwWotlN0qu?=
 =?us-ascii?Q?KBuIjOPj1Tq45D4T8zgDDUR3L5XoW2axVmg3uC81wfrIenOecg9jhxQNM4Yj?=
 =?us-ascii?Q?8K1QNNCh6WwvK0BwRo5XX16Q8F2/v+cvwiU9lWUup+VdBrzw/BanAK/FmQrp?=
 =?us-ascii?Q?PxylnSGmUAYY6KbDeZhJ8ISWW+lTflQiBN0PsiPgd1SLLjLdX2jZ+KWyVXCw?=
 =?us-ascii?Q?Yzs4qo+lxf4gISFR+oXjywI58DWaAE2EwUoFbyNhCUFMFleJunGP8i4foVbj?=
 =?us-ascii?Q?1PaUXzXWtJX3tGBxbF9E6jHdllDFx8Cx9Tbaz05PZBmjOFvr2B6mDKsIwfek?=
 =?us-ascii?Q?EW21pWH9+fLlnKw1o8bmdQp+6+pTA/jDtRNj8H/rEI5jDw/duFwh+sUmlgfK?=
 =?us-ascii?Q?A9MSiA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0f8779ba-2fc2-45a3-36f3-08db0a8eadc7
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 11:13:32.1924
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MG0uD3u7zoLh18PiYBTCm8QvmL/IHIz9p6y86bErFDZpox/gBc616DV0Vch83qBsUqJcjHjczQ2DA7lxRrPQmjuVMiQ95UkbnL6bKc657Fo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR13MB5455
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 09, 2023 at 01:38:13PM +0300, Daniil Tatianin wrote:
> Previously we would divide total_left_rate by zero if num_vports
> happened to be 1 because non_requested_count is calculated as
> num_vports - req_count. Guard against this by explicitly checking for
> zero when doing the division.
> 
> Found by Linux Verification Center (linuxtesting.org) with the SVACE
> static analysis tool.
> 
> Fixes: bcd197c81f63 ("qed: Add vport WFQ configuration APIs")
> Signed-off-by: Daniil Tatianin <d-tatianin@yandex-team.ru>
> ---
>  drivers/net/ethernet/qlogic/qed/qed_dev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_dev.c b/drivers/net/ethernet/qlogic/qed/qed_dev.c
> index d61cd32ec3b6..90927f68c459 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_dev.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_dev.c
> @@ -5123,7 +5123,7 @@ static int qed_init_wfq_param(struct qed_hwfn *p_hwfn,
>  
>  	total_left_rate	= min_pf_rate - total_req_min_rate;
>  
> -	left_rate_per_vp = total_left_rate / non_requested_count;
> +	left_rate_per_vp = total_left_rate / (non_requested_count ?: 1);

I don't know if num_vports can be 1.
But if it is then I agree that the above will be a divide by zero.

I do, however, wonder if it would be better to either:

* Treat this case as invalid and return with -EINVAL if num_vports is 1; or

* Skip both the calculation immediately above and the code
  in the if condition below, which is the only place where
  the calculated value is used, if num_vports is 1.
  I don't think the if clause makes much sense if num_vports is one.

>  	if (left_rate_per_vp <  min_pf_rate / QED_WFQ_UNIT) {
>  		DP_VERBOSE(p_hwfn, NETIF_MSG_LINK,
>  			   "Non WFQ configured vports rate [%d Mbps] is less than one percent of configured PF min rate[%d Mbps]\n",
> -- 
> 2.25.1
>