Date:   Thu, 9 Feb 2023 13:39:17 +0100
From:   Oliver Graute <oliver.graute@kococonnector.com>
To:     Simon Horman <simon.horman@corigine.com>
Cc:     andrew@lunn.ch, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH RFC] linux: net: phy: realtek: changing LED behaviour for
 RTL8211F
Message-ID: <20230209123917.GA1550@optiplex>
Mail-Followup-To: Simon Horman <simon.horman@corigine.com>, andrew@lunn.ch,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
References: <20230209094405.12462-1-oliver.graute@kococonnector.com>
 <Y+TRj2hehU76+Ytu@corigine.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y+TRj2hehU76+Ytu@corigine.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?n7TJQ+mSWFpiP1r30FF4XnN8Xrpe8sq5TSflHWT675K+RV0nGVv3lfwO9OO9?=
 =?us-ascii?Q?Mobq6BWycim/95LsJpNVYxZfQX1n0xjmk1SxyXXeKl8JTL6108H2+t7cp3SN?=
 =?us-ascii?Q?0w45f2FNtEvzuhzJVWXiR4pUxsSDU5bRGy0TZXUDKJj9P7cZMjMB1p72QXwC?=
 =?us-ascii?Q?dSDeZVxtRzQWAlP/JO+UEAbQ9z/hMvgpbUvN73Laht+ZNXK+dIPxWEl3933l?=
 =?us-ascii?Q?yeERMy28f65kRSoWymcjU6UkGA1RKE37YH0C6WF1JQsHQLbJczgJK2Ps4qDd?=
 =?us-ascii?Q?IyDeZeARdmZYhd0xu1lyLFSknOG7f5s2QvYs9LAGYNSjXLPx0h1Lx4cOiH9I?=
 =?us-ascii?Q?CRxQo1KNN4vVfQpoENYOUOEMR+yIyu0Bg9NqhwsYDYzy66FfTDQPzoUe5Vat?=
 =?us-ascii?Q?G51zdYlMDLC+K5MccNdQLYEXKiTvkhvF1kPbQS1zG9ZMshfY9cihf1eIbCnG?=
 =?us-ascii?Q?/x9C44ub27fx78eUJVaSWoNNSH0CB+KqX9+vkCI0JpkWH1psuuUPSJHZJxcj?=
 =?us-ascii?Q?XQ1uk1zwFTK1QHDDvXsZv+g8baQshmeKHxMWM/Ny3CV3MRBovGdlJb93tHy1?=
 =?us-ascii?Q?womuePS0xanoIcfTAIcytA77LoP9pe873CKDkNiVc8MJOGofkqTX/T9ejztv?=
 =?us-ascii?Q?gtTjvWmdhEsaBnzBtOHyUUsnJgZH1vTYgjf6E6/GJ8hSzg1kYEAK2nzcOOJZ?=
 =?us-ascii?Q?xS3GMved5d1SjTFiRW+X8/il9PqBZExBl4yyq+SOb56MMH/g1uJmPw09GSEk?=
 =?us-ascii?Q?+MQ23/dzigZvCzinRtOCq/DZB3UtLk/+piCsJFYl6F7fYBJRHrO/VeUbFevM?=
 =?us-ascii?Q?0f2DTQ6RAFRHgTZun4xjQllHP/u2109qDLD1DlupLiukaU9jJ5H9K2YgpK97?=
 =?us-ascii?Q?qb7VjO1PUAyosYD1lJOukocxVgWKVXxHPSYMbx7kuYShbQ5vyhqjLJqu635O?=
 =?us-ascii?Q?NZrogCq8+sIzV63t3ojp9YHa1gqpvXiXrz4v5XCRFF1Oy2GiX+iBue0kMf97?=
 =?us-ascii?Q?OOyOmtz/gj0wp9biqHyhBO/bWlyhnA1tq7bfL3le0JnRchGcLOvfL9Ajs4e1?=
 =?us-ascii?Q?IyGRPZCh5VrRJESbeEneEwcOcNGDP45ClPUUSX+o4GzeKuYIHsGN3ssVbV2z?=
 =?us-ascii?Q?8H13Lrd187OVf4ama+QazLo7Fg7sFwtFp2lqT1/CxRv9gRSvgzXAXlS5Dh+Q?=
 =?us-ascii?Q?qo+ZzJHuixA4JmcKBJlUJcqHyiRPDO3alAuUKsqtZA4fBsCK9xzj2VyNZwy5?=
 =?us-ascii?Q?0LTax8M+jnRDp3aEJRGfU5+yiwrYYlbAiXLxW53OnfDtGbcvQPEyrwtsQMzt?=
 =?us-ascii?Q?Q+1Q/tMTJxQz91ATLYYMD5m+qUH9U+WvulX2isNiLv4zuTgL6qbOdo/IWd7M?=
 =?us-ascii?Q?pP+CQYfXT64qI7ZwG1fgVZ9UIhguOxM+f4P+Zy+4/+SQ0FQxsuLz6vZyVSmx?=
 =?us-ascii?Q?CeNKvkOz+p0iUdXJJm1usC7sKizKvPKzA6ElsKZPTyLVj7u8p3O4uTcIY5nW?=
 =?us-ascii?Q?O/07WE9benBXytaNHl83h6NmZn8e8KZGWlfoaMIQ1cgCPMNh39dGK2j/eOeR?=
 =?us-ascii?Q?sCWPNUltOBh1R/Jah9Nh6QmktY/8AqgUgJypqPEc8eM0twteo3vkHXG+4TJs?=
 =?us-ascii?Q?8rmJ1v7FEBn/JQmOVjLiI0s=3D?=
X-OriginatorOrg: kococonnector.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f81bea4-901e-4623-4afe-08db0a9aae88
X-MS-Exchange-CrossTenant-AuthSource: AM9PR09MB4884.eurprd09.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 12:39:27.4028
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 59845429-0644-4099-bd7e-17fba65a2f2b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pzxPPZmgE9fX2KQPy7LCNb4ghDzbMg+i8j2I5l0Lv19R/L3VdVMsjRgWNYfyNpK4hdBgz0Tqp/QQrmPN0jqaPtUj4UuhCvV7xOdLR1oF+hQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR09MB5795
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 09/02/23, Simon Horman wrote:
> On Thu, Feb 09, 2023 at 10:44:05AM +0100, Oliver Graute wrote:
> > This enable the LEDs for network activity and 100/1000Link for the RTL8211F
> > 
> > Signed-off-by: Oliver Graute <oliver.graute@kococonnector.com>
> > ---
> >  drivers/net/phy/realtek.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c
> > index 3d99fd6664d7..5c796883cad3 100644
> > --- a/drivers/net/phy/realtek.c
> > +++ b/drivers/net/phy/realtek.c
> > @@ -416,6 +416,11 @@ static int rtl8211f_config_init(struct phy_device *phydev)
> >  		}
> >  	}
> >  
> > +        phy_write(phydev, RTL821x_PAGE_SELECT, 0xd04);
> > +        phy_write(phydev, 0x10, 0x15B);
> > +
> > +        phy_write(phydev, RTL821x_PAGE_SELECT, 0x0);
> > +
> 
> nit: it looks like the indentation in the new lines above should
>      be using a single tab rather than 8 spaces.

thx, I will fix the indentation. 

is this the right place to turn on the realtek phy LEDs for RTL8211F?

Best regards,

Oliver