Message-ID: <82dc25d8-1df3-87c7-0397-3fedd6f262fc@redhat.com>
Date:   Thu, 9 Feb 2023 14:07:19 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [RFC PATCH v2] sched/deadline: Add more reschedule cases to
 prio_changed_dl()
Content-Language: en-US
To:     Juri Lelli <juri.lelli@redhat.com>,
        Valentin Schneider <vschneid@redhat.com>
Cc:     linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        Eder Zulian <ezulian@redhat.com>
References: <20230206140612.701871-1-vschneid@redhat.com>
 <Y+I86kr73LlKVmW/@localhost.localdomain>
From:   Daniel Bristot de Oliveira <bristot@redhat.com>
In-Reply-To: <Y+I86kr73LlKVmW/@localhost.localdomain>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/7/23 12:58, Juri Lelli wrote:
> Hi,
> 
> On 06/02/23 14:06, Valentin Schneider wrote:
>> I've been tracking down an issue on a ~5.17ish kernel where:
>>
>>   CPUx                           CPUy
>>
>>   <DL task p0 owns an rtmutex M>
>>   <p0 depletes its runtime, gets throttled>
>>   <rq switches to the idle task>
>> 				 <DL task p1 blocks on M, boost/replenish p0>
>> 				 <No call to resched_curr() happens here>
>>
>>   [idle task keeps running here until *something*
>>    accidentally sets TIF_NEED_RESCHED]
>>
>> On that kernel, it is quite easy to trigger using rt-tests's deadline_test
>> [1] with the test running on isolated CPUs (this reduces the chance of
>> something unrelated setting TIF_NEED_RESCHED on the idle tasks, making the
>> issue even more obvious as the hung task detector chimes in).
>>
>> I haven't been able to reproduce this using a mainline kernel, even if I
>> revert
>>
>>   2972e3050e35 ("tracing: Make trace_marker{,_raw} stream-like")
>>
>> which gets rid of the lock involved in the above test, *but* I cannot
>> convince myself the issue isn't there from looking at the code.
>>
>> Make prio_changed_dl() issue a reschedule if the current task isn't a
>> deadline one. While at it, ensure a reschedule is emitted when a
>> queued-but-not-current task gets boosted with an earlier deadline that
>> current's.
>>
>> [1]: https://git.kernel.org/pub/scm/utils/rt-tests/rt-tests.git
>> Signed-off-by: Valentin Schneider <vschneid@redhat.com>
>> ---
> This looks now good to me, thanks!
> 
> Acked-by: Juri Lelli <juri.lelli@redhat.com>

Reviewed-by: Daniel Bristot de Oliveira <bristot@redhat.com>

-- Daniel