MIME-Version: 1.0
References: <20230207145444.166950-1-clement.leger@bootlin.com>
 <20230207145444.166950-2-clement.leger@bootlin.com> <CAMuHMdVL1YGnX4X2R_O1tMhRt07R8XUD2eWeFFgTcm7ShZrdcg@mail.gmail.com>
 <20230209141610.31146ea9@fixe.home>
In-Reply-To: <20230209141610.31146ea9@fixe.home>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Thu, 9 Feb 2023 14:15:08 +0100
Message-ID: <CAMuHMdVs95HXi=sJOE9jyn=jkBtzJTwkqsY+-1hmLEbaV=JWuA@mail.gmail.com>
Subject: Re: [PATCH 1/2] dt-bindings: soc: renesas: renesas.yaml: add
 renesas,rzn1d400-eb compatible
To:     =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= <clement.leger@bootlin.com>
Cc:     Magnus Damm <magnus.damm@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        Herve Codina <herve.codina@bootlin.com>,
        =?UTF-8?Q?Miqu=C3=A8l_Raynal?= <miquel.raynal@bootlin.com>,
        Milan Stevanovic <milan.stevanovic@se.com>,
        Jimmy Lalande <jimmy.lalande@se.com>,
        Pascal Eberhard <pascal.eberhard@se.com>,
        linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hi Clément,

On Thu, Feb 9, 2023 at 2:13 PM Clément Léger <clement.leger@bootlin.com> wrote:
> Le Thu, 9 Feb 2023 09:48:09 +0100,
> Geert Uytterhoeven <geert@linux-m68k.org> a écrit :
> > On Tue, Feb 7, 2023 at 3:52 PM Clément Léger <clement.leger@bootlin.com> wrote:
> > > Add "renesas,rzn1d400-eb" which target the RZ/N1 EB board when a RZ/N1D-DB
> > > daughter board is plugged on it.
> > >
> > > Signed-off-by: Clément Léger <clement.leger@bootlin.com>
> >
> > Thanks for your patch!
> >
> > > --- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> > > +++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> > > @@ -431,6 +431,12 @@ properties:
> > >                - renesas,rzn1d400-db # RZN1D-DB (RZ/N1D Demo Board for the RZ/N1D 400 pins package)
> > >            - const: renesas,r9a06g032
> > >
> > > +      - description: RZ/N1{D,S} EB
> > > +        items:
> > > +          - enum:
> > > +              - renesas,rzn1d400-eb # RZN1D-EB (Expansion Board when using a RZN1D-DB)
> > > +          - const: renesas,r9a06g032
> >
> > Don't you want to have "renesas,rzn1d400-db", too, in between the two
> > other values?
>
> Do you mean like that ?
>
>  - enum:
>     - renesas,rzn1d400-eb # RZN1D-EB (Expansion Board when using a
>    RZN1D-DB)
>  - const: renesas,rzn1d400-db
>  - const: renesas,r9a06g032
>
> And thus using compatible = "renesas,rzn1d400-eb",
> "renesas,rzn1d400-db", "renesas,r9a06g032" in the EB dt I guess.

Exactly!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds