Date:   Thu, 9 Feb 2023 09:23:03 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     "Tian, Kevin" <kevin.tian@intel.com>
Cc:     Nicolin Chen <nicolinc@nvidia.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "will@kernel.org" <will@kernel.org>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "shuah@kernel.org" <shuah@kernel.org>,
        "Liu, Yi L" <yi.l.liu@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
Subject: Re: [PATCH v2 02/10] iommu: Introduce a new
 iommu_group_replace_domain() API
Message-ID: <Y+Tzt0p+hDz0QMfH@nvidia.com>
References: <cover.1675802050.git.nicolinc@nvidia.com>
 <fa81379dca611c1d9f50f9d8cd2bca0d4ec7f965.1675802050.git.nicolinc@nvidia.com>
 <BN9PR11MB5276859C11057878722F30988CD99@BN9PR11MB5276.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <BN9PR11MB5276859C11057878722F30988CD99@BN9PR11MB5276.namprd11.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5ZL8HR96FBqqNF5fj1DNX99Bf+d8XYJwjYLupf3bb6EZ8cjHqymvjw9hyz2n?=
 =?us-ascii?Q?x7Z0y+WzIwe13Es/awJQH9c9hyOx72uLxsHKuSdLbbttGezehDS7X0MzoZ2G?=
 =?us-ascii?Q?zvP1opyfEpP7EIDbuMzv22shg539QhQamyL7Y1vumOKEA7FQTZnTLOzYBvA8?=
 =?us-ascii?Q?tM0bxTX5wOFbnkw6Y5agD/hPPOqeTA8ej3DQ99DADoYh9SVxtZqgwx/b+eaM?=
 =?us-ascii?Q?G80cheO8ThnMHrvz/xYrhIjrvcKRcVdOtSkZpwTQ0iGy9+lIgOt8P37Q4a0c?=
 =?us-ascii?Q?M1XniDnZbVuGHAre522/mD7vlxoD5+zQWk9sXzkQZQpvQF0JD01xwSKJvFVx?=
 =?us-ascii?Q?OcuMnZeI7G6YsEcK2AdvXbqn1ig4ycGCf8aQBDmN2lJeYooU/G1O6qhWtYeI?=
 =?us-ascii?Q?KaJkUSaQKgqC84NNKVrXiKTk/ZJAte1dzY9cacGdJYnNKmZcEMdchQhmmkDM?=
 =?us-ascii?Q?g/yeCfppIM3OVzkNAxYT6GsIayqOB4wlrB4P6mnz+UUZxgAhZoqxuOAETo4H?=
 =?us-ascii?Q?elkzl12XY6/DXhfwlbBLvuvmql1Zaq5Sm2fu6Q1Azo5QcuyA8V0K1kQBlbIy?=
 =?us-ascii?Q?Is2HdkS1az6PxRSBcyTa6rf7bg4VMQ8yyuuhOtVmt74evDcOLFKAD93yt+BN?=
 =?us-ascii?Q?AuM3ONyoBMh3NDi+cBLihteieW4VLrt/xZe1DNRG0zEUG5Lwq45jB1Dts07G?=
 =?us-ascii?Q?xdcetFPuc0hslf9I696U6maaW9r+9CKc4zTAq+9A5WAGPzXXnymkQpSgxT4D?=
 =?us-ascii?Q?kCviH3J/1QsKUgpH9oLeV9nThWtPxUJEwLmdIZ3OH7JrbX0RtN+CXLeOjcAx?=
 =?us-ascii?Q?Hy7LPtVS3RyXS4kTmYjX26uVk/8ujIc2PDRIJyuI1XJ3ELhnr1RQb8iP4wwT?=
 =?us-ascii?Q?dgUzXZJ/7Y2oy1BTzR7J6bWn8lk6xxSeDhf393giEXW+M6tnZU8QlZCiob57?=
 =?us-ascii?Q?sPINddfQiPBzqMPaIVJ+eNEgrB0gWT/Bf5QH/mWtLYF+2RhjnSlkVRkwVHCz?=
 =?us-ascii?Q?DRLfz0bV2zP1IR8MUKVKcVm9+vnfuUOt7SfDolIIH4O5NYgsV7wTJ6528Hxm?=
 =?us-ascii?Q?QqyHJVmI89cQ6279FZrkCpPd+wKo1dzw98N563B4G8elSad5xJWMW4brD50o?=
 =?us-ascii?Q?C7y1eaY7GYs+6VFZVPwqEYrP4ORHkhcoQVdRYxaYdR5rbvJzrjo22EFWrK/y?=
 =?us-ascii?Q?/CTQvxVOfnwxb1H9uBUDGf9YkXha/0jJA3iW4/qIFHdxcmvuZvvTVfQkYotf?=
 =?us-ascii?Q?wKgaXa9iqUJHyYbxfDYI+SGA9B5CBU01FAUYQQklLU+L4LqCTY4AEfn9Nd0Q?=
 =?us-ascii?Q?l2U26mVMigCnEHK+Atc0yeDCBLS5Wwr0gENlutUJRiSn1t9CEP8D5ZbULsAr?=
 =?us-ascii?Q?wP+bel5u817SRYD09wslNqcZB+yKoeEHSEEjPSNFYObrlPfer5MUINmxpWk0?=
 =?us-ascii?Q?5COlZUgEpaeX4NxADiz/dzXmGiNvr0spT0lq2/JkPecRXRzGxwEG97b5znCD?=
 =?us-ascii?Q?nrjxHX/fKsQ7Nj00d7JeX/nrHIhhUeV1bKp6yUHAF6ktnPrySg41aTTXQL8a?=
 =?us-ascii?Q?fRV7/elTOAXNh0CwUq+D0SytjWSuOLD0Mg06qljM?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 29f49086-a943-4433-28e3-08db0aa0c6a8
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 13:23:04.8417
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iN1jHQ769BN7Y2fCR3ua+/HKbbtWXOhxYMsqYeWQPTvMfSro5K0U94YH/lK7X2Yp
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8336
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 09, 2023 at 02:55:24AM +0000, Tian, Kevin wrote:
> > From: Nicolin Chen <nicolinc@nvidia.com>
> > Sent: Wednesday, February 8, 2023 5:18 AM
> > 
> > +int iommu_group_replace_domain(struct iommu_group *group,
> > +			       struct iommu_domain *new_domain)
> > +{
> > +	int ret;
> > +
> > +	if (!new_domain)
> > +		return -EINVAL;
> 
> Is there value of allowing NULL new domain so this plays like
> iommu_detach_group() then iommufd only needs call one
> function in both attach/detach path?

We've used NULL to mean the 'platform domain' in the iommu core code
in a few places, I'd prefer to avoid overloading NULL.

IMHO it doesn't help iommufd to substitute detach with replace.

Jason