Date:   Thu, 9 Feb 2023 09:26:15 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     "Tian, Kevin" <kevin.tian@intel.com>
Cc:     Nicolin Chen <nicolinc@nvidia.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "will@kernel.org" <will@kernel.org>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "shuah@kernel.org" <shuah@kernel.org>,
        "Liu, Yi L" <yi.l.liu@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
Subject: Re: [PATCH v2 10/10] vfio: Do not allow !ops->dma_unmap in
 vfio_pin/unpin_pages()
Message-ID: <Y+T0d9ox3KnqMDIL@nvidia.com>
References: <cover.1675802050.git.nicolinc@nvidia.com>
 <59e5eeac675172ab1cb07236a3eb3e166553fe71.1675802050.git.nicolinc@nvidia.com>
 <BN9PR11MB527687E27FC35CD842E4EA7B8CD99@BN9PR11MB5276.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <BN9PR11MB527687E27FC35CD842E4EA7B8CD99@BN9PR11MB5276.namprd11.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dYtuwKH9Kkwu49JJtXeiAnaiF8CI1qjOf3Jzc9JeD780YtreRxEuBri02FYq?=
 =?us-ascii?Q?88wpYy7xvKaFHJT7V1/tjqrHMJI2UJK7D3oF7vMfZtojDJZWbsKzJFxhZyaE?=
 =?us-ascii?Q?RN7QI4FYiyVRH3/VjqyW0rt3V+s2nIHY9kfHLddS8XbMdsN7z0J2s44ZcZaA?=
 =?us-ascii?Q?bRktCyMY1HxemlUx22LhznCVaERkSPtfHMuwiNWn/ASaLB22ZMfeBsSoIJdg?=
 =?us-ascii?Q?WREMuk/qrauhb8LDmkob5aZhdLemZNj1L6Lj8M40vRjKvApXFsrcUlJOHTYC?=
 =?us-ascii?Q?wq2XKmm97PBCsZsY5lZ6SgB33RjrNFBM8DF7kl/54Pw1ZRwqgJqIM1sZH6BD?=
 =?us-ascii?Q?T8Xhq/43n0IO2mrlxmujFg5nRu0GcPuy6iIzRelxqtUS1cwJ+11BrdEkw0Y+?=
 =?us-ascii?Q?yii2Sb4GdlfA4kE3ljusoqXnbZFbJW7tLLAUuZJI7oVG5zs7w/3kklmWnFXU?=
 =?us-ascii?Q?3+4d27013AlKKJ0GnoffPSNnOU5ufo+/B/JSeOqMUbR2bP+LVsqKzJAU6Bkm?=
 =?us-ascii?Q?5pnYD9gbyV8Znf60pyjwjn+kcjPzD7GYp50McD+Lw3NHeWeNUomRpS8BzPav?=
 =?us-ascii?Q?PNSnSqXO22aQuwE7VI6VRv7Jxxh5jiuTo3WDE/GUmwT6xc5bEZwb/CVpkWlg?=
 =?us-ascii?Q?TBtEsJhwqjRpCjTZHl+CBLg8ffFmp2WkxlTA5vmQYsvoyeiqqxGP+1UokCfx?=
 =?us-ascii?Q?dQnnVQjze/b3rMKnbPWedQWt/CvlbMxsFjiokUmlIfwwT0sM6mtyB3lrwlTd?=
 =?us-ascii?Q?IIoc8EHwpSNKMrq5MkW1WutmqlBaCHYYHNQW28d0qBs0y6ROcCoZt2WhhEcd?=
 =?us-ascii?Q?S7IvFfInp7CjOl1l6RZQT6ndLW2/ki4/XIwK+T75VBur1OS0dtF9FxnATXGF?=
 =?us-ascii?Q?BkKF9oGpfUO7nICGafA1ZOkO1A0fWEqh2KeUH9/kDRIZWJ7AMgZ8RuR5Iol+?=
 =?us-ascii?Q?oXFFPPI0SMt2cGd9NLWzbZ6zJzxDd23f8bzVK2lyo1ryLcklHtReQGLIIvtw?=
 =?us-ascii?Q?1E+bp1PEcR4JhPh7xiYcMcWFBLQtFCbFvR9jGuIU2TyGHKq9MR62ZWAWsH90?=
 =?us-ascii?Q?/S6SPpUOKCor5IEIHPLyADMKsPwxao4UK/clID6L4IKAmRCvlXlAUngjtpai?=
 =?us-ascii?Q?v6k1mrjTVAe5+ggCnucjsnUnTAHEaVQUzaKvvzR4lZZ2m/WlCliyLw9Yku2w?=
 =?us-ascii?Q?GZ0jygtHFCNQsAvLyJf6zAEVlgc20dq1xjUQy6gIPrDqxLura4BwSw509Tu2?=
 =?us-ascii?Q?GkxxBkozO3YHUnXbB1kJZA/6Bx6WLaqAatGvju5dwQ/DvlpOyiVY9DA1TOTb?=
 =?us-ascii?Q?RbLWd5y0jl5bro4s6QDaHMXhWluZJwa+nYzIvq0cRt12NMDp34ZCk0ifwZSq?=
 =?us-ascii?Q?R8f89ZelKEbWtRHglJ4WJCpwRWL0pkhkoftKxUSWw6dkRdnYf7sFqSLvnCaE?=
 =?us-ascii?Q?SVAPgbrKOmnDrIXdQ8k+AjJvCbuJAlsB/9RgW/u+PFfVmfiCl6/qLtq73pAs?=
 =?us-ascii?Q?aKclEagUEvLbkHm3uPVYwU6Z6NQVYR8BTOeGWzHJMjBpjMD8AGaJYNJVum1J?=
 =?us-ascii?Q?KCGM+ybroyq8LYOqxI3IraN+ghq6ec0s6lC6+Pet?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1167d5da-d2f6-4ceb-6c40-08db0aa138d0
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 13:26:16.3815
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WYydmCKUWg1zYwasMInjqKmD6GaRA9HKTVZew8JCcx2+u5opeNhHlN8e1AI8AymM
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8336
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 09, 2023 at 04:10:04AM +0000, Tian, Kevin wrote:
> > From: Nicolin Chen <nicolinc@nvidia.com>
> > Sent: Wednesday, February 8, 2023 5:18 AM
> > 
> > A driver that doesn't implement ops->dma_unmap shouldn't be allowed to
> > do
> > vfio_pin/unpin_pages(), though it can use vfio_dma_rw() to access an iova
> > range. Deny !ops->dma_unmap cases in vfio_pin/unpin_pages().
> > 
> > Suggested-by: Kevin Tian <kevin.tian@intel.com>
> > Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> > ---
> >  drivers/vfio/vfio_main.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/drivers/vfio/vfio_main.c b/drivers/vfio/vfio_main.c
> > index 8559c3dfb335..c7f3251ad6e5 100644
> > --- a/drivers/vfio/vfio_main.c
> > +++ b/drivers/vfio/vfio_main.c
> > @@ -1543,6 +1543,8 @@ int vfio_pin_pages(struct vfio_device *device,
> > dma_addr_t iova,
> > 
> >  		if (iova > ULONG_MAX)
> >  			return -EINVAL;
> > +		if (!device->ops->dma_unmap)
> > +			return -EINVAL;
> >  		/*
> >  		 * VFIO ignores the sub page offset, npages is from the start
> > of
> >  		 * a PAGE_SIZE chunk of IOVA. The caller is expected to
> > recover
> > @@ -1580,6 +1582,8 @@ void vfio_unpin_pages(struct vfio_device *device,
> > dma_addr_t iova, int npage)
> >  	if (device->iommufd_access) {
> >  		if (WARN_ON(iova > ULONG_MAX))
> >  			return;
> > +		if (!device->ops->dma_unmap)
> > +			return;
> 
> IMHO this restriction applies to both iommufd and legacy container.

Yeah that makes sense

Jason