Date:   Thu, 9 Feb 2023 14:35:30 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     "Sverdlin, Alexander" <alexander.sverdlin@siemens.com>
Cc:     "wei.fang@nxp.com" <wei.fang@nxp.com>,
        "xiaoning.wang@nxp.com" <xiaoning.wang@nxp.com>,
        "shenwei.wang@nxp.com" <shenwei.wang@nxp.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-imx@nxp.com" <linux-imx@nxp.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: fec: Defer probe if other FEC has deferred MDIO
Message-ID: <Y+T2oku3ocAuafe0@lunn.ch>
References: <20230208101821.871269-1-alexander.sverdlin@siemens.com>
 <Y+REjDdjHkv4g45o@lunn.ch>
 <9a520aac82f90b222c72c3a7e08fdbdb68d2d2f6.camel@siemens.com>
 <DB9PR04MB81063375BAC5F0B9CBBB6A0D88D99@DB9PR04MB8106.eurprd04.prod.outlook.com>
 <60f22dab4c51ee7e1a62d91c64e55205c18b9265.camel@siemens.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <60f22dab4c51ee7e1a62d91c64e55205c18b9265.camel@siemens.com>
Precedence: bulk

> You are right, there is unfortunately no i.MX8 support in the upstream
> tree, so it's not possible to reproduce anything.

commit 947240ebcc635ab063f17ba027352c3a474d2438
Author: Fugang Duan <fugang.duan@nxp.com>
Date:   Wed Jul 28 19:51:59 2021 +0800

    net: fec: add imx8mq and imx8qm new versions support
    
    The ENET of imx8mq and imx8qm are basically the same as imx6sx,
    but they have new features support based on imx6sx, like:
    - imx8mq: supports IEEE 802.3az EEE standard.
    - imx8qm: supports RGMII mode delayed clock.

Are you using some other imx8 SoC?

> Just wanted to discuss the probe concept of this driver, which is
> rather fragile with all there static local variables, probe call
> counters and relying on the probe order. All of this falls together
> like a house of cards if something gets deferred.

I agree with the comments about it being fragile. It would be good to
get all the naming from OF nodes/addresses. But it needs doing by
somebody with access to a test farm of lots of different boards with
IMX2/5, IMX6 through to 8 and Vybrid.

    Andrew