Date:   Thu, 9 Feb 2023 15:10:22 +0100
From:   Benjamin Tissoires <benjamin.tissoires@redhat.com>
To:     Walt Holman <waltholman09@gmail.com>
Cc:     linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add support for Logitech G923 Xbox Edition steering
 wheel in hid-logitech-hidpp. We get the same level of features as the
 regular G920.
Message-ID: <20230209141022.oql7n52igjybh3km@mail.corp.redhat.com>
References: <20230207195051.16373-1-waltholman09@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230207195051.16373-1-waltholman09@gmail.com>
Precedence: bulk

Hi Walt, we are almost there. I have applied the following to your patch
(and will push upstream as soon as the CI says it's fine):

* subject must start with the subsystem: "HID: " in our case
* in your commit description, you should add a blanck line between the
  title of the commit and the description. Otherwise, git-format-patch
  considers everything to be the title, which is a little bit long :)
* the Signed-of-by line should be added in the commit description, so
  right here, before the first '---' so that it gets included in the
  commit itself
* for future submissions, please try to keep them numbered. Here, it
  should have been '[PATCH v2] HID: ...' and below the first '---' add
  what changed between v1 and v2.

Again, I have fixed everything, so no need to send another version :)

Cheers,
Benjamin

On Feb 07 2023, Walt Holman wrote:
> ---
>  drivers/hid/hid-ids.h            | 1 +
>  drivers/hid/hid-logitech-hidpp.c | 3 +++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index 0f8c11842a3a..de1f385b0ecc 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -819,6 +819,7 @@
>  #define USB_DEVICE_ID_LOGITECH_G510_USB_AUDIO	0xc22e
>  #define USB_DEVICE_ID_LOGITECH_G29_WHEEL	0xc24f
>  #define USB_DEVICE_ID_LOGITECH_G920_WHEEL	0xc262
> +#define USB_DEVICE_ID_LOGITECH_G923_XBOX_WHEEL	0xc26e
>  #define USB_DEVICE_ID_LOGITECH_WINGMAN_F3D	0xc283
>  #define USB_DEVICE_ID_LOGITECH_FORCE3D_PRO	0xc286
>  #define USB_DEVICE_ID_LOGITECH_FLIGHT_SYSTEM_G940	0xc287
> diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
> index abf2c95e4d0b..4dc833c8a44c 100644
> --- a/drivers/hid/hid-logitech-hidpp.c
> +++ b/drivers/hid/hid-logitech-hidpp.c
> @@ -4347,6 +4347,9 @@ static const struct hid_device_id hidpp_devices[] = {
>  	{ /* Logitech G920 Wheel over USB */
>  	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_G920_WHEEL),
>  		.driver_data = HIDPP_QUIRK_CLASS_G920 | HIDPP_QUIRK_FORCE_OUTPUT_REPORTS},
> +	{ /* Logitech G923 Wheel (Xbox version) over USB */
> +	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_G923_XBOX_WHEEL),
> +		.driver_data = HIDPP_QUIRK_CLASS_G920 | HIDPP_QUIRK_FORCE_OUTPUT_REPORTS },
>  	{ /* Logitech G Pro Gaming Mouse over USB */
>  	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC088) },
>  
> -- 
> 2.37.2
> 
> --signed-of-by: Walt Holman (waltholman09@gmail.com)
>