Date:   Thu, 9 Feb 2023 15:20:10 +0100
From:   Oliver Graute <oliver.graute@kococonnector.com>
To:     Michael Walle <michael@walle.cc>
Cc:     andrew@lunn.ch, davem@davemloft.net, edumazet@google.com,
        hkallweit1@gmail.com, kuba@kernel.org,
        linux-kernel@vger.kernel.org, linux@armlinux.org.uk,
        netdev@vger.kernel.org, pabeni@redhat.com,
        simon.horman@corigine.com
Subject: Re: [PATCH RFC] linux: net: phy: realtek: changing LED behaviour for
 RTL8211F
Message-ID: <20230209142009.GB1550@optiplex>
Mail-Followup-To: Michael Walle <michael@walle.cc>, andrew@lunn.ch,
        davem@davemloft.net, edumazet@google.com, hkallweit1@gmail.com,
        kuba@kernel.org, linux-kernel@vger.kernel.org,
        linux@armlinux.org.uk, netdev@vger.kernel.org, pabeni@redhat.com,
        simon.horman@corigine.com
References: <20230209123917.GA1550@optiplex>
 <20230209133002.180178-1-michael@walle.cc>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230209133002.180178-1-michael@walle.cc>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3K/C4gIvfyJGoV9prmpGfPM+87FMlrznABcCVMLAS5fnxEQSpfMbDC8/dvvN?=
 =?us-ascii?Q?oBRFwICCifrwWKr2SdsyMN2mScnTkslkG9na8LkmdZH1VBEz2PTVuUw1VZUS?=
 =?us-ascii?Q?kPgpdCmrzgwLhHDnYsw+CjNBlCUD6d7TRP5QMUImmQcq3sloQY1g5AWAi95W?=
 =?us-ascii?Q?qdhrGvgxQ1zihdrtfVLZoUeOrCtjTmnepUaaxS+Vp2nDGjmwW7UeFAchkddB?=
 =?us-ascii?Q?rmbU2BZAsG/WSc7QS1y2i7gV8kF+oQ+4V6lxwkyqnKwgP1OQflFq/DT/VXEW?=
 =?us-ascii?Q?Kj/7ZXGZ7JwDZLqh+SU/cPzQmJi65qSD6j0NIL+IbYPjcBw2N/Si7xl0ofmQ?=
 =?us-ascii?Q?KhK+CmHIMxtdEe8maeBKgi7h6eXl8TJBUEN0s+t1sGWseUeDf+7GOJjfnJGV?=
 =?us-ascii?Q?QyTaCqKsHS0ONRpticWZlLbywykCKHTM3K/7jWBrZv8zTzAekjfHexOF4htn?=
 =?us-ascii?Q?iCUw6VHp2hjNJKV2wKpLMpnwT5lzWlNZEKd0QFw8MuDprJ0P5XfgEBA8z/Ui?=
 =?us-ascii?Q?rq2Y5qXSIMTAyQmSP6b/DEH4J5y/LjK29pyP/w5Scu59/ZNmgaBA4jKdrg5V?=
 =?us-ascii?Q?Ye76sGpgUOgN1UtSaBFCVmWESQPUdqYP5guz/GYPPHPrw3hmRyb4e1gqxc41?=
 =?us-ascii?Q?26YnFRhLNuiYR9f92kIHS666uCtLKyXuD1lqe0qFeJ3N6GA7SKaKGNUV1SW4?=
 =?us-ascii?Q?fgctBf/0FLrFbG1Jw0jdsDVnyOZL82F5sS4nuqj5UBb33QGudvb3tQva5Ryc?=
 =?us-ascii?Q?oY/yR9CAE4mi5Z+9wQ7DzF7FnZ+b3Q5jShAc/k3WBUv86aAWXsWlrzEapnbb?=
 =?us-ascii?Q?tGBOc9PfeeMZIm+nmcz850VILLZimtutA0aG0LVKF1TYcHZcDLP9KlSRr/An?=
 =?us-ascii?Q?ASX8T0nC9jrqDXTMn3UQcg32bIKtz0oW1JLiYoKEXSp3M9AdS+mcH2EGIaJZ?=
 =?us-ascii?Q?RkBOFBfnMRkyeZiLEeA1JfXrDJkYWSseNsVSG+iW88gDP+piEfyFEoL7gW4R?=
 =?us-ascii?Q?GyUqzbzNvYBll0UNMxOiJI6RZxj+pjv4KQjpHydLdrTe+e9q9AaOt8H8StAD?=
 =?us-ascii?Q?hg755ZPKNthkt+EcefHTUQLsuZZ7VDvmCOWaK8gc6XoFrTU8hi3fDxK1htl1?=
 =?us-ascii?Q?90/mFudXgHmyiefrPcAcs3+GYjist615uRUFd0Q+q2xNmxJXGBYuMWL1yAv6?=
 =?us-ascii?Q?qmmFqMSbkSiH+/cGOuiACRbD1klo3GwZBxJnxSEEHRVzwY6SO5MIbxAXXEJg?=
 =?us-ascii?Q?VOzKhovMQ1WoXex1Cgi2u9MEB/2Hldd/UFHDbswdIZ0gx+67K3vnpZ7KyvM7?=
 =?us-ascii?Q?WXYGEV19Ku/Z2Qg3VVXVFyhHOVRuj9xYDnXx416cRrm3GSvY7C69bJ16JODV?=
 =?us-ascii?Q?jZsGiSHWiHwPRGUiaHM2/ypibTn0BEYh6qkS+Dar7IP3uQddnAGfCd0xn4VF?=
 =?us-ascii?Q?2YsJx2tnsCuAIt5sf/VAFh+hQ7l2agmucf5mhEqmB3XKYzkLktpReTBgCaZH?=
 =?us-ascii?Q?yo7ck9sD94DWO0C0SKLH4QgQocZbJ9Hcr1MY5q4zOE2pqL5XcGCAut5Zc70u?=
 =?us-ascii?Q?GTnGMGbv6EujFC9cHp+AcNVHxsZWRS7m7XINpEubq/Nw2YTouIYfkelM2OzM?=
 =?us-ascii?Q?z5OTWoZB+G+Jg9hEK4iViS0=3D?=
X-OriginatorOrg: kococonnector.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dc0996ea-64fd-40c7-a22b-08db0aa8c5fd
X-MS-Exchange-CrossTenant-AuthSource: AM9PR09MB4884.eurprd09.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 14:20:19.7761
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 59845429-0644-4099-bd7e-17fba65a2f2b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PyavM0x0DsLk8W1KJwvCdF6m7PVI3Fc6PHbaY8sCjY8/hw5MXczn9g4Aj4C1z5bN6a1upI4W6acSuBN4Qe580iAsdoVE62n1YHU0MywV2R0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR09MB5242
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 09/02/23, Michael Walle wrote:
> > is this the right place to turn on the realtek phy LEDs for RTL8211F?
> 
> Probably not. There are a few issues. This will only work one particular
> board. Therefore, you'd need some kind of runtime configuration to also
> support other boards. But lately any LED related patches for PHYs were
> NAK'd because they need to integrate with the LED subsystem. See [1].
> 
> -michael
> 
> [1] https://lore.kernel.org/r/YyxOTKJ8OTxXgWcA@lunn.ch/

ok thx for this information.

Best Regards,

Oliver