MIME-Version: 1.0
References: <20230209125330.1433481-1-colin.i.king@gmail.com>
In-Reply-To: <20230209125330.1433481-1-colin.i.king@gmail.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Thu, 9 Feb 2023 09:35:41 -0500
Message-ID: <CADnq5_Pju2QxoR2QEhWf_p9EcKnuF+SkqaKJ7i7adxBktJBBAw@mail.gmail.com>
Subject: Re: [PATCH][next] drm/amd/display: Fix spelling mistakes of function
 name in error message
To:     Colin Ian King <colin.i.king@gmail.com>
Cc:     Harry Wentland <harry.wentland@amd.com>,
        Leo Li <sunpeng.li@amd.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>,
        Xinhui.Pan@amd.com, David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Applied.  Thanks!

Alex

On Thu, Feb 9, 2023 at 7:53 AM Colin Ian King <colin.i.king@gmail.com> wrote:
>
> The function name is being reported as dc_link_contruct when it is
> actually dc_link_construct_phy. Fix this by using %s and the __func__
> for the function name.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>  drivers/gpu/drm/amd/display/dc/link/link_factory.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/link/link_factory.c b/drivers/gpu/drm/amd/display/dc/link/link_factory.c
> index 13a766273755..3fc93fc593fb 100644
> --- a/drivers/gpu/drm/amd/display/dc/link/link_factory.c
> +++ b/drivers/gpu/drm/amd/display/dc/link/link_factory.c
> @@ -452,7 +452,7 @@ static bool dc_link_construct_phy(struct dc_link *link,
>         link->psr_settings.psr_vtotal_control_support = false;
>         link->psr_settings.psr_version = DC_PSR_VERSION_UNSUPPORTED;
>
> -       DC_LOG_DC("BIOS object table - dc_link_contruct finished successfully.\n");
> +       DC_LOG_DC("BIOS object table - %s finished successfully.\n", __func__);
>         return true;
>  device_tag_fail:
>         link->link_enc->funcs->destroy(&link->link_enc);
> @@ -469,7 +469,7 @@ static bool dc_link_construct_phy(struct dc_link *link,
>                 link->hpd_gpio = NULL;
>         }
>
> -       DC_LOG_DC("BIOS object table - dc_link_contruct failed.\n");
> +       DC_LOG_DC("BIOS object table - %s failed.\n", __func__);
>         return false;
>  }
>
> --
> 2.30.2
>