Date:   Thu, 9 Feb 2023 09:46:38 -0600
From:   Nishanth Menon <nm@ti.com>
To:     Devarsh Thakkar <devarsht@ti.com>
CC:     <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <robh+dt@kernel.org>,
        <kristo@kernel.org>, <vigneshr@ti.com>, <hnagalla@ti.com>,
        <praneeth@ti.com>, <a-bhatia1@ti.com>, <j-luthra@ti.com>
Subject: Re: [PATCH] arm64: dts: ti: k3-am62a7-sk: Enable full 4GB DDR
Message-ID: <20230209154638.zktj5hxthapwbicj@accompany>
References: <20230206115240.6026-1-devarsht@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230206115240.6026-1-devarsht@ti.com>
User-Agent: NeoMutt/20171215
Precedence: bulk

On 17:22-20230206, Devarsh Thakkar wrote:
> AM62A7-SK board has 4GB LPDDR4 Micron MT53E2G32D4DE-046 AUT:B memory but
> only 2GB was enabled early.
> 
> Enable full 4GB memory by updating the latter 2GB memory region
> which gets mapped to 0x0880000000 i.e. DDR16SS0_SDRAM as referred in
> Table 2-1. AM62A Common SoC Memory of AM62Ax TRM.
> 
> TRM : https://www.ti.com/lit/zip/spruj16

TRM makes no sense in this patch - it is the data sheet of the memory and part in
schematics that is relevant

Looking at the design files (link from dts): https://www.ti.com/lit/zip/sprr459
E1 version of the board has MT53E2G32D4DE-046 Vs E2 version of the board
is MT53E1G32D2FW-046

The 2GB is accurate for E1 version of the board, 4GB change implies that
E1 version of the board is no longer supported.

Is the claim that E1 version of the board no longer supported? What
happens to folks in the community who have an E1 board?

> 
> Logs:
> Link : https://gist.github.com/devarsht/e85b6af89c01ddadb3a62f3e5f196af8

Logs dont belong to the commit message. Also missing (if the patch is
claiming a "fixes") is a Fixes tag.
> 
> Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
> ---
>  arch/arm64/boot/dts/ti/k3-am62a7-sk.dts | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> index 5c9012141ee2..f6a67f072dca 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> @@ -27,8 +27,9 @@
>  
>  	memory@80000000 {
>  		device_type = "memory";
> -		/* 2G RAM */
> -		reg = <0x00000000 0x80000000 0x00000000 0x80000000>;
> +		/* 4G RAM */
> +		reg = <0x00000000 0x80000000 0x00000000 0x80000000>,
> +		      <0x00000008 0x80000000 0x00000000 0x80000000>;
>  	};
>  
>  	reserved-memory {
> -- 
> 2.17.1
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D