From:   Zi Yan <ziy@nvidia.com>
To:     Yajun Deng <yajun.deng@linux.dev>
Cc:     akpm@linux-foundation.org, mgorman@techsingularity.net,
        david@redhat.com, vbabka@suse.cz, rppt@linux.ibm.com,
        osalvador@suse.de, rppt@kernel.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm/page_alloc: optimize find_suitable_fallback() and
 fallbacks array
Date:   Thu, 09 Feb 2023 10:50:48 -0500
Message-ID: <4C196D76-49A9-4B06-A51F-D8A13109DF3B@nvidia.com>
In-Reply-To: <20230209101144.496144-1-yajun.deng@linux.dev>
References: <20230209101144.496144-1-yajun.deng@linux.dev>
Content-Type: multipart/signed;
 boundary="=_MailMate_471C45A4-9EC4-47CF-BDA9-3C0ED117E94A_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fXTrsRZYhmMKzDufEMYclInrktGzGUhoNIanF/l42FPWYYzLSdhfD9FMgSfI?=
 =?us-ascii?Q?wfGMUKyUpGEevaTbZFy9vB9l0VJy4ulP3c8IZXW5Lv5qGeteWe2uGJWU1a34?=
 =?us-ascii?Q?U+f2jGZyXoEvN+rGIRVP/YmlQGBuvsUrLh08EGdlK0RAqnJkgNexukFTt1HF?=
 =?us-ascii?Q?HJRABJ6W6JDoYfNjwh3Ot/+Vo63uugkDcRBpWWkMBmmQDKJLyhsaGRkU083O?=
 =?us-ascii?Q?keFerqSRPXofaE8nqUbp62JqxIn2/AG91WplwukgKxYD3EDomNlsCdEOtAjJ?=
 =?us-ascii?Q?LfObSxRgHm8YsO3qjozOBZLFHEuHrgXo2DZvL1uMDBDSk4xf0W849pj9YLvR?=
 =?us-ascii?Q?0L5002thT6CkyyAJ6sb2/Kvf5To+IETis52wtFK+2iOKZdAUsRysAg7gCLkA?=
 =?us-ascii?Q?Zyfjw+mwYODc8vtdyxZwYJY8emQV5eAWD20MSLc2+EKqveVoHbFx+9N8AhX+?=
 =?us-ascii?Q?f2YegeiKI0jXmHH38nouVJDx9YHnbEOjlmei8wjJCVi04Gap1gn+nPijUqGe?=
 =?us-ascii?Q?erdblmdW2yrVC4XnCTQOuyYErilg0Xhdngv7A7ibxpmzEVsuA4apjLXU9vE0?=
 =?us-ascii?Q?z4rRnevMIVbfdB+FOrjBsLIAnhoLLrxOb76AyfShZy2QdYrFlht36gbstOR0?=
 =?us-ascii?Q?fc6yNLS/YAqGt+8q2W/vk85a4YiGWInje6VXiRsNOjqq5Gyxs2kqUJAb23eU?=
 =?us-ascii?Q?F74K6wfuJ7PFH3G4jTQ1G+d0nIm3/r2b1l9dzcn/kzga8BiElt5DzOyWO7Md?=
 =?us-ascii?Q?3YeEa8Qf5o+eXZ7XmT94ipzJfIPu2Fxr9nL5S3/ejJ5m/R9hw3bviznMNxJw?=
 =?us-ascii?Q?WKvvt2QxmMR3LGWdxei4NnvX/gwQCh6Zh/ZFpXf/rx8ke+bvLoyfa052AWA2?=
 =?us-ascii?Q?JehKSam95uy914d2hcdAFhO5Iq+/lhdQj9rjcUnBlr+BgAFDuyu/QyEtdhTB?=
 =?us-ascii?Q?do9UxGJ/upE6RoIGghwiFNyr7QqKAbeKiHOGHupKnvG1xEwBzxpXpkTfRc2F?=
 =?us-ascii?Q?SRdSE/JP4vRvhW8+D9l8ULOP7XTVLs9xVnQ1mKieLn7IqMRNbBqYKT1vMzW5?=
 =?us-ascii?Q?g6s1Ri3x4dTfBa4eMuozTiEA8OxZ/CCjZ6TzuOb+XOOjNGJwqPmGYINXkTYF?=
 =?us-ascii?Q?fgaKoPzggsIEJpfPpUN2uRw0AKeW8Kn+6N+nLdgDtLIb05wCIwzj+xo2fGgo?=
 =?us-ascii?Q?PmIyp7eTCio3+6sACyVyCwdgfPyFHOKXel0DTxcvXbiEl2MzCQKJDMwRN41z?=
 =?us-ascii?Q?Wb7yRB3gFJ01MIPkrhDD9WfYUeMxeLJCxbBnifsQeprySoxYbGLYgmZ+NKoa?=
 =?us-ascii?Q?ie3wlntn6N5rNykl9Njq4bVorsUCheuHfUjmg2hOv3XpbKS+zKJWAUlf+wXw?=
 =?us-ascii?Q?UrFYtejT5hbvMlgP0QVfwN2xf3j6XTS28Be3ju9LoWd3jWOpJLiPOlg8XSmc?=
 =?us-ascii?Q?RAsqa8XZEpU1AuxcU0RNz7tZFGfA5bnwemUWQPLt0zYbi19ihfe9FXchqNJO?=
 =?us-ascii?Q?pBXXJMQfM4R/jA0ebZVTlykg1jl9I9yJcii0PMg2HkPU4yeq0bRztl/YpUS9?=
 =?us-ascii?Q?xy+HywH57R7aLqNffbdRIhLh10D4X3k+MqAhoU7o?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b72bcc4b-40fc-4e22-3210-08db0ab56d3e
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 15:50:54.3707
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: frlBQaiY2w8FPdSFGr8vAyne6pBNVPMG+B9kzwp6gddHCeQaOtGP1qMlCv/LJM0y
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4187
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--=_MailMate_471C45A4-9EC4-47CF-BDA9-3C0ED117E94A_=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On 9 Feb 2023, at 5:11, Yajun Deng wrote:

> There is no need to execute the next loop if it not return in the first=

> loop. So add a break at the end of the loop.

Can you explain why? If it is the case, MIGRATE_UNMOVABLE cannot fall bac=
k
to MIGRATE_MOVABLE? And MIGRATE_MOVABLE cannot fall back to MIGRATE_UNMOV=
ABLE?
And MIGRATE_RECLAIMABLE cannot fall back to MIGRATE_MOVABLE?

>
> At the same time, add !migratetype_is_mergeable() before the loop and
> reduce the first index size from MIGRATE_TYPES to MIGRATE_PCPTYPES in
> fallbacks array.

You sent a patch: https://lore.kernel.org/all/20230203100132.1627787-1-ya=
jun.deng@linux.dev/T/#u, why not squash this one into that? Why do
we need two separate small patches working on the same code?

Thanks.
>
> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
> Acked-by: Vlastimil Babka <vbabka@suse.cz>
> ---
>  include/linux/mmzone.h |  2 +-
>  mm/page_alloc.c        | 11 +++++------
>  2 files changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index ab94985ee7d9..0a817b8c7fb2 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -85,7 +85,7 @@ static inline bool is_migrate_movable(int mt)
>   * Check whether a migratetype can be merged with another migratetype.=

>   *
>   * It is only mergeable when it can fall back to other migratetypes fo=
r
> - * allocation. See fallbacks[MIGRATE_TYPES][3] in page_alloc.c.
> + * allocation. See fallbacks[][] array in page_alloc.c.
>   */
>  static inline bool migratetype_is_mergeable(int mt)
>  {
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 1113483fa6c5..536e8d838fb5 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -2603,7 +2603,7 @@ struct page *__rmqueue_smallest(struct zone *zone=
, unsigned int order,
>   *
>   * The other migratetypes do not have fallbacks.
>   */
> -static int fallbacks[MIGRATE_TYPES][MIGRATE_PCPTYPES - 1] =3D {
> +static int fallbacks[MIGRATE_PCPTYPES][MIGRATE_PCPTYPES - 1] =3D {
>  	[MIGRATE_UNMOVABLE]   =3D { MIGRATE_RECLAIMABLE, MIGRATE_MOVABLE   },=

>  	[MIGRATE_MOVABLE]     =3D { MIGRATE_RECLAIMABLE, MIGRATE_UNMOVABLE },=

>  	[MIGRATE_RECLAIMABLE] =3D { MIGRATE_UNMOVABLE,   MIGRATE_MOVABLE   },=

> @@ -2861,7 +2861,7 @@ int find_suitable_fallback(struct free_area *area=
, unsigned int order,
>  	int i;
>  	int fallback_mt;
>
> -	if (area->nr_free =3D=3D 0)
> +	if (area->nr_free =3D=3D 0 || !migratetype_is_mergeable(migratetype))=

>  		return -1;
>
>  	*can_steal =3D false;
> @@ -2873,11 +2873,10 @@ int find_suitable_fallback(struct free_area *ar=
ea, unsigned int order,
>  		if (can_steal_fallback(order, migratetype))
>  			*can_steal =3D true;
>
> -		if (!only_stealable)
> -			return fallback_mt;
> -
> -		if (*can_steal)
> +		if (!only_stealable || *can_steal)
>  			return fallback_mt;
> +		else
> +			break;
>  	}
>
>  	return -1;
> -- =

> 2.25.1

--
Best Regards,
Yan, Zi

--=_MailMate_471C45A4-9EC4-47CF-BDA9-3C0ED117E94A_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmPlFlgPHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhUGpoP/01J4MmTPXSU5BrbKW6Rv/wZo1pPBMsV1Mke
P6NWz4qVVtr9V82fw+XYIeWJaY3AooXU7N59qTQzZjYcari265Eg7iZCf8QtZI3j
33j+Bf/cqKxcvV5I/cxmIiUE35b4Y+62ndM/KwrqaZ+0NDuDfhTIdPrnvZrC8/wS
3jMciKdivVc1JRvLOU+Lc251ekv67wNgdJR4Jz9tfUearb32H2xewdt6flW1HBuf
Zfo5pUhFloAfVa7PIR/uvqgyXsi+Ug/WWSDX/oL3inFV5gEFwNHWDZb66ytmACwc
OVGVe6G5ZCZM8MWvpl+ykPg3aMWmtSAJakvZE3SiR0Zd57IqCLqrzMLhJ2ED6tSf
nTvLaNjUsLsGUVR7KMo1UmXteLgG52ZNCimiVKIyvR8+CK29fsAJujBGHUL+WvGc
unSw+VysN5gLSzxlq18SMcn25jguvrAaGyFgIcvPrfAup0Cemp5ywLZRqmKa/YHN
+NuXLI2Mh9+GWGLT82c5i/PVshTglHhgcwU+w/3VT+m0Be67F/0536AN5URxmoQs
Ccv8iOsncD8a3gisoHwAQN/mTBobOO6MkxuMlkZvoLBTmwDGK7bFdiqQXgVIqQ6Y
bMmVzIGT0um6Iq+vQr9tuvsF+EERvT1XPXTQRHbLYdgyRd2fwSkYVyPy/sFCNL18
KdcGFglm
=rmFP
-----END PGP SIGNATURE-----

--=_MailMate_471C45A4-9EC4-47CF-BDA9-3C0ED117E94A_=--