Date:   Thu, 9 Feb 2023 09:04:29 -0800
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     Vladimir Oltean <vladimir.oltean@nxp.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com, Arnd Bergmann <arnd@arndb.de>,
        Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Richard Cochran <richardcochran@gmail.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: dsa: ocelot: add PTP dependency for
 NET_DSA_MSCC_OCELOT_EXT
Message-ID: <Y+UnnbziFW097BD9@colin-ia-desktop>
References: <20230209124435.1317781-1-arnd@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230209124435.1317781-1-arnd@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+wV6BXp2O6ct3/MjRpu2NWFzoU+CuGLoJprimwNWLdw+uU1nkl2RiO1RGmhj?=
 =?us-ascii?Q?3+ipAWohxUfWytgOuKHSobA7K8UKz++y5moZiLyXbHIPWUkUmBn3dBfyA5jb?=
 =?us-ascii?Q?xP3/6Rzzecftu8DxhVzWW1xzlLZ3jC2Kgo7daCRq9uFCsu4L7jl/3PL40xo8?=
 =?us-ascii?Q?hHSd97xYg10fj/GsDRniH/ECrjlaMdOSzcX74smw5ENFwdQPCuhI96zCmfA4?=
 =?us-ascii?Q?64xzpGOU3TPK5RP84B66LRADeNC9sql0Uv6NbW+O+yqX3cztUkAR/k5Un2Ep?=
 =?us-ascii?Q?oZgg+zCmgLLzSunj2f+ecki/aMNilOZWW+WC8WLXkZvjpqtARdI21JtwhpTY?=
 =?us-ascii?Q?nLc9zErBn0H3gZxA2C9/y3FBy+oF9bEJqkn7W7JmhZqHWQjDkMzxvSrVIbkf?=
 =?us-ascii?Q?AVTRhI5wCke+dOoNYEtkbyU+CaYqQiEfVAr9zHFJIUYSRm8oHoreqnXqzjzT?=
 =?us-ascii?Q?DTJmzSP1Qapn0WSVOKHpl/1ZNyHmQaBLsPWeL+Wa/PdesVCZLDp9Aslp6hA0?=
 =?us-ascii?Q?M42jObkHlpRHt9J52xMNArtoAfKH1XfjU65DGJRNc4LqweV/YHZBCPYZ8Pjc?=
 =?us-ascii?Q?YASmikHrvTtEVHIgvTohS16wNfInqitu5kKQeX+EBs57FqyIhXKEC4iz1iyU?=
 =?us-ascii?Q?wjeLRHKkyc+XANQt8NE9k+xt5jJYMwgma3VqVECazIPzRGLu9R/+Aoy0azIp?=
 =?us-ascii?Q?LzagCSSr1ZKQrfmwOEkZi7/95R0/ACsRus0nqJmw52Ex1SYzUfbw/SdkYJM+?=
 =?us-ascii?Q?BDAsq68EzDxOLDhukCzdsL/qYIP6g2MT/HTbE5MDECaudHqa+1QPw9wFtgr5?=
 =?us-ascii?Q?DjhnvkQWty6eM+4rygu3PM8xQ2wS1jHYSr8F1bPTv92Ula8k75zcsCppDr0O?=
 =?us-ascii?Q?pQ/9ypOAYAtWw6WpjQ5dnbOkTmpIo3XWXQ8J3FDfV+6t9t1uyzKx4X9QYXZR?=
 =?us-ascii?Q?p9EB++Oq5KPIQ4uHU3Mm56dOhyyDGY0PoU81m7ubR0b8FbsY7J+a0Xeftye0?=
 =?us-ascii?Q?rLzxggKizYUIOR9z5Q8l1e4o0L6mto2yGSa3AsWy7m497lq8r+0SsDxoUTDq?=
 =?us-ascii?Q?q4LyNXPLm76eYXpvB3uNvu3RcE82hRDUebZGl5qZ9srk8XY7aGbHpFoaWNBx?=
 =?us-ascii?Q?OXWCrkeuGeQf7EEduXNoPBLPCzPf+x7l94fQXwfz1hOmRuAy688mBuhyBVuD?=
 =?us-ascii?Q?b5i5PxRWrhKGI3xg/kV9d50kxs/aaS8gJwziR6iIOx2Qb4AqSnE1Nwxjv2Eh?=
 =?us-ascii?Q?+wMpS+lbiIidp/Mb3iVo4AGccG5aWpNbdJAMxPRL04uE5fwLB2gNkB0GJPrz?=
 =?us-ascii?Q?6bddsNDLsoceFx17s19puvZkSGMazNENW1S3uAnamH1znY7F3nKVjHBCddDf?=
 =?us-ascii?Q?67TbLL2VxTtP6h19O7f8SUup3/5mRb9h7brfJig3lPFQmp1sZfeOreTxarzS?=
 =?us-ascii?Q?LfUJKqCXWcZPqv5VrpAs+vQGtqDy5zAbpmo/7/EnAoH+QPo8iSHIRbVnw06l?=
 =?us-ascii?Q?HRNOzWNkYtdiop0lWbGWVRWk/Mx80PU3xSDhXhDW2ZFFdL+0HVYs/hcu1xC+?=
 =?us-ascii?Q?JvNPA4Ul+SaelgsuUerPDi11NrUadAtlhxXZUo+NiVCmcNASRahCexKaij3u?=
 =?us-ascii?Q?W9z6kX0yzQIysyngX7Kzcvc=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c09ff716-5e63-4883-11f8-08db0abfb7fe
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 17:04:34.8875
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +iSRphbA+Kruv+NXiUfT5TRREqkzdH3RX44Hc5p08olEcbJMG9JImV8pYSc1n4H0RxiexncMhkSSCHBGM5CvOUF0yyVyXUbOlKA84jHFWYQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5046
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Arnd,

On Thu, Feb 09, 2023 at 01:44:17PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> A new user of MSCC_OCELOT_SWITCH_LIB was added, bringing back an old
> link failure that was fixed with e5f31552674e ("ethernet: fix
> PTP_1588_CLOCK dependencies"):
> 
> x86_64-linux-ld: drivers/net/ethernet/mscc/ocelot_ptp.o: in function `ocelot_ptp_enable':
> ocelot_ptp.c:(.text+0x8ee): undefined reference to `ptp_find_pin'
> x86_64-linux-ld: drivers/net/ethernet/mscc/ocelot_ptp.o: in function `ocelot_get_ts_info':
> ocelot_ptp.c:(.text+0xd5d): undefined reference to `ptp_clock_index'
> x86_64-linux-ld: drivers/net/ethernet/mscc/ocelot_ptp.o: in function `ocelot_init_timestamp':
> ocelot_ptp.c:(.text+0x15ca): undefined reference to `ptp_clock_register'
> x86_64-linux-ld: drivers/net/ethernet/mscc/ocelot_ptp.o: in function `ocelot_deinit_timestamp':
> ocelot_ptp.c:(.text+0x16b7): undefined reference to `ptp_clock_unregister'
> 
> Add the same PTP dependency here, as well as in the MSCC_OCELOT_SWITCH_LIB
> symbol itself to make it more obvious what is going on when the next
> driver selects it.
> 
> Fixes: 3d7316ac81ac ("net: dsa: ocelot: add external ocelot switch control")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---

I think this'll have to go through net-next, because ocelot-ext hasn't
been merged yet... unless there's something I don't fully understand
(which is very likely)

Thanks for finding / fixing! I'll run a quick verification when I have
access to hardware. Probably won't be for a couple days though.

Acked-by: Colin Foster <colin.foster@in-advantage.com>