Date:   Thu, 9 Feb 2023 09:07:18 -0800
From:   Dan Williams <dan.j.williams@intel.com>
To:     Robert Richter <rrichter@amd.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        "Ira Weiny" <ira.weiny@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        "Dan Williams" <dan.j.williams@intel.com>
CC:     Jonathan Cameron <jonathan.cameron@huawei.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Robert Richter <rrichter@amd.com>, <linux-cxl@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] cxl/port: Disable decoder setup for endpoints in RCD mode
Message-ID: <63e52846175ae_36c729428@dwillia2-xfh.jf.intel.com.notmuch>
References: <20230208071758.658652-1-rrichter@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230208071758.658652-1-rrichter@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?n3OgCecefNgO3XAPInmXjE3zxA9cpUowhOfuLJAfTkUvQRWyY1PGLNuYhrGa?=
 =?us-ascii?Q?pLf+ZIIRzeK9mNAZ9pF92V3WYfKMRzpeXsqWmesk3BCzcZQCdQfDgEXJFwIk?=
 =?us-ascii?Q?QSwG8CHRzKIkYd1AFezZsRedN+A4fYDnYcsZKx1oQkgJ3SJmtAGA+Gp9c8eL?=
 =?us-ascii?Q?6Oj/hUrwtuEBz2ShNF/kElVfWpD2fno0fRdW0wmecMCJi14he8DdybWxOvFC?=
 =?us-ascii?Q?bUAr4J+tEqPE7HlWwPgQMS8W3WxixraUyEExHJAjeOZYyX/LD1V5gY3olbv9?=
 =?us-ascii?Q?r4AshpW7MFDwPcf9YzfLcMfUdygJPAjocQJ0CocFS/uc9E29+hpFAiFBHvb3?=
 =?us-ascii?Q?2zl3a5/aNL4TM0+lhfCgRhho9sVY25amujZM/5UbNuMS7GxhTSFGUawTHMur?=
 =?us-ascii?Q?38JLezt7M0QRXKcL04rMhntKq1oe5NO+/i6UWoi4B1bwhlLjxCUl00ZWe9ep?=
 =?us-ascii?Q?NSnNo+/8tL3YP6JRrU6woAOHXX5waDIp5gZ32GmKcYrzTQncSog8nIGicL1y?=
 =?us-ascii?Q?vcstATS5+uNEOKue+XwXFrD7X/2faSpw+2OHMUIXO3/uERRoF1RhnVq6QC9j?=
 =?us-ascii?Q?KMKMN541vEi5Qe9O67Rn7tWJuIQYbXS73s5dr4Dlgw0PKYgS0CdTEFtPoTg2?=
 =?us-ascii?Q?E8k7Lh+kNua9HSVw8MvlFa8/nPBABMWVxD3HO+2OO8EEmlmzBo/LD6sg//Wc?=
 =?us-ascii?Q?Gc7gkFf1pgasfxlmYhhniE2WpbgCL45X2tfSuLrI2tgim9TK78Vemov44Nub?=
 =?us-ascii?Q?2HKxvd+1X1eUCn7RHYpE+Gp8ZiDlcydMdO2//35buhedFauXVPzE8bn4mEts?=
 =?us-ascii?Q?FhLqQysuPE3CFUgT39ZyvNPykOO6sfFLmRUQXbK7sCLONMU3J0qA4ty9rkZ0?=
 =?us-ascii?Q?v/e9I+nHaQ1Ne8e/GFQ/EtJKiFAYF1/txadC004nnzAzY+mRzzhfIIIpBzXX?=
 =?us-ascii?Q?hUbvgoxGO+5OkkaeYt/S+46v6LbSMBGWyTFGMEvm7wiw9ZQpM36ekfsWZcvO?=
 =?us-ascii?Q?DufdC4d9xDx8xvvoXn9fTD9epOm8MTAWr+LwqewUmS1WsZrZ+Uxr2h3NlWjA?=
 =?us-ascii?Q?X2RaLjQQXoKdkUCv19HrDHJtqpU6Naxg1XP/2SU2eSXShWgvZoCL5NdRziak?=
 =?us-ascii?Q?UXQq1cQbur3wJTRmWl9I8X6DGWJsKmidRbNObIiqlfeiEZAvrVsZqR41bkgq?=
 =?us-ascii?Q?WJivZbRwlDhToeQPGlh50ppFz5mnswg0b+lr/ErVXr0ObGfjyYv0UT9hpk6I?=
 =?us-ascii?Q?jC6PPtReGdr/eVtAWO3ZWmw1Dpdo8Nlz74ALfOVw5HQ/V7+HU4weNdiY9zen?=
 =?us-ascii?Q?3L97shA6Xuo7MGMWDQe2SDUyQJ0mQBiiaead6WGjrb9w2Ik3Qe+W273VDKGJ?=
 =?us-ascii?Q?Wv9YS+h/rXQSu4yASiAutKM0oLM0/OIAKFdZ9rZVxFqArHsvrYZG18yKn7XB?=
 =?us-ascii?Q?sbMuYudhkuc+8oCq5Clv+rkdcCCi012nWcQr6IiyuMK+g5wA8TDrKubE7sVK?=
 =?us-ascii?Q?u/opHBRL/EygMJc9Fvwc9YyFZfiSvH5D8sDm2c8ETeNjHPEUTnBe36jVRvPI?=
 =?us-ascii?Q?tiA6L4Dhe9DtAvV9GmD3+o4zh+6M+FH50dTMzR7MpHYVsESXlih6NmYii/c3?=
 =?us-ascii?Q?Kw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f32fc2e4-ef58-4d4a-3650-08db0ac01aba
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 17:07:20.3498
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MNR22jGg2NPzpVwUmx6oUNrB4IyaDDem/o0hZqOwpMkHNLSCWdXAuLD/UH61gIfcVdSlIK/WGQGrOCXxoSExsuP3dtgL6dawkh4a/5z/E18=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5053
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Robert Richter wrote:
> In RCD mode the HDM decoder capability is optional for endpoints and
> may not exist. The HDM range registers are used instead. Since the
> driver relies on the existence of an HDM decoder capability, its
> absence will cause the initialization of a memory card to fail.
> 
> Moreover, the driver also tries to enable or reuse enabled memory
> ranges. In the worst case this may lead to a system hang due to
> disabling system memory that was previously provided and setup by
> system firmware.
> 
> To solve the issues described, disable decoder setup for RCD endpoints
> and instead rely exclusively on system firmware to enable those memory
> ranges. Decoders are used by the kernel to setup and configure CXL
> memory regions, esp. to enable and disable them. Since Hot-plug is not
> supported for devices in RCD mode, the ability to disable that memory
> by the kernel using a decoder is not a necessarily requirement,
> decoders are not needed then.
> 
> Fixes: 34e37b4c432c ("cxl/port: Enable HDM Capability after validating DVSEC Ranges")
> Signed-off-by: Robert Richter <rrichter@amd.com>

Does Dave's series address this problem?

https://lore.kernel.org/linux-cxl/167588394236.1155956.8466475582138210344.stgit@djiang5-mobl3.local/

...that is arranging for the driver to carry-on in the absence of the
HDM Decoder Capability.