Sender: Guenter Roeck <groeck7@gmail.com>
Date:   Thu, 9 Feb 2023 09:37:59 -0800
From:   Guenter Roeck <linux@roeck-us.net>
To:     ye.xingchen@zte.com.cn
Cc:     nick.hawkins@hpe.com, verdun@hpe.com, jdelvare@suse.com,
        linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: =?iso-8859-1?Q?gxp-fan-?=
 =?iso-8859-1?Q?ctrl=3A_use=A0devm=5Fplatform=5Fget=5Fand=5Fioremap=5Freso?=
 =?iso-8859-1?B?dXJjZSgp?=
Message-ID: <20230209173759.GA652733@roeck-us.net>
References: <202302081546067270324@zte.com.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202302081546067270324@zte.com.cn>
Precedence: bulk

On Wed, Feb 08, 2023 at 03:46:06PM +0800, ye.xingchen@zte.com.cn wrote:
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
> 
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>

Applied to hwmon-next.

Thanks,
Guenter

> ---
>  drivers/hwmon/gxp-fan-ctrl.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/hwmon/gxp-fan-ctrl.c b/drivers/hwmon/gxp-fan-ctrl.c
> index 0e9225a8b805..0014b8b0fd41 100644
> --- a/drivers/hwmon/gxp-fan-ctrl.c
> +++ b/drivers/hwmon/gxp-fan-ctrl.c
> @@ -199,7 +199,6 @@ static const struct hwmon_chip_info gxp_fan_ctrl_chip_info = {
>  static int gxp_fan_ctrl_probe(struct platform_device *pdev)
>  {
>  	struct gxp_fan_ctrl_drvdata *drvdata;
> -	struct resource *res;
>  	struct device *dev = &pdev->dev;
>  	struct device *hwmon_dev;
> 
> @@ -208,8 +207,7 @@ static int gxp_fan_ctrl_probe(struct platform_device *pdev)
>  	if (!drvdata)
>  		return -ENOMEM;
> 
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	drvdata->base = devm_ioremap_resource(&pdev->dev, res);
> +	drvdata->base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
>  	if (IS_ERR(drvdata->base))
>  		return dev_err_probe(dev, PTR_ERR(drvdata->base),
>  				     "failed to map base\n");