MIME-Version: 1.0
References: <CAMxBKG1RwbRJMG0cKcnbyKgznXeZLL+Zp1zXeOnxpYU0NkOO8A@mail.gmail.com>
 <CAMxBKG3o_6R7M0gaUHXA5yGgSe6HBWYK25fwF=8mN+JTno9t7Q@mail.gmail.com>
 <CAMxBKG0wDi-XwMZwMHq_DbFXt3pgK-CV-G7iT9BNftiXBoUHzQ@mail.gmail.com>
 <20230209153600.jtj6deqhgfocvwgc@houat> <cefe5482-f30f-e5cc-8722-1f60d610f059@redhat.com>
In-Reply-To: <cefe5482-f30f-e5cc-8722-1f60d610f059@redhat.com>
From:   Darrell Kavanagh <darrell.kavanagh@gmail.com>
Date:   Thu, 9 Feb 2023 17:59:15 +0000
Message-ID: <CAMxBKG2sFu_e4rQ_-ZyJN5+C6YDLMhSoCYgDpaFpBddHZjwwEw@mail.gmail.com>
Subject: Re: drm: panel-orientation-quirks: Add quirk for Lenovo IdeaPad Duet
 3 10IGL5
To:     Hans de Goede <hdegoede@redhat.com>
Cc:     Maxime Ripard <maxime@cerno.tech>,
        maarten.lankhorst@linux.intel.com, tzimmermann@suse.de,
        airlied@gmail.com, daniel@ffwll.ch,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

It certainly is a learning process! Let me try to get things together
properly myself, will be useful in the long run.

Darrell

On Thu, 9 Feb 2023 at 15:53, Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi,
>
> On 2/9/23 16:36, Maxime Ripard wrote:
> > Hi,
> >
> > On Wed, Feb 08, 2023 at 07:04:58PM +0000, Darrell Kavanagh wrote:
> >> I've resolved this by adding a matching quirk in
> >> drivers/firmware/efi/sysfb_efi.c - see below.
>
> Right, this is a known issue on Lenovo 2-in-1s with
> the panel mounted 90 degree rotated issue. For some reason
> the efifb info still gives a landscape resolution even though
> the actual resolution really is portrait. This also messes
> up the pitch of the framebuffer leading to the weird corrupted
> looking output you saw.
>
> >> I've resolved this by adding a matching quirk in
> >> drivers/firmware/efi/sysfb_efi.c - see below.
> >>
> >> Are you the right people to be notifying about this?
> >
> > Yes, we are.
> >
> > Howewer, please follow
> > https://www.kernel.org/doc/html/latest/process/submitting-patches.html
> >
> > In particular, a proper commit log and your Signed-off-By tag is missing.
>
> Are we, do patches to that file go through drm-misc ?  :
>
> [hans@shalem linux]$ scripts/get_maintainer.pl -f drivers/firmware/efi/sysfb_efi.c
> Ard Biesheuvel <ardb@kernel.org> (maintainer:EXTENSIBLE FIRMWARE INTERFACE (EFI))
> linux-efi@vger.kernel.org (open list:EXTENSIBLE FIRMWARE INTERFACE (EFI))
> linux-kernel@vger.kernel.org (open list)
>
> Either way this should be turned into a proper patch with a proper
> Signed-off-By message as Maxime mentioned.
>
> My offer for the drm_panel_orientation_quirks.c patch to turn it into
> a proper patch for you also extends to this one. If you want that,
> please let me know and again add your Signed-off-by as a standalone
> separate line in your reply so that I can use it for the commit message.
>
> Regards,
>
> Hans
>
>