Date:   Thu, 9 Feb 2023 19:10:46 +0100
From:   Stanislaw Gruszka <stf_xl@wp.pl>
To:     Deepak R Varma <drv@mailo.com>
Cc:     Helmut Schaa <helmut.schaa@googlemail.com>,
        Kalle Valo <kvalo@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Saurabh Singh Sengar <ssengar@microsoft.com>,
        Praveen Kumar <kumarpraveen@linux.microsoft.com>
Subject: Re: [PATCH] wifi: rt2x00: remove impossible test condition
Message-ID: <20230209181046.GA1446693@wp.pl>
References: <Y+S3bu19GWZeR9pm@ubun2204.myguest.virtualbox.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y+S3bu19GWZeR9pm@ubun2204.myguest.virtualbox.org>
Precedence: bulk

On Thu, Feb 09, 2023 at 02:35:50PM +0530, Deepak R Varma wrote:
> Variable vga_gain is a u8 and will never attain a value less than 0.
> Hence testing it for less 0 is impossible.
> Issue identified using unsigned_lesser_than_zero.cocci Coccinelle
> semantic patch. The issue was also reported by Kernel test Robot.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Deepak R Varma <drv@mailo.com>
Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>