Message-ID: <e309f543-5307-65a9-e5c9-c2a82a17eb89@amd.com>
Date:   Thu, 9 Feb 2023 12:14:12 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH] uml: vector: fix definitios of VECTOR_WRITE and
 VECTOR_HEADERS
Content-Language: en-US
To:     Anton Ivanov <anton.ivanov@cambridgegreys.com>, richard@nod.at,
        johannes@sipsolutions.net
Cc:     linux-um@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20230209161916.3729757-1-carlos.bilbao@amd.com>
 <874b2d0c-3500-5c1e-07cd-74f9e91d92d6@cambridgegreys.com>
From:   Carlos Bilbao <carlos.bilbao@amd.com>
In-Reply-To: <874b2d0c-3500-5c1e-07cd-74f9e91d92d6@cambridgegreys.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cE1ZN3FUbHM2QXJhdERXenNEbExLcnhWMC9jYXdLdWZRdG5VNHZ4NDkzMGw1?=
 =?utf-8?B?Y1l4dmoxcWthaERQblRZNnNaZThiOU1jV3BIUWsyU0tGdzJVRUV0WGUreU0w?=
 =?utf-8?B?OTgrQXVNejN0bGFZTER2VDJNNkRJSi9EZ2wzRjd5eUlGNkxPY3E1VVpYVTBk?=
 =?utf-8?B?WTdMbEZMN1NCUHJrM3NaQktoeTNFOVpYSlpHMjYvRG5FU0V2NXVvS3ZuWTFN?=
 =?utf-8?B?WVNhRVpnYVJjNExuMTM3SDhRbVdqaHM5U0dLTnBJNUZybER6djYvTjJYWURo?=
 =?utf-8?B?c0hpb1VGN3ZRbTd4TlFVSDcxQTE3aXdNVUh0MDFPRlBGVU1hUWNJSmdGTkdM?=
 =?utf-8?B?ZGtSTGRxUmZsdkN0aUJKajR1cm9KVE0xdkZYa1lnajd5Q1hqVjdKMFdvdU1j?=
 =?utf-8?B?R2hiTDAzbGZDaTBxRXBPRXFNVmtrQTIzUVAyYURWSEVra1JlTTNGeG9BL3lt?=
 =?utf-8?B?b0hMREhIYXhDek5JRmtLdk41eTllN3loN0xldmlxUis4S2ZTbTFBWkF5Q1Fp?=
 =?utf-8?B?UjJnSTZxaENtSGpLSEhUYzJCY3l2L3daM2hyc3l6YlN4YitMUU9PaERhL2tp?=
 =?utf-8?B?QUhYVWtRM3pWbW5UNmMvLzdkdC9jTE9wa3EvV2FWdjIxVmV0Q3Fzd1RFNzFw?=
 =?utf-8?B?VVBWUG5Ic2xkc0JES2F0ZUxnUzd6bGFGaHNRUFV5SHRRWmpHb3BWQkVESW9s?=
 =?utf-8?B?Uko5TUNQaVh4ekZrbGpvNVN0Q1F2Q3pFZ0x2SVFaWVZHODcwNkh5OFBOMnRB?=
 =?utf-8?B?M0NkanlRZ3ZjY001ZDZrWTAxLzRWRDR6VDZscngxU0dJNkhyRkE5Q0J2MXFm?=
 =?utf-8?B?RFRYRDlLaDdGNHpLa0FVZU9Yb3BEWnlpQzh1SzZJdUtCQWtjbVNLRUI4NDJU?=
 =?utf-8?B?Z2NNVW80L2dXcjlwZExCUWhpNitYSCs1bzVseTBSNmtGNXNpaitLbG00K1Br?=
 =?utf-8?B?UWxzdFFMdms0eFNnc0dSU1hVdVVaM3hqd0dwckpqb3dJYy90SGZZck1NK01W?=
 =?utf-8?B?RlVxNjBxQzdzd2FYaHZycTZMSnduZDZnRU5kaENNb0dESHZ4cXF6d2lVQWxV?=
 =?utf-8?B?UzRNaU94MFZRd3VRVnR6UkpBVTdoZUxxbzJOc1ZZZE0yTnVtd1ZMcERNQktM?=
 =?utf-8?B?dDhJYmt2TW5Rc1QrUFBiVmVyc3gza25LWGo1bWM5NGs2aGM3S3JLaXY5dTBT?=
 =?utf-8?B?Yi9GU2FabnZBZHlGc1VMV2J4cUtUSElqRDBKNnlSY2ZyeTdqbUVPcWcyeDlB?=
 =?utf-8?B?T1lUOHpLUDgra3FNZVBvQ3RGQitXeVZ1eHpXeDhEN0owNjdFbjM4RTlNUk9D?=
 =?utf-8?B?MVFXMmpvakZUc2NpOFQ3SzZtL0hDWmcya2ZmZE1sRk5RVnVERlZ5SytpS29p?=
 =?utf-8?B?bzFjRGx2dnBTRTZad1ZPRVFQRWlyMnM1OURzZ20wL1hqUEZhQTdReGhLZGVa?=
 =?utf-8?B?YXlJM1pwUytZUlNuWjMwZW9VNEU3WXN4VDBNNXovRGVzOHRFMitoeVVhZ0gr?=
 =?utf-8?B?Q0dOVjVEWHlQN0Ric3hSTHFaMGkra0RmU3Q3MDNOejl6V29Pb3VXdGhTQzN1?=
 =?utf-8?B?YnVYR2NRdnU0YVhjdFpVMFduMVNHK0xwMGZ6QXNaRUs3UlhnSVlsQVFESGtw?=
 =?utf-8?B?Mk5WbnlwKzlqQWZ0b0hxUnE1aC82Yk1id2w4d0lhM3M4d1JYSDBLaFJ3cUdQ?=
 =?utf-8?B?RlQ2RHgrTHpnS25nWjV5YnZnMlhCeXlHNmZZNkdET01aMHJaMFEwQnpJSG42?=
 =?utf-8?B?ZERsVytuNUZiazhaSEdTVXVEY1NvNHIyT1g3VnI2SU1iTURFTWtkQkNONVNx?=
 =?utf-8?B?NllodU9HZzJaR2h4T096WkxrVDloQU9HYXZac0dCZDNIcERXTnlJMDcxY0JW?=
 =?utf-8?B?U3JOaWQvNGNwbTA1L1ZYdlorWXdkRE42R3Fpdk5rK1NTYnEydlMwdXZEMUdP?=
 =?utf-8?B?clB3ckJ4SFV2U2NaemdqcllDNDNXRFZqd2ZmV1owOHlUeVNrQTgzek1HczVh?=
 =?utf-8?B?ZlBPVFFkUVZMQi9HaXhrYkNtMWFicEp5eTFFbHB6ZjF3bzJWSGM4UEJ2bnFM?=
 =?utf-8?B?M0J4SjJkbkw4ZWNLVldkQ0RSc3Y3Y3pzQUo5SjhzMzU4ZGc5Q0hKaWR6TTVU?=
 =?utf-8?Q?jkcqOPFaMcvEjPd4UAWu5Or5r?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8c80126b-d255-4775-08e5-08db0ac97392
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5874.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 18:14:14.8430
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DtGdjTJcK0PIlrXY9PHo06Ug3ROpYFjSkRJmmsgoiW14GwFVfc3JfWUpzbZlhGkiktp9GeDe8oEytMg+T19nsQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6400
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2/9/23 11:33, Anton Ivanov wrote:

> On 09/02/2023 16:19, Carlos Bilbao wrote:
>> Fix definitions of VECTOR_WRITE and VECTOR_HEADERS with proper bitwise
>> operand for bit shift.
>>
>> Signed-off-by: Carlos Bilbao <carlos.bilbao@amd.com>
>> ---
>>   arch/um/drivers/vector_user.h | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/um/drivers/vector_user.h 
>> b/arch/um/drivers/vector_user.h
>> index 3a73d17a0161..f7d3956f5c15 100644
>> --- a/arch/um/drivers/vector_user.h
>> +++ b/arch/um/drivers/vector_user.h
>> @@ -68,8 +68,8 @@ struct vector_fds {
>>   };
>>     #define VECTOR_READ    1
>> -#define VECTOR_WRITE    (1 < 1)
>> -#define VECTOR_HEADERS    (1 < 2)
>> +#define VECTOR_WRITE    (1 << 1)
>> +#define VECTOR_HEADERS    (1 << 2)
>>     extern struct arglist *uml_parse_vector_ifspec(char *arg);
>
> These are no longer used. They were used in some very early versions 
> of the code.
>
> They should just be removed instead of redefined correctly.
>
Ack, sending patch your way.

Thanks,

Carlos