MIME-Version: 1.0
References: <20230207-kobj_type-cpufreq-v1-1-c7fa2dbd0754@weissschuh.net> <20230208050411.2byi4nfsfiyakfyq@vireshk-i7>
In-Reply-To: <20230208050411.2byi4nfsfiyakfyq@vireshk-i7>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Thu, 9 Feb 2023 20:30:45 +0100
Message-ID: <CAJZ5v0h3E7x-0FkLG0fDv0qi-8W+GCS6gmpJtvxPWTVLTWH_KQ@mail.gmail.com>
Subject: Re: [PATCH] cpufreq: Make kobj_type structure constant
To:     Viresh Kumar <viresh.kumar@linaro.org>,
        =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Wed, Feb 8, 2023 at 6:04 AM Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> On 07-02-23, 19:58, Thomas Weißschuh wrote:
> > Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
> > the driver core allows the usage of const struct kobj_type.
> >
> > Take advantage of this to constify the structure definition to prevent
> > modification at runtime.
> >
> > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> > ---
> >  drivers/cpufreq/cpufreq.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> > index 7e56a42750ea..ceb1574417f9 100644
> > --- a/drivers/cpufreq/cpufreq.c
> > +++ b/drivers/cpufreq/cpufreq.c
> > @@ -993,7 +993,7 @@ static const struct sysfs_ops sysfs_ops = {
> >       .store  = store,
> >  };
> >
> > -static struct kobj_type ktype_cpufreq = {
> > +static const struct kobj_type ktype_cpufreq = {
> >       .sysfs_ops      = &sysfs_ops,
> >       .default_groups = cpufreq_groups,
> >       .release        = cpufreq_sysfs_release,
> >
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Applied as 6.3 material, thanks!