MIME-Version: 1.0
References: <20230206193319.4107220-1-arnd@kernel.org> <Y+IkjuCr9UuY5ZDg@orome>
In-Reply-To: <Y+IkjuCr9UuY5ZDg@orome>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Thu, 9 Feb 2023 20:52:02 +0100
Message-ID: <CAJZ5v0iTumTZcvi3p0cBU5V=0N3e9GQ6b+Nkgxfk-W4C_wp2qw@mail.gmail.com>
Subject: Re: [PATCH] [v2] cpuidle: add ARCH_SUSPEND_POSSIBLE dependencies
To:     Thierry Reding <treding@nvidia.com>,
        Arnd Bergmann <arnd@kernel.org>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Dmitry Osipenko <digetx@gmail.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Randy Dunlap <rdunlap@infradead.org>, stable@vger.kernel.org,
        Anup Patel <anup@brainfault.org>,
        Sudeep Holla <sudeep.holla@arm.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Michael Walle <michael@walle.cc>,
        Bjorn Andersson <andersson@kernel.org>,
        Lina Iyer <ilina@codeaurora.org>,
        Stephan Gerhold <stephan@gerhold.net>,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Feb 7, 2023 at 11:14 AM Thierry Reding <treding@nvidia.com> wrote:
>
> On Mon, Feb 06, 2023 at 08:33:06PM +0100, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > Some ARMv4 processors don't support suspend, which leads
> > to a build failure with the tegra and qualcomm cpuidle driver:
> >
> > WARNING: unmet direct dependencies detected for ARM_CPU_SUSPEND
> >   Depends on [n]: ARCH_SUSPEND_POSSIBLE [=n]
> >   Selected by [y]:
> >   - ARM_TEGRA_CPUIDLE [=y] && CPU_IDLE [=y] && (ARM [=y] || ARM64) && (ARCH_TEGRA [=n] || COMPILE_TEST [=y]) && !ARM64 && MMU [=y]
> >
> > arch/arm/kernel/sleep.o: in function `__cpu_suspend':
> > (.text+0x68): undefined reference to `cpu_sa110_suspend_size'
> > (.text+0x68): undefined reference to `cpu_fa526_suspend_size'
> >
> > Add an explicit dependency to make randconfig builds avoid
> > this combination.
> >
> > Fixes: faae6c9f2e68 ("cpuidle: tegra: Enable compile testing")
> > Fixes: a871be6b8eee ("cpuidle: Convert Qualcomm SPM driver to a generic CPUidle driver")
> > Link: https://lore.kernel.org/all/20211013160125.772873-1-arnd@kernel.org/
> > Cc: Randy Dunlap <rdunlap@infradead.org>
> > Cc: stable@vger.kernel.org
> > Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> > I found this in my backlog of patches that never made it upstream,
> > testing shows this is still needed. Please apply.
> > ---
> >  drivers/cpuidle/Kconfig.arm | 2 ++
> >  1 file changed, 2 insertions(+)
>
> Acked-by: Thierry Reding <treding@nvidia.com>

Applied as 6.3 material, thanks!