Message-ID: <6db57eb4-02c2-9443-b9eb-21c499142c98@intel.com>
Date:   Thu, 9 Feb 2023 21:04:31 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH bpf] bpf, test_run: fix &xdp_frame misplacement for
 LIVE_FRAMES
To:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>
CC:     =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= <toke@redhat.com>,
        "Martin KaFai Lau" <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>,
        "Jesper Dangaard Brouer" <hawk@kernel.org>,
        Jakub Kicinski <kuba@kernel.org>, <bpf@vger.kernel.org>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230209172827.874728-1-alexandr.lobakin@intel.com>
Content-Language: en-US
From:   Alexander Lobakin <alexandr.lobakin@intel.com>
In-Reply-To: <20230209172827.874728-1-alexandr.lobakin@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Rk4zYm92QjRZTnZDUEhSbnJvdGZUdWVhM0xiS0tXYWptVFFnbG1DWTRMTVAv?=
 =?utf-8?B?di8wZG5EUjFGdUExTHV6eFh0MjVBMVVpT1JwU3c1Q3pwZHJFQWNzTEdCc3Z4?=
 =?utf-8?B?c2FscWovUlhlWlBGOVFLZFdWYmJjZ0ZzNGkzTmdQbytTRVdhMWFHZ3NIazBC?=
 =?utf-8?B?RHpJQk5Uc1RDQW5DZ2xIM1FwKyszcEFLWnI3cEhSUTFNdWJIMzRqeFBnM3J4?=
 =?utf-8?B?SmFDMmxEZ0psQ3J6N2p3N1Z4dGZPRVY5M0p6cXFzZ3VEZjBVMGFhZDRBUTZq?=
 =?utf-8?B?SmFEd2VUNlNLNTlJdUljMmk5K2NkcXNDT2xKSVd0N1hHSWdWTmJMeG1zSGsr?=
 =?utf-8?B?dzNDUjJaM1hJUkplVXR4TlZibEIvQ2FYV052TkpKQ2JXT1FWaVNNd2EzZEE0?=
 =?utf-8?B?eEFKclBib0MzTWIvd3RQLzMyWno0UzB1Qk5FTG9VbVhudFZkc0IxNktzaWNi?=
 =?utf-8?B?UGo1SHNUU09ncW9zdE1JN3I2SmZEN0hXZEZQK1hDbytHVm1rcVcrWXNVckxh?=
 =?utf-8?B?TWdxVG9EMlFZZm51Nmp2bGZEdFo0eUhQcmJsK1Ftdng4Qnp2VzQrQXY2M2Ex?=
 =?utf-8?B?QVpubzE4czJScTQwRElsUjhNT3Nna3VSRUpYM0MrSW5ObVR1Wm80Ym0wTFox?=
 =?utf-8?B?M093VEVYaEFJcEJRRy9CMmhYMzZzRjZqb1FudVhqVzJicFJ0WUhGRWRzNTB0?=
 =?utf-8?B?NlZmQ1JNK1QyMWJxbVRGSFBUc2NyODZrdzFsUDJ2SE5QMlVqcWRNMzNyUzFX?=
 =?utf-8?B?MkZYRytkNDlpazdsL0dMYmlNUjVsWW40WktFbFd0akViZU9zSkNIWWtxU1N0?=
 =?utf-8?B?T0V6MVZUNzFzVm91dnJKYlhlcWdLRjE5NlJISkUwWGg1NTVuTTVZQkFENDUx?=
 =?utf-8?B?bjZZM3BsbThDbTJKb29wRmRTR1NnMytMbEpGSVI5RVVsczdZRW5oY1lWckN5?=
 =?utf-8?B?S0lMcE01THJFKzh2eEZpMS9DMm5TamxRTi8rVCtTWFlSMStVUGJ1Qm02Q0tt?=
 =?utf-8?B?MXYvR3lSZWNubm03Yk1yMEpoUWhaK3pYVlVVU0V6QTQ2bkRnd2tCUVJXbE4y?=
 =?utf-8?B?RkovR0M2RHFNWW5SRG9CTlBuYU9WaW94a3ZRaVdYZEVaT2htaG9iUk9FQnh6?=
 =?utf-8?B?RGcvUzFkcW1neGhjOGFjQ1V1SWRxcmg5cXpkNXZOWnVjNlhUbFdOVmgxM1dV?=
 =?utf-8?B?RFFERXYzbzFUV2VVemxrZ3RBQ3BwWTJHQkZJUTVrVXdvQzFOYXFCY3JLT1N0?=
 =?utf-8?B?aGI4WDRGRmd3clhMejZNSUdEY0VTTnFLY3JwYUthVk15VzJOTS95M0p4ck1H?=
 =?utf-8?B?SUdNTk1oVVJRcEFpRzU5N0dZRVBKYkc1bTRhTUV1emZsQXdKQVhUR2pYaDlp?=
 =?utf-8?B?a0VKRk42NEJyZW9NNjFXVUx0ZzZWZ3ZnM2xZRGZObitHYWZheEJYMk1TT0xs?=
 =?utf-8?B?K3RLbmFteVFlUEEwbDVzc3BlTklvM2c2M1hLTlVvUmcyV1ZqT2tCd0thTmZu?=
 =?utf-8?B?RUt6WHdrWUhBMHk1SVM2MlBxV2VBYU5icllrTzJOdXBnc1ZtUWVwQjlaODNN?=
 =?utf-8?B?ZjlPU3JRNVoxSk1ON0xFSWZ0TmxOamhuRXVpWTF1REhRQXlvK3I2WkRUVzM4?=
 =?utf-8?B?d2pSeXY3SnU1aWJnRnY0ZXZYdWYvQ0FUTGxQWFFJbE02RVF1ZytwaDI0ckt5?=
 =?utf-8?B?RHBpRVMrbkZtM0NsUUsrQk5taFV5UEQvUHdDcGJkUEhvZWQ3MVFKQVNqR2lN?=
 =?utf-8?B?TUUwM0VuN3ZrMHhMczZnVlliWmxqWlBzTG5JY3JXNjZXYTVTY0h5ZHhsK0Vj?=
 =?utf-8?B?YzJSMXVKWU1QMDYwOG1SbzEzdzNvRTU1LzJ1T2RNMnJuSGwrcmFTSG4zUVBl?=
 =?utf-8?B?SG9kRDhXb3VtZHFlN2xoelJIY2NiSWM3MU5HRkQ3V3VqeC94YkUxeDJBVGsr?=
 =?utf-8?B?bDVmbHJYUzRLeXN2UTRiWWp6bm9Oa0REc01MUEh3ZkErbklRV1NPTmlrSDdJ?=
 =?utf-8?B?S3I0bFBLQUFIdG9wU1FHRWZ1UjBnQ3NTcUFGMklFK3NmZG1pUkFMNTNpZVNJ?=
 =?utf-8?B?ZkJCZEU5ck5pOWwzL1NRNS92MExnYXZSaSt1R2gyd1ppREZiTjVWOGxXeVU2?=
 =?utf-8?B?ekU3ckJGMW5pZTErWTlRNWFpbnV5aFQ5Z0tSQW00L3pkbkhLc0FJd3FGSCs3?=
 =?utf-8?B?dFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4b8a36f2-ca16-4dc7-12ec-08db0ad8eead
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3624.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 20:05:04.0653
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SBm4s+CdmEXXH9D2leZanGz7Ll4c1H4QyZX55KQSTb4zx56WeVOeVuXrU9zg6jCoay3ZF5jbuQC0++QBWVIkyRZGTs9GcRtHPW0thFyqDo8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5424
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Alexander Lobakin <alexandr.lobakin@intel.com>
Date: Thu, 9 Feb 2023 18:28:27 +0100

> &xdp_buff and &xdp_frame are bound in a way that
> 
> xdp_buff->data_hard_start == xdp_frame

[...]

> diff --git a/net/bpf/test_run.c b/net/bpf/test_run.c
> index 2723623429ac..c3cce7a8d47d 100644
> --- a/net/bpf/test_run.c
> +++ b/net/bpf/test_run.c
> @@ -97,8 +97,11 @@ static bool bpf_test_timer_continue(struct bpf_test_timer *t, int iterations,
>  struct xdp_page_head {
>  	struct xdp_buff orig_ctx;
>  	struct xdp_buff ctx;
> -	struct xdp_frame frm;
> -	u8 data[];
> +	union {
> +		/* ::data_hard_start starts here */
> +		DECLARE_FLEX_ARRAY(struct xdp_frame, frm);
> +		DECLARE_FLEX_ARRAY(u8, data);
> +	};

BTW, xdp_frame here starts at 112 byte offset, i.e. in 16 bytes a
cacheline boundary is hit, so xdp_frame gets sliced into halves: 16
bytes in CL1 + 24 bytes in CL2. Maybe we'd better align this union to
%NET_SKB_PAD / %SMP_CACHE_BYTES / ... to avoid this?

(but in bpf-next probably)

>  };
>  
>  struct xdp_test_data {
Thanks,
Olek