Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F933C6379F for ; Thu, 9 Feb 2023 20:22:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229672AbjBIUWA (ORCPT ); Thu, 9 Feb 2023 15:22:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229450AbjBIUV6 (ORCPT ); Thu, 9 Feb 2023 15:21:58 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7C1B1B556; Thu, 9 Feb 2023 12:21:55 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 332F761B9A; Thu, 9 Feb 2023 20:21:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29B7EC433EF; Thu, 9 Feb 2023 20:21:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675974114; bh=fmneXG5cZ3wbS4vx7jlvnH6iEA2018GLSjQTQXpbqLE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=IhsejxndhowRtYKqJu55G126YmnnFWz55FXBd52d0BQEevggy6/UWVHxXejlYMyg9 YQw1itwHuQElyOpwW2bCAaSTFK9jiLNdJLfEz5o2E76sWU7DgHbqGFZQdo2ERc0lsE mKVaPmWPW914HKBn8+li5lg3VnfQG72iPEnWpyk8Hafy5Kv+maXz5MJ4B6njj9rWlE XgyxkagWtans8mqx4OYwt8xIpXpxXM2bH60kWIu6NwCa2W22XYBRoXu6OWaX0ecy+7 MCrMJ2dKXvjROLJhHWZ1Kj4DqsHXFKK2dHpJtBPjL9FBNvFAQSw31eixbHK/L+jtdR 38eeb1MtJvahw== Date: Thu, 9 Feb 2023 12:21:53 -0800 From: Jakub Kicinski To: Haiyang Zhang Cc: "Michael Kelley (LINUX)" , KY Srinivasan , "wei.liu@kernel.org" , Dexuan Cui , "davem@davemloft.net" , "edumazet@google.com" , "pabeni@redhat.com" , "netdev@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH net-next 1/1] hv_netvsc: Check status in SEND_RNDIS_PKT completion message Message-ID: <20230209122153.2b02faf4@kernel.org> In-Reply-To: References: <1675900204-1953-1-git-send-email-mikelley@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 9 Feb 2023 19:10:16 +0000 Haiyang Zhang wrote: > But I'm just worried about if a VM sending at high speed, and host side is, > for some reason, not able to send them correctly, the log file will become > really big and difficult to download and read. With rate limit, we still see > dozens of messages every 5 seconds or so, and it tells you how many > messages are skipped. And, if the rate is lower, it won't skip anything. > Isn't this info sufficient to debug? > > By the way, guests cannot trust the host -- probably we shouldn't allow the > host to have a way to jam guest's log file? +1 FWIW, the general guidance is to always rate limit prints which may be triggered from the datapath (which I'm guessing this is based on the names of things)