Message-ID: <b7643e5b-520d-0c4c-75ea-0cb65a2dbd42@bytedance.com>
Date:   Thu, 9 Feb 2023 20:37:58 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [External] Re: [PATCH v8 6/9] x86/smpboot: Support parallel
 startup of secondary CPUs
Content-Language: en-US
To:     Thomas Gleixner <tglx@linutronix.de>, dwmw2@infradead.org,
        kim.phillips@amd.com
Cc:     arjan@linux.intel.com, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, hpa@zytor.com, x86@kernel.org,
        pbonzini@redhat.com, paulmck@kernel.org,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        rcu@vger.kernel.org, mimoja@mimoja.de, hewenliang4@huawei.com,
        thomas.lendacky@amd.com, seanjc@google.com, pmenzel@molgen.mpg.de,
        fam.zheng@bytedance.com, punit.agrawal@bytedance.com,
        simon.evans@bytedance.com, liangma@liangbit.com,
        David Woodhouse <dwmw@amazon.co.uk>
References: <20230209154156.266385-1-usama.arif@bytedance.com>
 <20230209154156.266385-7-usama.arif@bytedance.com> <87r0uy1ysm.ffs@tglx>
From:   Usama Arif <usama.arif@bytedance.com>
In-Reply-To: <87r0uy1ysm.ffs@tglx>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 09/02/2023 18:25, Thomas Gleixner wrote:
> On Thu, Feb 09 2023 at 15:41, Usama Arif wrote:
>>   
>> +static bool do_parallel_bringup = true;
> 
> Wants to be __ro_after_init
> 
>> +static int __init no_parallel_bringup(char *str)
>> +{
>> +	do_parallel_bringup = false;
>> +
>> +	return 0;
>> +}
>> +early_param("no_parallel_bringup", no_parallel_bringup);
> 
> Lacks an entry in Documentation/admin/kernel-parameters.txt
> 
> Thanks,
> 
>          tglx


Thanks, I will add the below to next revision. Its quite minor so will 
wait for more comments and MTRR question to be resolved, unless told to 
send next revision with this diff only.

diff --git a/Documentation/admin-guide/kernel-parameters.txt 
b/Documentation/admin-guide/kernel-parameters.txt
index 6cfa6e3996cf..d3696c9316f1 100644
--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt
@@ -3830,6 +3830,9 @@
         noreplace-smp   [X86-32,SMP] Don't replace SMP instructions
                         with UP alternatives

+       no_parallel_bringup
+                       [X86,SMP] Disables parallel brinugp of secondary 
cores.
+
         noresume        [SWSUSP] Disables resume and restores original swap
                         space.

diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index 3ec5182d9698..fecd934e72fb 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -813,7 +813,7 @@ static int __init cpu_init_udelay(char *str)
  }
  early_param("cpu_init_udelay", cpu_init_udelay);

-static bool do_parallel_bringup = true;
+static bool do_parallel_bringup __ro_after_init = true;

  static int __init no_parallel_bringup(char *str)
  {