From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     "Chatre, Reinette" <reinette.chatre@intel.com>,
        "bhelgaas@google.com" <bhelgaas@google.com>,
        "nathan@kernel.org" <nathan@kernel.org>,
        "ndesaulniers@google.com" <ndesaulniers@google.com>,
        "Rix, Tom" <trix@redhat.com>
CC:     "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "llvm@lists.linux.dev" <llvm@lists.linux.dev>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "darwi@linutronix.de" <darwi@linutronix.de>
Subject: RE: [PATCH] PCI: Fix build error when CONFIG_PCI_MSI disabled
Thread-Topic: [PATCH] PCI: Fix build error when CONFIG_PCI_MSI disabled
Thread-Index: AQHZPNBWS3WtUj6eQUmM/aZAFGIoka7Hot8w
Date:   Fri, 10 Feb 2023 05:12:40 +0000
Message-ID: <BN9PR11MB527699243353309A1DDFEFBE8CDE9@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <158e40e1cfcfc58ae30ecb2bbfaf86e5bba7a1ef.1675978686.git.reinette.chatre@intel.com>
In-Reply-To: <158e40e1cfcfc58ae30ecb2bbfaf86e5bba7a1ef.1675978686.git.reinette.chatre@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6mhbn8Tt9WPZBz4ZBRis4W7GJr4zu3QPxDIPemVxk/pUUInpbl9nDWI87Uq6?=
 =?us-ascii?Q?R6r+6aETTHhZJ8MtBVBPMAzO2Rwgrj+/qnlotxFA1PTkvfZCGeXbyeIWB+bv?=
 =?us-ascii?Q?lM7PDFGwkdmQjHwZ0rSQMOrlaFTjiNEFYyBuiSjhlcA5zaPFjM4NQUnex33U?=
 =?us-ascii?Q?kCCc75M79DB3hG9Wu9ZdwAAZJHAdblDIyomIclCgjxOPn99q5vDlkCdQKQxu?=
 =?us-ascii?Q?qKg092gt0u0MrSZ4hVkH3by6ym935ipZRtPIJJXApIHeNkZq4LV9D+1JLT3L?=
 =?us-ascii?Q?C1R/NEVRMZHQYhDxQZ1PcHDLRfGADzxjB7aQBQ7QhRnS0GM+fYZVU21c7Cy0?=
 =?us-ascii?Q?7dEKkxVzLPQLIYus1SjCrmzCSnVfqX7ZMRsi/0Obv6fOF2Oo9fNhdk9wn4y3?=
 =?us-ascii?Q?e70DQ9DM2oDXbkIpV5tXtwvrSxW0+OiH8nB4778uX5tZr/6+MlsrNlv2g3kh?=
 =?us-ascii?Q?HNHUk8iEYaINVGvoXnjhyeoBlbZKDeImFoJHOzKISjE0BXq3CD88TAmcbBq9?=
 =?us-ascii?Q?IG9geq0Dssj0FnHF5bwV8hxxmItcbxi9YAIu4+WIH6PF4C4h1ib+uMIs8H/1?=
 =?us-ascii?Q?iT4B44wN1NXAnvNLptyAIKfAzCJp/BB23TDzZk7jizvk5s0/D8FKdlJ5pFJ9?=
 =?us-ascii?Q?hzpv01koUp8JIrNYxl6U9F13b1+SoBmfolvXo6QxgIyb3o18s3QR+mEvpcUq?=
 =?us-ascii?Q?ArLCh9wW8QfwKX2qA9S/+iPkct5s06FBIqZKG9lLcl9AOudvyOrUh3C0WhoI?=
 =?us-ascii?Q?GHWDwd++hEz7n/UV4B2lFSNQKrlRIofgnejatI6a+ZESxRLjbYezU0QxKMO0?=
 =?us-ascii?Q?kDnzwepDgP0l70mAs42VUZwcFK4+MpopMiSCZcVs4z4bkWMLsh6IBfZXgksy?=
 =?us-ascii?Q?LULl8IahkFb0ioA97UYUo88fKjEevov0MUKe4d7juI0qR4JT9mGPlEaTi55C?=
 =?us-ascii?Q?FBQRTzCnPTeBM8NEHQfw8unWlcZaU1nKji3kCPo5cwUJ+MgbI1aNYcrwY5u1?=
 =?us-ascii?Q?WTIC7RovOvTc7VPXqBUsxB4kEQz0ZmXdg14SIT44DpyZIn/jxhWI0WvS0KcN?=
 =?us-ascii?Q?DXJYAO/Tj3n8wGcVpaSrCsrlZig9+cYaHFzrcVBhtxzMbarbPqcdVP3gF3bd?=
 =?us-ascii?Q?VHRVgId3iuRaHUlJTcgsGCZu11wVPOV40ohTQIMWLcubWjJswxAo267XHsI+?=
 =?us-ascii?Q?HBYgeeWm632oqQAf94WKkwi0Lro4x9TC0tR2bAHjXQgL3VIszaTKpOq5wutG?=
 =?us-ascii?Q?UPYvMLAahej+z6tbQCKT9Foj/FH52aOsRMKaOpAUi4sFJF496Oih/7JPrUWK?=
 =?us-ascii?Q?A5ohCra58Wv8CxIh6XNBATNN6ON+P5fxQR4LuhcJIPbAZ4okhhCXfbr95RVe?=
 =?us-ascii?Q?MhQADo/ExMf0tH7ajp+M1b82NIhl1yBs4sn+rRwMCVJe1P8eewQ9Fjs1EjKp?=
 =?us-ascii?Q?aTl72v7QG5BM0yswqpwkknNT9h4AWpQibU3fm2DT+pP6YFdwDFPt1jnULfUo?=
 =?us-ascii?Q?dvCawCZ8sTLqWB4LT/BcoX1oI0E0FMxMFGNEJtu6yk9j9Wi/bSmq6QPvGcKj?=
 =?us-ascii?Q?SlwixJT4sCv8IExRzFTS5/1WXF5WIj4BuH0MvH9L?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 87fcca31-d12d-4cd8-25b8-08db0b256ee4
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2023 05:12:40.4573
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: QHbkG81STrSJSD42InnPJS/OTm5ILPa/CJTcJo8k+bW8dA4hmMMd2o/f/q7jw+rZemSwO6l4s2hG15RiFWfXBg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6329
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Chatre, Reinette <reinette.chatre@intel.com>
> Sent: Friday, February 10, 2023 5:49 AM
>=20
> pci_msix_alloc_irq_at() and pci_msix_free_irq() are not
> declared when CONFIG_PCI_MSI is disabled.
>=20
> Users of these two calls do not yet exist but when users
> do appear (shown below is an attempt to use the new API
> in vfio-pci) the following errors will be encountered when
> compiling with CONFIG_PCI_MSI disabled:
> drivers/vfio/pci/vfio_pci_intrs.c:461:4: error: implicit declaration of\
>         function 'pci_msix_free_irq' is invalid in C99\
>         [-Werror,-Wimplicit-function-declaration]
>                            pci_msix_free_irq(pdev, msix_map);
>                            ^
>    drivers/vfio/pci/vfio_pci_intrs.c:461:4: note: did you mean
> 'pci_ims_free_irq'?
>    include/linux/pci.h:2516:6: note: 'pci_ims_free_irq' declared here
>    void pci_ims_free_irq(struct pci_dev *pdev, struct msi_map map);
>         ^
> drivers/vfio/pci/vfio_pci_intrs.c:511:15: error: implicit declaration of\
>         function 'pci_msix_alloc_irq_at' is invalid in C99\
>         [-Werror,-Wimplicit-function-declaration]
>                    msix_map =3D pci_msix_alloc_irq_at(pdev, vector, NULL)=
;
>                                       ^
>    drivers/vfio/pci/vfio_pci_intrs.c:511:15: note: did you mean
> 'pci_ims_alloc_irq'?
>    include/linux/pci.h:2514:16: note: 'pci_ims_alloc_irq' declared here
>    struct msi_map pci_ims_alloc_irq(struct pci_dev *pdev,\
>                                     union msi_instance_cookie *icookie,
>=20
> Provide definitions for pci_msix_alloc_irq_at() and pci_msix_free_irq() i=
n
> preparation for users that need to compile when CONFIG_PCI_MSI is
> disabled.
>=20
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>

Reviewed-by: Kevin Tian <kevin.tian@intel.com>