From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     "Liu, Yi L" <yi.l.liu@intel.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "jgg@nvidia.com" <jgg@nvidia.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>
CC:     "cohuck@redhat.com" <cohuck@redhat.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
        "yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
        "peterx@redhat.com" <peterx@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "lulu@redhat.com" <lulu@redhat.com>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
Subject: RE: [PATCH 1/6] iommu: Add new iommu op to get iommu hardware
 information
Thread-Topic: [PATCH 1/6] iommu: Add new iommu op to get iommu hardware
 information
Thread-Index: AQHZPD1VEVujMOhMCUmoab2cFB5/6a7Hyazg
Date:   Fri, 10 Feb 2023 07:28:30 +0000
Message-ID: <BN9PR11MB5276CB88298F97177A7AAF448CDE9@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20230209041642.9346-1-yi.l.liu@intel.com>
 <20230209041642.9346-2-yi.l.liu@intel.com>
In-Reply-To: <20230209041642.9346-2-yi.l.liu@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1HnNMi2isSF0yI/sorMCfpfaAl7yuQr3ZsJTSk1GTMYR7giJGlC+vMHpBOZx?=
 =?us-ascii?Q?k6Lww0qQoyoSZgRmOTSFVdFAlSKEjchs0yovrJUGzXDcwhQImSR7Jdhk/VdL?=
 =?us-ascii?Q?CXfD0hGhuzHB3zoS3Fc4GBSWXE8bp+yYfb48NoxL1jiIfzffTlYIZ1QAo6Dh?=
 =?us-ascii?Q?HOtmidjoggAHJiulK/8UEjql8xnQKYvKTwRk7lFevg+P04o+d/4EHzPxH/KR?=
 =?us-ascii?Q?YXVx9t2o2HxEdDeZKYYU0RLhrDRe2bm3F7Hnb9C0y/cLPcwrcEkEPXngWC8A?=
 =?us-ascii?Q?ZRP/E2iLACEJABARz8Z8gm5Xl5dLRzTRzMVD14i8TbPrnFxrLM5mVEBAp/n8?=
 =?us-ascii?Q?fzaGBDyB4zBekujZm57VfYnbB+kTbl58lABnTdZAQD7YmsgDT26DVLyb1vNH?=
 =?us-ascii?Q?hjlwVUpfSCGzn6hckjQYvv4hZXXX/AI/czH6O44xfmpvkqb8OebFAFeI4oxn?=
 =?us-ascii?Q?NxnoCfcpBqa/IdWbdTpwPKnZnEL7fgN+sNvv0lXsvD+TV0S00cjFUpNcVsH7?=
 =?us-ascii?Q?T9jO6Le5zwvUBMFH0mgE8eEtKeLfmOeTtKspcUmAGxVZ43SoBX4PwfidH9/O?=
 =?us-ascii?Q?RF3k3zhkq0sjYeqs0Yikas2IWMTXiAFvlkxW2oxQcm8aiXdhz24ee2zcFnWa?=
 =?us-ascii?Q?JEI5rr1uM1nngeqHfCP5OSWoBkgSRsSsN7ZbPuG/bZQFiY7gSgWE7U6sM87z?=
 =?us-ascii?Q?F+5CPAmaxUQXZXctfTmgvVD19v+TXkAN32xDAbFRe0c2XgVvR19Ku78/YnAm?=
 =?us-ascii?Q?HQpT0cPNa3ZKECNCYYYaIAIqjrkUhl6r1Lb14ehIXGzsrJp7XxLd6OiVfDf9?=
 =?us-ascii?Q?nnucD3cjmOy91LK1kBDt7atLGivz+RC+gRjKmSjbj1U/kjYdv8poSujHfQ/V?=
 =?us-ascii?Q?hhplkw4n3ubgs0iqO4JkP3nDMU79v9Fbem3BECMaRcoa20ezoU/YUR355gOS?=
 =?us-ascii?Q?SWCaAwretKPSrMmU15xbzcar7COG9LMLwJZaIn7ErE/WyY0IU7Uqo9Ns8AJg?=
 =?us-ascii?Q?6EWzXYx3MwO7oiwwkt0FT5xw1W7iGGgxOT/42bHrCwVEjXwf0cOQVU9UkgJ8?=
 =?us-ascii?Q?RNnQRYNADISZAOp1g1+rR18oXl3CJcu8xwKlKphqBTFJTRxqFUws9LpzqsiC?=
 =?us-ascii?Q?M9fvKB740y+WL9DUHJIXisHDA7bvCjzPsFJyImCLVFx7E7RFXFtKtpgGxaxD?=
 =?us-ascii?Q?+VjPBaN1eG8rX5Xi8wjG0TSaBp49E13g3ZiaZR5Co/BKZWQ5SROEQ/ZTXWGI?=
 =?us-ascii?Q?xRr0gUIf6RrH6Zux+yEjqyAsIG/1n9qKuxd/NnnZxpCLvSAoPa3LNd37jNzh?=
 =?us-ascii?Q?7045QSn7MJ47TF5seqvjga3UrFChgjF7J/DyKf45eGkVpC0HHCWl/2xPF7yS?=
 =?us-ascii?Q?hYKVL7POaA3kVF58C65IL3iyPnbJgN5wBtM8ine5CBMETlG4LdSkx9blX6oS?=
 =?us-ascii?Q?h5th9IWxktZR8+RvSDnHGzqeHmDlx+yz2EqfYuBbmM2q9lFCKx0zJeVGL+1W?=
 =?us-ascii?Q?AuXt4/uwpxHsfgTUhUvkMs4R0tGQeR5/vJsvmFFEfSb5UWOcA7ICG6eq9m9U?=
 =?us-ascii?Q?r6pXEH2GDqLjCeDcZfGAm9Pq+C9UCPjWRbLc/exo?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 362b626b-fa9f-4a5d-f653-08db0b386883
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2023 07:28:30.2453
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: NfqlTVE0PCeMeLG3Exhnxr3iO6TgxsPSafqUON6ydlZqR4MQ3sT0bcAyIBxshNsd/KkdRB3fFYRPmvLdPXN/WQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6109
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Liu, Yi L <yi.l.liu@intel.com>
> Sent: Thursday, February 9, 2023 12:17 PM
> @@ -223,6 +224,11 @@ struct iommu_iotlb_gather {
>  /**
>   * struct iommu_ops - iommu ops and capabilities
>   * @capable: check capability
> + * @hw_info: IOMMU hardware capabilities. The type of the returned data
> is

is it 'info' or 'capability'?

> + *           defined in include/uapi/linux/iommufd.h. The data buffer is
> + *           allocated in the IOMMU driver and the caller should free it
> + *           after use. Return the data buffer if success, or ERR_PTR on
> + *	      failure.
>   * @domain_alloc: allocate iommu domain
>   * @probe_device: Add device to iommu driver handling
>   * @release_device: Remove device from iommu driver handling
> @@ -252,6 +258,7 @@ struct iommu_iotlb_gather {
>   */
>  struct iommu_ops {
>  	bool (*capable)(struct device *dev, enum iommu_cap);
> +	void *(*hw_info)(struct device *dev, u32 *length);
>=20
>  	/* Domain allocation and freeing by the iommu driver */
>  	struct iommu_domain *(*domain_alloc)(unsigned
> iommu_domain_type);
> @@ -280,6 +287,7 @@ struct iommu_ops {
>  	void (*remove_dev_pasid)(struct device *dev, ioasid_t pasid);
>=20
>  	const struct iommu_domain_ops *default_domain_ops;
> +	enum iommu_device_data_type driver_type;

the enum is called 'device_data_type' while the field is called 'driver_typ=
e'.

btw this new field is not documented above.