Message-ID: <c68af237-11b1-aafa-3a0b-132690f825d6@suse.cz>
Date:   Fri, 10 Feb 2023 08:58:28 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH v2] mm/page_alloc: optimize find_suitable_fallback() and
 fallbacks array
To:     Yajun Deng <yajun.deng@linux.dev>, Zi Yan <ziy@nvidia.com>
Cc:     akpm@linux-foundation.org, mgorman@techsingularity.net,
        david@redhat.com, rppt@linux.ibm.com, osalvador@suse.de,
        rppt@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org
References: <626a5f4c4996f57631a8e1877c7646e5@linux.dev>
 <494D9F5D-33A4-48B4-911B-9A75CFC9BC67@nvidia.com>
 <4C196D76-49A9-4B06-A51F-D8A13109DF3B@nvidia.com>
 <20230209101144.496144-1-yajun.deng@linux.dev>
 <ddc2d9001ef9d44651b62869ff9575b6@linux.dev>
 <fa878915627b52d2e6fdf838b96a2f2f@linux.dev>
Content-Language: en-US
From:   Vlastimil Babka <vbabka@suse.cz>
In-Reply-To: <fa878915627b52d2e6fdf838b96a2f2f@linux.dev>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/10/23 03:51, Yajun Deng wrote:
> February 10, 2023 10:33 AM, "Yajun Deng" <yajun.deng@linux.dev> wrote:
> 
>> February 10, 2023 10:14 AM, "Zi Yan" <ziy@nvidia.com> wrote:
>> 
>>> On 9 Feb 2023, at 20:57, Yajun Deng wrote:
>>> 
>>>> February 9, 2023 11:50 PM, "Zi Yan" <ziy@nvidia.com> wrote:
>>> 
>>> On 9 Feb 2023, at 5:11, Yajun Deng wrote:
>>>> There is no need to execute the next loop if it not return in the first
>>>> loop. So add a break at the end of the loop.
>>> 
>>> Can you explain why? If it is the case, MIGRATE_UNMOVABLE cannot fall back
>>> to MIGRATE_MOVABLE? And MIGRATE_MOVABLE cannot fall back to MIGRATE_UNMOVABLE?
>>> And MIGRATE_RECLAIMABLE cannot fall back to MIGRATE_MOVABLE?
>>>> The return in the loop is only related to 'order', 'migratetype' and 'only_stealable'
>>>> variables. Even if it execute the next loop, it can't change the result. So the loop
>>>> can be broken if the first loop can't return.
>>> 
>>> OK. Got it. Would the code below look better?
>>> 
>>> for (i = 0; i < MIGRATE_PCPTYPES - 1 ; i++) {
>>> fallback_mt = fallbacks[migratetype][i];
>>> if (free_area_empty(area, fallback_mt))
>>> continue;
>>> }
>>> 
>>> if (can_steal_fallback(order, migratetype))
>>> *can_steal = true;
>>> 
>>> if (!only_stealable || *can_steal)
>>> return fallback_mt;
>>> 
>>> return -1;
>> 
>> Yes, I'll submit a v3 patch.
>> Thanks.
>> 
> 
> I found a logical error in your code. It should be like this:
> 
>         for (i = 0; i < MIGRATE_PCPTYPES - 1 ; i++) {
>                 fallback_mt = fallbacks[migratetype][i];
>                 if (!free_area_empty(area, fallback_mt))
>                         break;
>         }
> 
>         if (can_steal_fallback(order, migratetype))
>                 *can_steal = true;
> 
>         if (!only_stealable || *can_steal)
>                 return fallback_mt;
> 
>         return -1;
> 
> This code will modify the logic to the opposite.

It's still wrong, IMHO. If all fallbacks have free_area_empty(), it will
return the last one and not -1. Also will set *can_steal in such case.

> So can anyone tell me if I should use this code or the v2 patch?

Once that bugs are fixed, the result will probably not look much better than
v2, so I don't mind keeping v2.