Message-ID: <4a45f084-7d33-59d2-8ef9-cb95e29866a3@nvidia.com>
Date:   Fri, 10 Feb 2023 14:00:55 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH 1/2] ASoC: rt5640: Update MCLK rate in set_sysclk()
To:     Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc:     robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        thierry.reding@gmail.com, jonathanh@nvidia.com,
        oder_chiou@realtek.com, broonie@kernel.org, perex@perex.cz,
        tiwai@suse.com, lgirdwood@gmail.com, devicetree@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
        alsa-devel@alsa-project.org
References: <1675953417-8686-1-git-send-email-spujar@nvidia.com>
 <1675953417-8686-2-git-send-email-spujar@nvidia.com>
 <87lel61k3h.wl-kuninori.morimoto.gx@renesas.com>
Content-Language: en-US
From:   Sameer Pujar <spujar@nvidia.com>
In-Reply-To: <87lel61k3h.wl-kuninori.morimoto.gx@renesas.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NmhpQURUUVd4cHdmelZrUkppYWN6amJLOU1Gd1FZaGc4cVpWanEyVkF1cUE5?=
 =?utf-8?B?YzdZV3o5VG1JTU1yRUdQUnh2UzBzTEMwN1ZIS24yYlk3Z3I3THhrVnFoSDRs?=
 =?utf-8?B?ODBYTHZNa0VuaUFLR0pmU1ppL2dLM1I3RHJieW1IMTdxT1RncU52RGRMalEz?=
 =?utf-8?B?akV5czAzZy9ycHVwM29Wc2pYRFE0VXJJMFNUNmI2b2t1cno0cUcyVFR5U3pR?=
 =?utf-8?B?cWJxSEl4cXVkUGNWdU1TTmRZRG1mMmZMbjlxajVDaWNwREpjZld3bzdJNWhL?=
 =?utf-8?B?ZlY4WC94TU92cGhOQzB4TndtZWpzaExER1hkVi9mOXNoMmJrczFZWWJBNXNs?=
 =?utf-8?B?b3NSNU9zb2hLMTBUM2xpRGFWa2szei9KWjkxT2NDTExUc3U4R3F2VnJNWE5J?=
 =?utf-8?B?TjZPRC9pRUpsWmpUcmJIMGdCWk05eFFTNmxiTXQySUt3MDVvSEJMZjRLVjdT?=
 =?utf-8?B?VlQxRkg0VnUrRXVTc2hMaDcvVm9CQ0hoNlV2eEZZVGI5czFZb0ZYSzlianJj?=
 =?utf-8?B?b0x4bW9qSzJ5TzQxRHpkMTNIb3lBNmhZSXo4TGZUQ2tNRys3Z1hIMWdvajJz?=
 =?utf-8?B?STgwY3FKMzlhS1NncDRtVlpSaHc2RHJhWnR6dm9PUTEzc281c3lyc3VPeVdi?=
 =?utf-8?B?S0J3d3U3djFqYmEyVU5VWDZSZzVwYWZxbXYveVhQM2hxK0hWcmdvWjVkOVRO?=
 =?utf-8?B?V2JtTzFHc3FkNmdQMm9KS1JxNWtRLy9WZS9tNnZURHROTUVOOTJjajFndFpk?=
 =?utf-8?B?N0FvMTFtd2VwbVdoa1U0T2FVa3hyM1g2MkFLT0N2ZmVuQ3hQTmNCZUR5TzY2?=
 =?utf-8?B?M1F2d20yYmFaN29lMnBuTHh3SWZvdkdFWGs2b1BkN2xCY3duejJ1a0dQR0V2?=
 =?utf-8?B?blhsWUNjSGJ0eUZxd05UYUU4OE5HL3pHU0w1T2VqS2FzVFFhNWZHZEpqWmYx?=
 =?utf-8?B?Z2FsV3p6d0o5dlYxa1VjcEsrN1FBdGVLWjB4VlJ0YVFUbjZvYk1IQkRYRnlx?=
 =?utf-8?B?SDNiWmpVbUZJb3M3WmVrRHdVT003Ump2eVRrUDFJTkJIQUs0RFlHL2luUmth?=
 =?utf-8?B?RmNuMnZudGkyVTYrbXBidzJIWWJLRS9xemh4eWdmVEJ5eXJrQlV1aEVBeitq?=
 =?utf-8?B?SlVBVDdwc21VaTk3ZzdGbkdNQ3dQd0Y3RTBrZ01NWlBPT3A0czRKN2V5dlk2?=
 =?utf-8?B?L2x1MGU4bzducmhoZm1TSUwwSmpOalRnNW9EYTl5NG4vSE83L3NvZWNuOS9W?=
 =?utf-8?B?YVVTd3BCcVB3REh4TWphd3NQdkJYc2UyQXo3b0RxYWNaQ3hpMEV2RFZwS1No?=
 =?utf-8?B?WHNOWThKeVA5dm1HdWFxbGJxTnVrSGo2MjVLRXgyOG4zSzQvNG5lbG9rSzNv?=
 =?utf-8?B?N1ZGQWgxWUxBRm1lMWVobFA1OU1xWjBzOEZKRWpzaU5UV0hzVXRqalYxTUxv?=
 =?utf-8?B?eWh4ZWFiZ1piNG5yaVRLNTgwdFZqaUxuSG4zTEZDSHZQMVRYdFd0QkVlMlZt?=
 =?utf-8?B?Y2Z4eTRWQWFUc1IweEJnN3RuNmYvOTQ5ekxCWnBZZ0ZEUjdoZm04ZG4zd0Iv?=
 =?utf-8?B?UThjcmFNTlFsZVhObEwzT3YxQWNBd3d6NGE5TjM5TXpTODJTcElCQk10Q05x?=
 =?utf-8?B?WGJDS0RPWmFPeDV4V09uc2tTODRCVmptSWQ4K0llODA5a1JqdUNIdXQvSHJz?=
 =?utf-8?B?YVBURHJWN29GWkdyUmRBQVZSZkRZSStsMlR4MUV2RURaL1FoYktxN3ZneHlF?=
 =?utf-8?B?ak84S3NMeXFqdmlkZDVRK0ZqVzlVR0VnZjFjRFFwc3ZMYjc4Q2NSejV4SnJ2?=
 =?utf-8?B?OTBxckxWOGpFYkxMaWVGdGhncTBNUUd1dUpMazBRaDR2OFpEQVN4Uy80S0Yz?=
 =?utf-8?B?Q0FLMUh6dWgxQUxLWWJYVWVRZ1Z4U3h0ZTQyQXNncnc1M2Y4U2gwSGx0cnBY?=
 =?utf-8?B?SmttTG8xam1ROWtHODFxTUN5WDN4Nlc3ZUlDR0lEUExQbnd0TStiTXF3Z0ZE?=
 =?utf-8?B?TmtoVmJZeEFlVEg0bUFXOVhvQTY2RWgvWm5lRjZlMVdQK28zWC90Zk43d1d0?=
 =?utf-8?B?RFROcjc2c2VDcmdxei9VUVhoZDdSWUlIaEpmSVAza0FMU0lzSGhXaDVESzdy?=
 =?utf-8?Q?jJ+3WKrBI5CRWlITr6wqZHMud?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8dea5a67-ca68-4716-5d6d-08db0b4129f1
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3205.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2023 08:31:11.7051
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vhnJO4AZR5SDpuSRXwYK5UdO0G2npcwmquyZ5MR55vYsE4VDNPlFieARRkAKQARUD2Osx19Z84eQxu8OYIym1Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8013
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Morimoto-san,

On 10-02-2023 05:12, Kuninori Morimoto wrote:
>
>> Simple-card/audio-graph-card drivers do not handle MCLK clock when it
>> is specified in the codec device node. The expectation here is that,
>> the codec should actually own up the MCLK clock and do necessary setup
>> in the driver.
> I have no objection about this patch, but have interesting about this comment.
>
> Simple-card/audio-graph-card both are using asoc_simple_hw_params,
> and it calls clk_set_rate() for Codec/CPU if it has mclk.
> But am I misunderstanding ?
> If it was simple-card-utils side miss, I'm happy to fix it.

The simple-card-utils driver does not populate the clock handle whenever 
the MCLK clock is parsed from CODEC device node. So 
asoc_simple_set_clk_rate() will not update the rate and clock 
enable/disable won't happen either.Initially I had tried to fix this in 
the simple-card-utils itself and it did break few things on other HW.
Please see [0] for relevant discussion.

Later [1] was pushed to address the issue I was facing that time.

In summary, the suggestion was, clock property should be associated with 
only devices and device driver should own up the clock handling for it. 
The machine driver can just pass the required configuration for it.


[0] 
https://patchwork.ozlabs.org/project/linux-tegra/patch/1612939421-19900-2-git-send-email-spujar@nvidia.com/#2647112
[1] 
https://lore.kernel.org/lkml/1615829492-8972-3-git-send-email-spujar@nvidia.com/