Date:   Fri, 10 Feb 2023 10:31:43 +0100
Message-ID: <87pmahj280.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Lucas Tanure <lucas.tanure@collabora.com>
Cc:     David Rhodes <david.rhodes@cirrus.com>,
        Charles Keepax <ckeepax@opensource.cirrus.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Mark Brown <broonie@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, alsa-devel@alsa-project.org,
        devicetree@vger.kernel.org, patches@opensource.cirrus.com,
        linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCH v5 0/4] Add CS35L41 shared boost feature
In-Reply-To: <20230210091942.10866-1-lucas.tanure@collabora.com>
References: <20230210091942.10866-1-lucas.tanure@collabora.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Fri, 10 Feb 2023 10:19:38 +0100,
Lucas Tanure wrote:
> 
> Valve's Steam Deck uses CS35L41 in shared boost mode, where both speakers
> share the boost circuit.
> Add this support in the shared lib, but for now, shared boost is not
> supported in HDA systems as would require BIOS changes.
> 
> Based on David Rhodes shared boost patches.
> 
> Also, fix boost config overwriting in IRQ found in the review and do a
> small refactor of the code.
> 
> Changes from V4:
>  - Fix Document subject
> 
> Changes from V3:
>  - Fix wrong code sent
>  - Fix ISO C90 mixed declarations and code 
> 
> Changes from V2:
>  - Drop External boost without VSPK Documentation
>  - Move Shared boost to use values 2 and 3
>  - Revert back to reg_sequence but reading the value first and only update
> the necessary bits
>  - Fix bug found by Intel kernel Test Robot
> 
> Changes from V1:
>  - Fix Documentation patch subject
>  - New patch for External boost without VSPK Documentation
>  - New patch to fix boost IRQ overwriting issue
>  - New patch to refactor IRQ release error code
>  - reinit_completion on pcm_startup
>  - fix DRE switch overwriting
>  - return IRQ_HANDLED in PLL_LOCK case
> 
> Lucas Tanure (4):
>   ASoC: cs35l41: Only disable internal boost
>   ASoC: cs35l41: Refactor error release code
>   ALSA: cs35l41: Add shared boost feature
>   ASoC: dt-bindings: cirrus,cs35l41: Document CS35l41 shared boost

In case the series going through Mark's tree:

Reviewed-by: Takashi Iwai <tiwai@suse.de>


thanks,

Takashi