Date:   Fri, 10 Feb 2023 17:24:14 +0800
From:   Xu Yilun <yilun.xu@intel.com>
To:     Russ Weight <russell.h.weight@intel.com>
Cc:     Ilpo =?iso-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        Moritz Fischer <mdf@kernel.org>, Wu Hao <hao.wu@intel.com>,
        Tom Rix <trix@redhat.com>, Lee Jones <lee@kernel.org>,
        Tianfei zhang <tianfei.zhang@intel.com>,
        linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fpga: m10bmc-sec: Fix rsu_send_data() to return
 FW_UPLOAD_ERR_HW_ERROR
Message-ID: <Y+YNPtNxAcwugkAs@yilunxu-OptiPlex-7050>
References: <20230208080846.10795-1-ilpo.jarvinen@linux.intel.com>
 <79d47a18-90dd-9fc2-aa0e-ca5627b7ca6d@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <79d47a18-90dd-9fc2-aa0e-ca5627b7ca6d@intel.com>
Precedence: bulk

On 2023-02-08 at 11:28:26 -0800, Russ Weight wrote:
> 
> On 2/8/23 00:08, Ilpo J?rvinen wrote:
> > rsu_send_data() should return FW_UPLOAD_ERR_* error codes instead of
> > normal -Exxxx codes. Convert <0 return from ->rsu_status() to
> > FW_UPLOAD_ERR_HW_ERROR.
> >
> > Fixes: 001a734a55d0 ("fpga: m10bmc-sec: Make rsu status type specific")
> Reviewed-by: Russ Weight <russell.h.weight@intel.com>

Acked-by: Xu Yilun <yilun.xu@intel.com>

> 
> > Signed-off-by: Ilpo J?rvinen <ilpo.jarvinen@linux.intel.com>
> >
> > ---
> >  drivers/fpga/intel-m10-bmc-sec-update.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/fpga/intel-m10-bmc-sec-update.c b/drivers/fpga/intel-m10-bmc-sec-update.c
> > index f0acedc80182..d7e2f9f461bc 100644
> > --- a/drivers/fpga/intel-m10-bmc-sec-update.c
> > +++ b/drivers/fpga/intel-m10-bmc-sec-update.c
> > @@ -474,7 +474,7 @@ static enum fw_upload_err rsu_send_data(struct m10bmc_sec *sec)
> >  
> >  	ret = sec->ops->rsu_status(sec);
> >  	if (ret < 0)
> > -		return ret;
> > +		return FW_UPLOAD_ERR_HW_ERROR;
> >  	status = ret;
> >  
> >  	if (!rsu_status_ok(status)) {
> >
>