Date:   Fri, 10 Feb 2023 12:13:33 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Saravana Kannan <saravanak@google.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Sudeep Holla <sudeep.holla@arm.com>,
        Cristian Marussi <cristian.marussi@arm.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        Thomas Gleixner <tglx@linutronix.de>,
        Marc Zyngier <maz@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Rob Herring <robh+dt@kernel.org>,
        Frank Rowand <frowand.list@gmail.com>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Magnus Damm <magnus.damm@gmail.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Daniel Scally <djrscally@gmail.com>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Len Brown <lenb@kernel.org>,
        =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>,
        Abel Vesa <abel.vesa@linaro.org>,
        Alexander Stein <alexander.stein@ew.tq-group.com>,
        Tony Lindgren <tony@atomide.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        John Stultz <jstultz@google.com>,
        Doug Anderson <dianders@chromium.org>,
        Guenter Roeck <linux@roeck-us.net>,
        Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        Maxim Kiselev <bigunclemax@gmail.com>,
        Maxim Kochetkov <fido_max@inbox.ru>,
        Luca Weiss <luca.weiss@fairphone.com>,
        Colin Foster <colin.foster@in-advantage.com>,
        Martin Kepplinger <martin.kepplinger@puri.sm>,
        Jean-Philippe Brucker <jpb@kernel.org>,
        kernel-team@android.com, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
        linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
        linux-renesas-soc@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH v3 00/12] fw_devlink improvements
Message-ID: <20230210101333.h2e7hcl3ylsoh6fy@skbuf>
References: <20230207014207.1678715-1-saravanak@google.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230207014207.1678715-1-saravanak@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YA+RO1TBwF9kROubBL6n5nvBCtTxWhbzwaxRMEcmb4D+8NEptJuMEAAGR/qE?=
 =?us-ascii?Q?IE9SJFV5PwoaxVWf4MmCv4sR2iLUoD6edrg8F/B48QgAEVegKVRhv1Lkr0Fh?=
 =?us-ascii?Q?SUhH90wbEdNcai0oZ7pEfTursHG9O+CKUUM7l50O5mQ2HmVYY/vyf65AESqy?=
 =?us-ascii?Q?2Ts01VmDNPgy1Ykeaa7/PHOcyv+VzueMmwdSDZ2QSUfcpK9OQosOFAZATxcS?=
 =?us-ascii?Q?41oRGuoqPaVvyb+L/zMM+hnbWX1Lk1LkdbcEcBEpmY99uF3xCThi/gm2BzPC?=
 =?us-ascii?Q?tW3uyPmHkxqvq3loop1mIsXA7v5EsvJ5/VVMgN36fosONamfEyazv5QMTpJ7?=
 =?us-ascii?Q?CxHgpVsUfdHO8EQk/WNdZsrysArHs0tM62xuPmJzBR6f2yfCEpQwiMniUucV?=
 =?us-ascii?Q?ohiW9ZlTHQjsQhzP/z0ytfWz+/C0H2yx4Up9YGZZsKPIrMB5+2Gt3hMqaFmw?=
 =?us-ascii?Q?0O/7B4DqWyv/8siy7u346RMju3MvB04RQTSH1WaBhezmUn1C4IsVp5ei/1on?=
 =?us-ascii?Q?vabLKiVTK8pLQW4vxPUVQjjFht/ICuRFUmKsybie3X+17Rb9gnydkAnn0g5d?=
 =?us-ascii?Q?bEAIJa7VE3Buno5qC0EPD6Htv6Q1qV8OPsaD0tZlCz9mAL1KBaU9gthJ/S3m?=
 =?us-ascii?Q?phf5hi3MimZPBMDjAxkXlN3AD5/ctSnbSe3oB5mFjatsoyl7hUcnpBAId3fE?=
 =?us-ascii?Q?C6dM7wDY51/yKX0Cug+yuht0qkRnY2D0z08ExyF/4zGMA6wqHwAtPcUL9LhC?=
 =?us-ascii?Q?UuA4fanjfdM+1CwjFqtq6I2DJSIyqtNxXYuuTDFwb375y9gArZj37Vno506A?=
 =?us-ascii?Q?S7eKjRHh4vXxzEIvDC+F1ki5eVe3W/f07DALPv3Hqwb9DRRGfD+u6s5Yhetf?=
 =?us-ascii?Q?LwlWnluAbQfKtNSKstMpDVjlYb9/D3bDop5mR+fLIdwoNSqyZcRK4EQ295v9?=
 =?us-ascii?Q?EhKRb0YiNnOfN4tl4R+/6P6JdzJ4ZYuzjEmFAWGAsXGfbxVhoAI64rEgO72L?=
 =?us-ascii?Q?1rmLWrnnoia6kQxcu6awCKmNeebTfuRe0at1XiL5o7/3JRRbb4u4ZVBGoOjH?=
 =?us-ascii?Q?6yHyJV3vf6tWE++/tUOrzyDSkuWuTcuBt3IaRJaFOoLOSeSXLBf+yv6h6atj?=
 =?us-ascii?Q?fhw59NWJdU8clg52bcLtwFJ4NB7y0P1CqYLqys+9x2Puq4/dhVMyGan6U7a9?=
 =?us-ascii?Q?zafVEZIi8S528+byLY4Fp1+fPdmPU0HfPFgtl40FMR+KfLSmgWY7jfo7cHtf?=
 =?us-ascii?Q?E+Y1od3syh5X05qp4SY8oAMm6aKKWeOElg4x01j7nFkoe1YG7tpOGVVm6RpV?=
 =?us-ascii?Q?FftYbdi+ICmVVkHBX2yBmWXJKjs4aBTi5NrcsM1C0VMLUssH5/zoA7JD/pt1?=
 =?us-ascii?Q?7momlrPtaLin1jdBcGBaFbW7HRlCNeaL7wxMZfEGECDJbn3IcTQPH9rOI6td?=
 =?us-ascii?Q?lJaWecnL0P4GhoLgEVlP6rua1Pn/AUMKHzUW/ZVqrewdDD7TjgaN9Bno/h5C?=
 =?us-ascii?Q?6oY7ZsGcbElQ1BGl6MYGN5qUbfa6q3Af5PDAejJyqBMJtwgkV47skKRS8QVH?=
 =?us-ascii?Q?a8z1MqcmaolZIJWpAS4zegJtTSmgz5uHr7Lc8AdYrdwNxH+eSUgjPl4Ta3Qj?=
 =?us-ascii?Q?Cg=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c807fb3f-7904-472d-c30c-08db0b4f7b74
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2023 10:13:40.8690
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: If2CAHjBEWdxEWJPoKGg5MwXV4LXazOEB3m9kqTSOzhE9STLwILMD1czbFilSCkd8OR6PE+iApWKMtzn8aHMrA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8273
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Saravana,

On Mon, Feb 06, 2023 at 05:41:52PM -0800, Saravana Kannan wrote:
> Vladimir,
> 
> Ccing you because DSA's and fw_devlink have known/existing problems
> (still in my TODOs to fix). But I want to make sure this series doesn't
> cause additional problems for DSA.
> 
> All,
> 
> This patch series improves fw_devlink in the following ways:
> 
> 1. It no longer cares about a fwnode having a "compatible" property. It
>    figures this out more dynamically. The only expectation is that
>    fwnodes that are converted to devices actually get probed by a driver
>    for the dependencies to be enforced correctly.
> 
> 2. Finer grained dependency tracking. fw_devlink will now create device
>    links from the consumer to the actual resource's device (if it has one,
>    Eg: gpio_device) instead of the parent supplier device. This improves
>    things like async suspend/resume ordering, potentially remove the need
>    for frameworks to create device links, more parallelized async probing,
>    and better sync_state() tracking.
> 
> 3. Handle hardware/software quirks where a child firmware node gets
>    populated as a device before its parent firmware node AND actually
>    supplies a non-optional resource to the parent firmware node's
>    device.
> 
> 4. Way more robust at cycle handling (see patch for the insane cases).
> 
> 5. Stops depending on OF_POPULATED to figure out some corner cases.
> 
> 6. Simplifies the work that needs to be done by the firmware specific
>    code.
> 
> The v3 series has gone through my usual testing on my end and looks good
> to me.

Booted on an NXP LS1028A (arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts)
and a Turris MOX (arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts)
with no observed regressions. Is there something specific you would like
me to test?