Message-ID: <288e133f-f740-6818-8125-8079217ab822@linux.ibm.com>
Date:   Fri, 10 Feb 2023 16:55:54 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH AUTOSEL 6.1 17/38] powerpc/85xx: Fix unannotated
 intra-function call warning
Content-Language: en-US
To:     Sasha Levin <sashal@kernel.org>, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org
Cc:     kernel test robot <lkp@intel.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        christophe.leroy@csgroup.eu, npiggin@gmail.com,
        naveen.n.rao@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org,
        Sathvika Vasireddy <sv@linux.ibm.com>
References: <20230209111459.1891941-1-sashal@kernel.org>
 <20230209111459.1891941-17-sashal@kernel.org>
From:   Sathvika Vasireddy <sv@linux.ibm.com>
In-Reply-To: <20230209111459.1891941-17-sashal@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
Precedence: bulk

Hi Sasha,

On 09/02/23 16:44, Sasha Levin wrote:
> From: Sathvika Vasireddy <sv@linux.ibm.com>
>
> [ Upstream commit 8afffce6aa3bddc940ac1909627ff1e772b6cbf1 ]
>
> objtool throws the following warning:
>    arch/powerpc/kernel/head_85xx.o: warning: objtool: .head.text+0x1a6c:
>    unannotated intra-function call
>
> Fix the warning by annotating KernelSPE symbol with SYM_FUNC_START_LOCAL
> and SYM_FUNC_END macros.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Sathvika Vasireddy <sv@linux.ibm.com>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> Link: https://lore.kernel.org/r/20230128124138.1066176-1-sv@linux.ibm.com
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
>   arch/powerpc/kernel/head_85xx.S | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/head_85xx.S b/arch/powerpc/kernel/head_85xx.S
> index 52c0ab416326a..d3939849f4550 100644
> --- a/arch/powerpc/kernel/head_85xx.S
> +++ b/arch/powerpc/kernel/head_85xx.S
> @@ -862,7 +862,7 @@ _GLOBAL(load_up_spe)
>    * SPE unavailable trap from kernel - print a message, but let
>    * the task use SPE in the kernel until it returns to user mode.
>    */
> -KernelSPE:
> +SYM_FUNC_START_LOCAL(KernelSPE)
>   	lwz	r3,_MSR(r1)
>   	oris	r3,r3,MSR_SPE@h
>   	stw	r3,_MSR(r1)	/* enable use of SPE after return */
> @@ -879,6 +879,7 @@ KernelSPE:
>   #endif
>   	.align	4,0
>   
> +SYM_FUNC_END(KernelSPE)
>   #endif /* CONFIG_SPE */
>   
>   /*

Please drop this patch because objtool enablement patches for powerpc 
are not a part of kernel v6.1.

Thanks,
Sathvika