Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F1BBC636D3 for ; Fri, 10 Feb 2023 11:40:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232107AbjBJLkk (ORCPT ); Fri, 10 Feb 2023 06:40:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231488AbjBJLki (ORCPT ); Fri, 10 Feb 2023 06:40:38 -0500 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C5492A6C3 for ; Fri, 10 Feb 2023 03:40:37 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id j29-20020a05600c1c1d00b003dc52fed235so3864348wms.1 for ; Fri, 10 Feb 2023 03:40:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=G/8Pm8otgvuIcD10Zw5d+1Xdi4JIWGeXmfgq3MAhdLo=; b=lZdJWdlCGsoSvv2HrB5MxOYBR9t7M0m/6es/J29iRkHJwIg2FYiHSUnWuRPJlXvOkf 82lx3K2u612x++dzVtirRuDsUw3G/+ocPDLOdYqsgWMYam63n4GtEHQthNPhmSTF2KQk pSw/a5T5VHYMTBrEkhVhq30kI8b+CnceSduwssaJCjWDbt1ETce8vFqx/2QgVLHf5ngA 9yFCUa5bQOxvHIevK/QGKra1CRUxGuMu1kOSb7wh+9d9O5nHJ2e9gwDI/2GyWWUnBTuL ppP7B03ywEspPwIEiCEZowRH0XmPWa8i3F1RDy6taGqdNfajySg8AScTPfUCqj9mh315 /34w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=G/8Pm8otgvuIcD10Zw5d+1Xdi4JIWGeXmfgq3MAhdLo=; b=UlOFrPb2A3LEVyR/ePisCtw8cRltnaKwRnufwkwOB+Zbh6SqftMW2SJ05fiO0Asmg8 EA20T6unS6YgPvknPOyLTbosB3UGvQh8hYWUaZVJu0DgeYuLfnf1WRpGPsJLs6o5La9o TYnqPlUkSQb9E4lsyDLQXqG74J/GQ3u5hvN3E3ZLdpoPAPm8FcwVpStsQR91FFT41TBQ GPqcsatspqIvpGabktwjGNFAVxMh1Fk+0qlFlKZXQ1pFN52aV96wA9s/uOM3p/O8vN5u YE+ZKgjGMJRLp7Ct8ZeeffSkSNfJHFEONhN0r4qv82ayk4xMnTYnFd65+ma/qDE1UQel 5k2w== X-Gm-Message-State: AO0yUKWYL/jrY65Q7PqJliUWZdBVwHsXRIcde3XalFgAFxERqKkKqZwI 6bqi6hi34TzxfCTf1UGDb/U69A== X-Google-Smtp-Source: AK7set+WjGBjahYz9ocoZeCt+9iNkzBLgdueVDR1ZSpT8QU8aOfFDcfbToNfZqxXc4TJ5eBgmnLhLA== X-Received: by 2002:a05:600c:703:b0:3da:fd07:1e3 with SMTP id i3-20020a05600c070300b003dafd0701e3mr12649869wmn.22.1676029235975; Fri, 10 Feb 2023 03:40:35 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id o41-20020a05600c512900b003dc4aae4739sm9030580wms.27.2023.02.10.03.40.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Feb 2023 03:40:35 -0800 (PST) Message-ID: <9b523fe7-ef94-bcaf-62b0-9e8503f592e4@linaro.org> Date: Fri, 10 Feb 2023 12:40:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH V5 1/3] dt-bindings: i2c: xiic: Add 'xlnx,axi-iic-2.1' to compatible Content-Language: en-US To: Manikanta Guntupalli , michal.simek@xilinx.com, michal.simek@amd.com, devicetree@vger.kernel.org, andrew@lunn.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Cc: git@amd.com, srinivas.goud@amd.com, shubhrajyoti.datta@amd.com, manion05gk@gmail.com, Raviteja Narayanam References: <1675942646-31006-1-git-send-email-manikanta.guntupalli@amd.com> <1675942646-31006-2-git-send-email-manikanta.guntupalli@amd.com> From: Krzysztof Kozlowski In-Reply-To: <1675942646-31006-2-git-send-email-manikanta.guntupalli@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/02/2023 12:37, Manikanta Guntupalli wrote: > From: Raviteja Narayanam > > Add xilinx I2C new version 'xlnx,axi-iic-2.1' string to compatible A nit: Missing full stop in this sentence. > Add clock-frequency as optional property. > > Signed-off-by: Raviteja Narayanam > Signed-off-by: Manikanta Guntupalli > Acked-by: Michal Simek > --- > > + clock-frequency: > + description: > + Optional I2C SCL clock frequency. If not specified, do not configure > + in software, rely only on hardware design value. Supported frequencies > + are 100KHz, 400KHz and 1MHz. > + default: 100000 Then also: enum: [ 100000, 400000, 1000000 ] and drop the freeform text (last sentence from description). Best regards, Krzysztof