MIME-Version: 1.0
References: <20230123220500.21077-1-kirill.shutemov@linux.intel.com> <20230123220500.21077-10-kirill.shutemov@linux.intel.com>
In-Reply-To: <20230123220500.21077-10-kirill.shutemov@linux.intel.com>
From:   Alexander Potapenko <glider@google.com>
Date:   Fri, 10 Feb 2023 13:29:44 +0100
Message-ID: <CAG_fn=UZK8c39grJBcrC+=8EhmO8KBkAq-zoo3kgg=GP616W7A@mail.gmail.com>
Subject: Re: [PATCHv15 09/17] mm: Expose untagging mask in /proc/$PID/status
To:     "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc:     Dave Hansen <dave.hansen@linux.intel.com>,
        Andy Lutomirski <luto@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, x86@kernel.org,
        Kostya Serebryany <kcc@google.com>,
        Andrey Ryabinin <ryabinin.a.a@gmail.com>,
        Andrey Konovalov <andreyknvl@gmail.com>,
        Taras Madan <tarasmadan@google.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        "H . J . Lu" <hjl.tools@gmail.com>,
        Andi Kleen <ak@linux.intel.com>,
        Rick Edgecombe <rick.p.edgecombe@intel.com>,
        Bharata B Rao <bharata@amd.com>,
        Jacob Pan <jacob.jun.pan@linux.intel.com>,
        Ashok Raj <ashok.raj@intel.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Catalin Marinas <catalin.marinas@arm.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Jan 23, 2023 at 11:05 PM Kirill A. Shutemov
<kirill.shutemov@linux.intel.com> wrote:
>
> Add a line in /proc/$PID/status to report untag_mask. It can be
> used to find out LAM status of the process from the outside. It is
> useful for debuggers.
>
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
> Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>


>         mm->context.untag_mask = -1UL;
> diff --git a/fs/proc/array.c b/fs/proc/array.c
> index 49283b8103c7..d2a94eafe9a3 100644
> --- a/fs/proc/array.c
> +++ b/fs/proc/array.c

Right now mm_untag_mask() is visible from array.c thanks to inclusion
of <linux/cpuset.h>, which happens to include <linux/mmu_context.h>.
But maybe it would be better to directly include mmu_context.h here?