Message-ID: <734a0c9f-83e0-2c99-7130-c02feac246df@intel.com>
Date:   Fri, 10 Feb 2023 14:19:19 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH bpf] bpf, test_run: fix &xdp_frame misplacement for
 LIVE_FRAMES
Content-Language: en-US
From:   Alexander Lobakin <alexandr.lobakin@intel.com>
To:     =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= <toke@redhat.com>
CC:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        Jakub Kicinski <kuba@kernel.org>, <bpf@vger.kernel.org>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230209172827.874728-1-alexandr.lobakin@intel.com>
 <6db57eb4-02c2-9443-b9eb-21c499142c98@intel.com> <87sffe7e00.fsf@toke.dk>
 <701f6030-72d7-0f11-173b-a2365774b6f2@intel.com>
In-Reply-To: <701f6030-72d7-0f11-173b-a2365774b6f2@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eTMrYWNyTm1LQkg4NUp1R1VncW1UYkpLK3ZDNzdFazFQcnN6Y0NremJORk50?=
 =?utf-8?B?UGl0aXJ1bHgzUDJiMXlxMFNhdmJvdWpwRVdMOUt3UjIvNFhZdkloYWY3eUJF?=
 =?utf-8?B?L3QreTRlMUpTMGNBWnJUdDF4UzBtKzVPdHV2SXRac0ovTlE0M2NZZXpNajBH?=
 =?utf-8?B?VTIzNUdQVTJiaXJyZ1h5N3pKU3NvbnJpZ0JzeFpkL2d0azRZZk1lVVRXVFRt?=
 =?utf-8?B?SGdhM1BxeEdGYmZXd1MwdG9HRUNiK0w3YnV6WVVvamZQQlJnUm9aVmM2MGtj?=
 =?utf-8?B?end6eTZUa3diZ1BaM3pHNVF1UlpUaE9tdExpb3gyZnM0Z3Jkck0rcTRPT0tn?=
 =?utf-8?B?WDlMYnlucjRtRVVzSmlucms4UUhwNlJ5ZStwRzQzM1ozSVhqWktjaSszd05j?=
 =?utf-8?B?cEJheWNSQ3FyUEdKK09wNTIrMG4xQnUwaHlwUVhHV3dYOFlYTDlaaXk1b2Ra?=
 =?utf-8?B?YmZSWFlrdENiblBxeVM0ald1d3VtSXEvczZYY0xJOWVBTlhWZFl0ZW8yNFdi?=
 =?utf-8?B?VkVFQ2F0RzZJQUs3OTRBZ1luZ0JSNTlCeWtrRW12ckRwdkxIZ0REMWhOZlc3?=
 =?utf-8?B?bzMvWjZUamtvNlNKY1VXU3Y3WllmdmV5WGFaT3QvZnEwSCtWQnVOeWNtVEFK?=
 =?utf-8?B?QmxMQUxJbGluckV5dy95amgrS3RjWko1eWp0L0VseEtaSUxPQlYvMTh5RDVM?=
 =?utf-8?B?RTVHUGRqZWM1MlNnYXdMbHVvTjFGRzZlSGtPRlJQUjUvTkNEdThFQi91YVFS?=
 =?utf-8?B?YTdVRk1yd0tEOHJvTXZLNjBFQy9pOCtHR2loSlhFV2dZVlAwK0N6ZHNuRDJS?=
 =?utf-8?B?NUNnZ2twZEltSHNWRStYUENGV25OSW5lUnoyNVNOcXhUaXp0eFhNakpmSjhk?=
 =?utf-8?B?RnNOTEZQaHoweVFlSFBEWExaak93WmZVTGJUK2MzNDU1SHI2T1hPTllqYmdX?=
 =?utf-8?B?RFZ0RGh3Zm54MVFFYnRtOUtpaGY4TDlaQXhUUkI1TENsVWdhUzZabjFqbVBG?=
 =?utf-8?B?RlVVdmMyUXhoMC95QUxXL2hFQ09GS0NQY1AwMjByZW43RkdsQ3BOQlZXN1Y0?=
 =?utf-8?B?NW1saExXT3BudWZoSTZNUjNrcmtOZi90THh0VG51aWF5ODZid2lsQ05STjc0?=
 =?utf-8?B?blZCZzE1NWRycklPMUpUNTFnbEZFTGlPZkwzVThwSlIrSU5RNWhYRG1EcmNt?=
 =?utf-8?B?RVFYYVQ0QlRpM0VJZ3AwYTFhS1VSdGsrWFdyRmZ0RFplTStxdVd3UUFqZnJ0?=
 =?utf-8?B?WlNnUXgrNmVvZGRncmJtWG05ZktKR0d4MFNKZFZiMk10dmFXeXM1aUVFZDZM?=
 =?utf-8?B?OWNmZ0pKbTkxUXlBOWhxVXZuUm1Td2lTU0NBcGVTdzFCWEtxVjloQUdNOGJS?=
 =?utf-8?B?TENDdlNNWW5GQXArRFFReWhVSGxlQXZweGd3QmZzSFY3d2JsY3ByZEppNTZE?=
 =?utf-8?B?bVY2aEhUSGJMdTE0TThML0VKQUYzVXIwem9kUCtjb2Jmc01HYnA1a0lVYVpr?=
 =?utf-8?B?dHFWMUFTQ3JEellHMmM2UnNkcE5ML0lvc294NTNmNG1zRGFOanZzdmdnQ1Bj?=
 =?utf-8?B?TFRySlNKQ3huRWpEWVk1eEdIUUJIN3U0M0VpRjhhaUgrWndpNExLY1JlYVJP?=
 =?utf-8?B?aEh6N2xoYXBOcW5zci9JRWlPY0JrOUJaRnRxeWlpdXBLYWZBUE53cVZySlZz?=
 =?utf-8?B?dVRxRHZCbjAvYlJhekVCRG9yK1c2MzB1UU1Lb0kyZ0FZWlhiUWtPV3VqeTNM?=
 =?utf-8?B?cENxZUFRd0orS2pjMkU0OEM2ZDA0MmF0OWwweWwxbytFQUo4SnFiQzF5RWtW?=
 =?utf-8?B?Y0dsT1M0WlE3RTJqaTVUeVg0QjFWZS94OUVSa2N1UlpTUEsvVVd6ZjdZa2wr?=
 =?utf-8?B?TVdjNUUycWxYbTZWKzJxOVJFYnNKMyt6T0pNTXoxeWdBODFWNE5zdk5JUDlL?=
 =?utf-8?B?MWFicHVyYzJwQU9Ba3BuMG9qenp0Vko2OHJaOTd3Y1EzN0Z0NDJCUjBId3Zp?=
 =?utf-8?B?Y0tTa0lRMFBxMGtoM3hsTmtWL0RXRTZtVXB2d2xWQ1ZtWkN4ZGN2VlhZZGhU?=
 =?utf-8?B?T0JYY3kvem82RU9pdCtLdGV6aFp3YTFtNXlvbXJudnBhSGdoWTBNZHZ2WHdO?=
 =?utf-8?B?Y21YZnBERDdGMzZ3a1hwdHljR2Z0bWxXYVMwYW1IWU54NTVyMzJHV0t0WUNP?=
 =?utf-8?B?b1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 683e205e-7c62-42ff-342a-08db0b698228
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3624.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2023 13:19:58.9482
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /Wp4InW7L3v9fDjV7yYcbRcTsFd6AtkypESOUq4wFlSOpzHt7txIM4SEdR9oSWeQgXMkYX2HaEautcoPjpYYT6EqysJRr4L5vAUJry4y+AQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6155
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Alexander Lobakin <alexandr.lobakin@intel.com>
Date: Fri, 10 Feb 2023 13:31:28 +0100

> From: Toke Høiland-Jørgensen <toke@redhat.com>
> Date: Thu, 09 Feb 2023 21:58:07 +0100
> 
>> Alexander Lobakin <alexandr.lobakin@intel.com> writes:

[...]

>> Hmm, IIRC my reasoning was that both those cache lines will be touched
>> by the code in xdp_test_run_batch(), so it wouldn't matter? But if
>> there's a performance benefit I don't mind adding an explicit alignment
>> annotation, certainly!
> 
> Let me retest both ways and will see. I saw some huge CPU loads on
> reading xdpf in ice_xdp_xmit(), so that was my first thought.

No visible difference in perf and CPU load... Ok, aligning isn't worth it.

> 
>>
>>> (but in bpf-next probably)
>>
>> Yeah...
>>
>> -Toke
>>
Olek