MIME-Version: 1.0
References: <20230210121735.639089-1-sergio.paracuellos@gmail.com>
 <20230210121735.639089-2-sergio.paracuellos@gmail.com> <b59d426d-8a5e-9eff-57f2-e36ebfdc5466@linaro.org>
 <CAMhs-H_6-2P7aaqSvFDypdfbf_YzhPW0r-GCP_xfO5TgyU6Bnw@mail.gmail.com> <992912ca-63b2-9882-eb7a-f7a40d432853@linaro.org>
In-Reply-To: <992912ca-63b2-9882-eb7a-f7a40d432853@linaro.org>
From:   Sergio Paracuellos <sergio.paracuellos@gmail.com>
Date:   Fri, 10 Feb 2023 15:22:01 +0100
Message-ID: <CAMhs-H_MhgksPO0B+wPs=sueWrSygWT=dGnPUi-biWR_HBQEeA@mail.gmail.com>
Subject: Re: [PATCH v2 1/4] dt-bindings: watchdog: mt7621-wdt: add phandle to
 access system controller registers
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     linux-watchdog@vger.kernel.org, wim@linux-watchdog.org,
        linux@roeck-us.net, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com,
        arinc.unal@arinc9.com, tsbogend@alpha.franken.de,
        p.zabel@pengutronix.de, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, linux-mips@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Feb 10, 2023 at 2:35 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 10/02/2023 14:14, Sergio Paracuellos wrote:
> > On Fri, Feb 10, 2023 at 2:03 PM Krzysztof Kozlowski
> > <krzysztof.kozlowski@linaro.org> wrote:
> >>
> >> On 10/02/2023 13:17, Sergio Paracuellos wrote:
> >>> MT7621 SoC provides a system controller node for accessing to some registers.
> >>> Add a phandle in this node to avoid using MIPS related arch operations and
> >>> includes in watchdog driver code.
> >>>
> >>> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> >>> ---
> >>>  .../devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml  | 7 +++++++
> >>>  1 file changed, 7 insertions(+)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml
> >>> index b2b17fdf4..cc701e920 100644
> >>> --- a/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml
> >>> +++ b/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml
> >>> @@ -19,6 +19,12 @@ properties:
> >>>    reg:
> >>>      maxItems: 1
> >>>
> >>> +  ralink,sysctl:
> >>
> >> Thanks for the changes. I did not notice it before - isn't Ralink part
> >> of Mediatek now? Also compatible is mediatek, not "ralink"?
> >
> > Yes, it is. I was using the same prefix as for the memory controller
> > syscon phandler inside the 'sysc' node [0].
> >
> > I have no problems at all in changing this to 'mediatek' if preferred.
> >
>
> Yes, mediatek as already used in this binding is preferred.

Sure, I will do it and send v3. Let's wait for some other review
comments in the rest of the patches and will send all them together.

>
> Best regards,
> Krzysztof
>

Thanks,
    Sergio Paracuellos