Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B43C1C636CD for ; Fri, 10 Feb 2023 14:28:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232512AbjBJO24 (ORCPT ); Fri, 10 Feb 2023 09:28:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232331AbjBJO2z (ORCPT ); Fri, 10 Feb 2023 09:28:55 -0500 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A22E27358E for ; Fri, 10 Feb 2023 06:28:53 -0800 (PST) Received: by mail-wm1-x32f.google.com with SMTP id j29-20020a05600c1c1d00b003dc52fed235so4203175wms.1 for ; Fri, 10 Feb 2023 06:28:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=guuw8fNr8ek6MKlKjsKHEfRl2wvHYLY1FYFS39aDXmo=; b=wwlzhw00GEnOlY5ru98N3sJZjli9DmVZXQsWhbquo+ZIWztUTytBzwgFgSPccuBvPr 7Aj2i4W+zkBnv3C3BRi3W8tmxOqlqvAjLqDrUG7VOY5a6a15fL0Qk6ul0Z8DzvERRosv 6UUMKhyjKibE8wB+GV5JczReFz4lfRIdXyfS+REHPv1Pq8cBA47MXsR50z7WAQ1eqTj6 lnT6vKSaLL18Wa5LDLGI7eqvS9+oTbwDLl2lAcngvvtQqCTYxHwgKObXI7KTJazFjzyk 0lBZf6LuKT47Dg5+X4oYwEBtscnV23aIIAGOJrI4SyFrhjgAdxh3eUuJJZrmOrqeNO9g qM0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=guuw8fNr8ek6MKlKjsKHEfRl2wvHYLY1FYFS39aDXmo=; b=D4w28J63MkX5HEiEExFqJ0LlOXhRsUrls7QsSag6aYeG4A57KRgV39cGPvjR7oxE+W ocMkqdyR3H4wOV9A8ynaVeJHwNI83YHWgJhkUxsfzo1zhvnkyh1uuXeIUpMjfMZ3G6Kk j4S6lfcTNZHpz6/GRKEJaQW7DYm8bW+NGM5bHRv5OuShLnYwV4dJ5KXRU3x/izbei6sr GD3hmnWD53M8b2M2jXn4XJPYdPRQDFjDszKvZIgHOtWnXwlkYwmKfyTCIpj8vrdMpptr kpBdI02FklpbQKtBN4jvuMZrEAIo6ehUfyG41hRlE9vUecwFEP0ffyzYA555VhYIrpFL PYWg== X-Gm-Message-State: AO0yUKX/9tLSfRJqtI/LL08EV13mFAK5+4Lwm/NJsgvix+kAXeps13H+ KkvtcyLcCm5gh4FWmZ8/RsOd0Q== X-Google-Smtp-Source: AK7set9psfB2CgFVm0ZCdVqPYR3dikKyySJ+OFxHi2O3dgsTxlOvcyYTV7Wv31CppCH/lcwneloMVw== X-Received: by 2002:a05:600c:4d92:b0:3df:dea7:8e3 with SMTP id v18-20020a05600c4d9200b003dfdea708e3mr14313259wmp.21.1676039332126; Fri, 10 Feb 2023 06:28:52 -0800 (PST) Received: from [192.168.2.1] (146725694.box.freepro.com. [130.180.211.218]) by smtp.googlemail.com with ESMTPSA id r14-20020a05600c35ce00b003dc4ecfc4d7sm5694466wmq.29.2023.02.10.06.28.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Feb 2023 06:28:51 -0800 (PST) Message-ID: Date: Fri, 10 Feb 2023 15:28:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 1/1] thermal/drivers/hisi: Drop second sensor hi3660 Content-Language: en-US To: Yongqin Liu , rafael@kernel.org, amitk@kernel.org, rui.zhang@intel.com, edubezval@gmail.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: keescook@chromium.org, sumit.semwal@linaro.org, jstultz@google.com References: <20230210141507.71014-1-yongqin.liu@linaro.org> From: Daniel Lezcano In-Reply-To: <20230210141507.71014-1-yongqin.liu@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/02/2023 15:15, Yongqin Liu wrote: > The commit 74c8e6bffbe1 ("driver core: Add __alloc_size hint to devm > allocators") exposes a panic "BRK handler: Fatal exception" on the > hi3660_thermal_probe funciton. > This is because the function allocates memory for only one > sensors array entry, but tries to fill up a second one. > > Fix this by removing the unneeded second access. > > Fixes: 7d3a2a2bbadb ("thermal/drivers/hisi: Fix number of sensors on hi3660") > Signed-off-by: Yongqin Liu > Link: https://lore.kernel.org/linux-mm/20221101223321.1326815-5-keescook@chromium.org/ > --- Applied, thanks -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog