Date:   Fri, 10 Feb 2023 16:06:51 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Hariprasad Kelam <hkelam@marvell.com>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com,
        edumazet@google.com, sgoutham@marvell.com, lcherian@marvell.com,
        gakula@marvell.com, jerinj@marvell.com, sbhatta@marvell.com,
        jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
        saeedm@nvidia.com, richardcochran@gmail.com, tariqt@nvidia.com,
        linux-rdma@vger.kernel.org, maxtram95@gmail.com,
        naveenm@marvell.com, bpf@vger.kernel.org,
        hariprasad.netdev@gmail.com
Subject: Re: [net-next Patch V4 3/4] octeontx2-pf: Refactor schedular queue
 alloc/free calls
Message-ID: <Y+Zdi48x+g/Ypre+@corigine.com>
References: <20230210111051.13654-1-hkelam@marvell.com>
 <20230210111051.13654-4-hkelam@marvell.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230210111051.13654-4-hkelam@marvell.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ioy45iJPLWGiHtdKaoJFbEKSYq1xDfzk7Esn39kNPN4UR4e4WVdGRifEYaXe?=
 =?us-ascii?Q?XwWN1/wS7DdHLjDvQ+Drn3KUDMtKS/qrSk1i8QjrnhsosDUbwyLHh/oPLZvr?=
 =?us-ascii?Q?UF8Es9T+73iLBeUoya0FvTJaqnQoi4g/2M86Ck1h9dYP0I7TO6gFyJn12RQl?=
 =?us-ascii?Q?G92BW8ilTkz2PA79Wz+YcbuvF9D+JYBztfEWIa4UXnEv/kigNhQsJpYqe6Xv?=
 =?us-ascii?Q?ROhtC5Dlqpo0KMw+BkSOTqgYIG4Z/0p3r763YkOJ11bBCfKz4GmlVc3GqRC3?=
 =?us-ascii?Q?miXeVyFF7iObv65zUnBFkGM/5eg5ZcaE48mIy5tENc6PcZoke/8FYQWkLsPh?=
 =?us-ascii?Q?g4Hk7v6V8RzyB5jpts/gGs41+Jka7CxaFYetcf+dOWbYAsfyqxsZOO+75asU?=
 =?us-ascii?Q?q/2SbC5/1c353mV5wyvy3oe2IK3NVtkL7aHfewaq9ekbxE6w+j+04TZhhVPS?=
 =?us-ascii?Q?vzD3ATler/lIsoyeiTv2JAzoyK7CKQU2OOqDis+5RnPqdQdZYAQS4nB6LFZO?=
 =?us-ascii?Q?4FAPiakVS1/QSLruxg+kpTZALdYT+xBrtOqn0+mnjxvejRB2PbcnWy2rGRSg?=
 =?us-ascii?Q?jMC+F8x0DV0QjPNczi2r+TxpwO25wpiz3d2GP6Wc3lYDt6oLnvXlOwUTCS6N?=
 =?us-ascii?Q?G9AMhPEPdWdYGP3ZbT9+1KVJ51P75eC+MbH1N0sW7DSzi5Wt3vvwxUsXhtPM?=
 =?us-ascii?Q?5skF7/tteaoY+kYPUZqtb/tRMkdBPab8kFywANBNVRIjdaMG/tqdJ7o7Oe+h?=
 =?us-ascii?Q?biVAmqAHnBtzGbx3+2nyyfSaZm08ZwebWFCpG2qM5/Eij/UMFmFltFv/ic/7?=
 =?us-ascii?Q?NXSPwA6IvIPbsGJRWD76cPPM4iRchx+SK8BG3dPanHb0SSd5SDuVGSCD5uVD?=
 =?us-ascii?Q?hdyr1YdFr1FeTE2U8wEy3H9/Z3jTxDNKoTwiL2VTefeyFQgaoqGuULvf5BqG?=
 =?us-ascii?Q?sirSmdIaxXsJGK0Ph13Iz9A5No8ZWo7iWOZGaHLg0eip73fqa3mApCMUOqQ8?=
 =?us-ascii?Q?jT4jyntKkT9hjPNv7LZ2/e4Qmx26Ok6GEy4fRKylLlwD955qKPMFzTRKQvrx?=
 =?us-ascii?Q?iefUgHvkJaL0Pm01Iu8BRloR8jIl/ggZ5HaQmpFq+S54hp7OhmOCLitSyF3C?=
 =?us-ascii?Q?ZqTfJn56Hd8Pjz1HhcfDTxtOwUQSuecv8c8wqzHg4EgTQfPXxa/+pVHwi6Wl?=
 =?us-ascii?Q?3G+VADHSd+raRPSuSMaLaxeoLgEpJSswb1blxwjT0ZWtBlmh3RTA6lkQwWdZ?=
 =?us-ascii?Q?h0khg+e5qk+uAEKp0F490yYGpliGFB9rJuRuvYoI70s5u1ExQmDM6uFxKnpp?=
 =?us-ascii?Q?aBApzPOl8EiERhj42UTM8RMirRpkr7T5DLMllhtXytD1H4KIrPeYyLTDxq1M?=
 =?us-ascii?Q?Fh/rZuts6gp5ei5iPv/GSgMb1FoRHTdipvupm4AH12HyPnqz+IaE/XVUjfMh?=
 =?us-ascii?Q?A8Vf9LsZO7oAmChW6hMfBQ5IIoS5VW9gheTDzE0aUKZykhcBmbExo1MeHYSt?=
 =?us-ascii?Q?q99ZtgrdT6P7idtja08kKpt/1KwKpWxIIS1EDbamzG8oNw7b+Mr54gFXLCfd?=
 =?us-ascii?Q?sJ4H6i+DcFkvWcYhhVhetsWKHLxTAI2NBQLpn+4HPwpVIoSFd/JeEm1Ma845?=
 =?us-ascii?Q?fHVHGi5lGI5NeE6djKCtVybjXk5XkF9EJKt5LhYl/puVsSHmf+Zer9j021bk?=
 =?us-ascii?Q?MrBopQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c3bffb91-5cb7-41c2-3276-08db0b787558
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2023 15:06:59.9675
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GhUDS9BN5d+nQE03gVfMKW5j7SsUJz5FKjv7LW33l9SHN2NFPq8N957a73ny/I6W/E4T0gcVjg+1Upm3yC/pa2SGdpg7dmpxZw5JD0rMIOM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR13MB6310
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Feb 10, 2023 at 04:40:50PM +0530, Hariprasad Kelam wrote:
> Multiple transmit scheduler queues can be configured at different
> levels to support traffic shaping and scheduling. But on txschq free
> requests, the transmit schedular config in hardware is not getting
> reset. This patch adds support to reset the stale config.
> 
> The txschq alloc response handler updates the default txschq
> array which is used to configure the transmit packet path from
> SMQ to TL2 levels. However, for new features such as QoS offload
> that requires it's own txschq queues, this handler is still
> invoked and results in undefined behavior. The code now handles
> txschq response in the mbox caller function.
> 
> Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
> Signed-off-by: Naveen Mamindlapalli <naveenm@marvell.com>
> Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>
> ---
>  .../ethernet/marvell/octeontx2/af/rvu_nix.c   | 45 +++++++++++++++++++
>  .../marvell/octeontx2/nic/otx2_common.c       | 36 ++++++++-------
>  .../ethernet/marvell/octeontx2/nic/otx2_pf.c  |  4 --
>  .../ethernet/marvell/octeontx2/nic/otx2_vf.c  |  4 --
>  4 files changed, 64 insertions(+), 25 deletions(-)

...

> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
> index 73c8d36b6e12..4cb3fab8baae 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
> @@ -716,7 +716,8 @@ EXPORT_SYMBOL(otx2_smq_flush);
>  int otx2_txsch_alloc(struct otx2_nic *pfvf)
>  {
>  	struct nix_txsch_alloc_req *req;
> -	int lvl;
> +	struct nix_txsch_alloc_rsp *rsp;
> +	int lvl, schq, rc;
>  
>  	/* Get memory to put this msg */
>  	req = otx2_mbox_alloc_msg_nix_txsch_alloc(&pfvf->mbox);
> @@ -726,8 +727,24 @@ int otx2_txsch_alloc(struct otx2_nic *pfvf)
>  	/* Request one schq per level */
>  	for (lvl = 0; lvl < NIX_TXSCH_LVL_CNT; lvl++)
>  		req->schq[lvl] = 1;
> +	rc = otx2_sync_mbox_msg(&pfvf->mbox);
> +	if (rc)
> +		return rc;
>  
> -	return otx2_sync_mbox_msg(&pfvf->mbox);
> +	rsp = (struct nix_txsch_alloc_rsp *)
> +	      otx2_mbox_get_rsp(&pfvf->mbox.mbox, 0, &req->hdr);
> +	if (IS_ERR(rsp))
> +		return PTR_ERR(rsp);
> +
> +	/* Setup transmit scheduler list */
> +	for (lvl = 0; lvl < NIX_TXSCH_LVL_CNT; lvl++)
> +		for (schq = 0; schq < rsp->schq[lvl]; schq++)
> +			pfvf->hw.txschq_list[lvl][schq] =
> +				rsp->schq_list[lvl][schq];
> +
> +	pfvf->hw.txschq_link_cfg_lvl     = rsp->link_cfg_lvl;

nit: extra whitespace before '='

> +
> +	return 0;
>  }