Date:   Fri, 10 Feb 2023 16:13:04 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Hariprasad Kelam <hkelam@marvell.com>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com,
        edumazet@google.com, sgoutham@marvell.com, lcherian@marvell.com,
        gakula@marvell.com, jerinj@marvell.com, sbhatta@marvell.com,
        jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
        saeedm@nvidia.com, richardcochran@gmail.com, tariqt@nvidia.com,
        linux-rdma@vger.kernel.org, maxtram95@gmail.com,
        naveenm@marvell.com, bpf@vger.kernel.org,
        hariprasad.netdev@gmail.com
Subject: Re: [net-next Patch V4 2/4] octeontx2-pf: qos send queues management
Message-ID: <Y+ZfAC/5NjiuPfQE@corigine.com>
References: <20230210111051.13654-1-hkelam@marvell.com>
 <20230210111051.13654-3-hkelam@marvell.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230210111051.13654-3-hkelam@marvell.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PftRIJIVoCai694UG6ZTeOWnuDD+OJo02E5SkzP3RjccBuG8xVbhpHiPaJu4?=
 =?us-ascii?Q?3r7TJF5c9Z81O5uGCXbchEhA9/6s2JeGQyn4zFUI58jYYb6p/TtsFhqPCRRE?=
 =?us-ascii?Q?Zo6ia2NpTDBjSAsbBtIJwrOa36zDLTf0vpjXlvQ0m6NrbrI742yEM6tJ6XkV?=
 =?us-ascii?Q?0tujPTh26eNwxKYtMWkHcVAm0Gux05oVjJhWL9ZbjHbawTDNMPtlZO8g74us?=
 =?us-ascii?Q?yEs2vVo6sdaUcZA3X3EtyAyIb/G9bdxbk4PJT8+e1+mF2ntITd6P6T2oIjzn?=
 =?us-ascii?Q?9Hglmt6nQsAn8UGCDzyeIePKm3fhsOTI+mR9SETGpjVmaydhnZNuPKGbcpvx?=
 =?us-ascii?Q?3HsvWoRpSwkpP3UMGWLlqZ+H9WAoFOXz9hLodmT/8CHpxuyNMVdw8EPPNMS0?=
 =?us-ascii?Q?K6DB8dhNbVG/PZNYLzrxFn/M5nZlqWRlOgQvD90lwTcmNCCGwc+USHv0JJ68?=
 =?us-ascii?Q?r37yejuN+XwiLJZtPhr9ZmndpZ0Y4aAQ+9fMQGhkz9JD/1viO8F3g9fLAjB7?=
 =?us-ascii?Q?8AxG4Qch4nRFSNy7fMk+i4wVJabSHGsG2qnXDDS4hbQPYC2VsEWNGWzMJJQO?=
 =?us-ascii?Q?Dz7wD1FRFQodGcteuq/k0f6ePXgdgVCkKdKbur6FV1kiS89Hvhuk8K2Ku3Fl?=
 =?us-ascii?Q?yVBFA7D5Zdv9AXxaOqL3T3yVxeYmTdbGrE2sJxml516B45LEf8eh2G5EcfRY?=
 =?us-ascii?Q?du7koaAgqkfc9gr+L1AbZE0OGkN4BaKXuZum0x/XBAH3bk4Jborl9IlEk4M8?=
 =?us-ascii?Q?KKtRCqEkug1bM8Qp7zgYQ8z+ceLyzduZuXcQhowrrJxLTNRi18X6TwXp6kVT?=
 =?us-ascii?Q?gJgwVwWpPnKbCVBvV1iNq92S/DJZbBp/IOKU4wjDx3Xx2EA9GZhnZycdmzr5?=
 =?us-ascii?Q?1eFXAM+0vBEaFLBmNkeg4us5NH8/5EUs9zqJhPVKHYEFqvbxCsjvmCpMllS4?=
 =?us-ascii?Q?uGy/iRO7EmmrxWw5EgmuY3tF/uOgznN6dxrCPbOjUcvYRUpIo02RT9pHgSHO?=
 =?us-ascii?Q?fqMmFL+QQNCm6JkkRISqFs+Vy+mg4oU+vVp+jfT7qdyoqjK0OjVvQZ4/o/Go?=
 =?us-ascii?Q?0Qs1r1VdBH4vE9j1t3P45piafmnmJTH6Vo6CUOjMg2NagCxQ2KRFRgswQbHv?=
 =?us-ascii?Q?qZRKln4mCFLE9ByZgcZK/fMSl3wl32l19kMIaDGxnQs8nEY1fVuB+8Ktjw23?=
 =?us-ascii?Q?yScbcNBCv9b4UQOri3+KpRpSefSOPPat64oRxgNn8UxsvKpgujFf9krxJM4A?=
 =?us-ascii?Q?llL8YIcw2q30BOt8JuseA0rG3A85UxkFBhaAl1YjXJyvL6br5VNWASooPvUR?=
 =?us-ascii?Q?M8NLOC8a+LAdNEWdd4Nm+/XFWPapzxn6Ii+1SYRHzaRH6uGfpQ5l+8ckEdQ9?=
 =?us-ascii?Q?qiP/QqEsQsV2odVXOuo67aRmgMj3bnRvInZT/gxJ4TQ7A01F0oykVT9C+eks?=
 =?us-ascii?Q?gelQkrjOlA7b2MUVTuy57F2mNPkJXz4jhtYKEW1KP3VDtoUFDGFFj2xleLR6?=
 =?us-ascii?Q?mXN9JaDC4Epwi3LhnO3peR98Ua4BFNoiGNMWMd1/xJKfU+Z7zNgJnZrifOiU?=
 =?us-ascii?Q?q77nbaTrFf95kf1p1PrnV6r3X6YY8bacGSEno79gbNyb6TR1OeI6tU9nKi32?=
 =?us-ascii?Q?lO3Aly9wzZS/uMpJpkssFRS5aIqepWTprRmoLfIvBb3ovI/yLDeFiyFHiHvI?=
 =?us-ascii?Q?H0OJtw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2e616a76-6f94-479a-960a-08db0b79533c
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2023 15:13:12.1453
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VAV3g9FUMrBY13BVoGM5yRxnAeJRONUk0Tkn1qHMyvxBis5pHc6YNmxmMGxM1SIlgJGK9IOzedpwnXBG9wzR7XeVl4qlaklHoz9uwZiFxYw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR13MB4496
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Feb 10, 2023 at 04:40:49PM +0530, Hariprasad Kelam wrote:
> From: Subbaraya Sundeep <sbhatta@marvell.com>
> 
> Current implementation is such that the number of Send queues (SQs)
> are decided on the device probe which is equal to the number of online
> cpus. These SQs are allocated and deallocated in interface open and c
> lose calls respectively.
> 
> This patch defines new APIs for initializing and deinitializing Send
> queues dynamically and allocates more number of transmit queues for
> QOS feature.
> 
> Signed-off-by: Subbaraya Sundeep <sbhatta@marvell.com>
> Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
> Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>
> ---
>  .../marvell/octeontx2/af/rvu_debugfs.c        |   5 +
>  .../ethernet/marvell/octeontx2/nic/Makefile   |   2 +-
>  .../marvell/octeontx2/nic/otx2_common.c       |  40 ++-
>  .../marvell/octeontx2/nic/otx2_common.h       |  29 +-
>  .../ethernet/marvell/octeontx2/nic/otx2_pf.c  |  51 ++-
>  .../marvell/octeontx2/nic/otx2_txrx.c         |  25 +-
>  .../marvell/octeontx2/nic/otx2_txrx.h         |   3 +-
>  .../ethernet/marvell/octeontx2/nic/otx2_vf.c  |   9 +-
>  .../net/ethernet/marvell/octeontx2/nic/qos.h  |  19 ++
>  .../ethernet/marvell/octeontx2/nic/qos_sq.c   | 290 ++++++++++++++++++
>  10 files changed, 430 insertions(+), 43 deletions(-)
>  create mode 100644 drivers/net/ethernet/marvell/octeontx2/nic/qos.h
>  create mode 100644 drivers/net/ethernet/marvell/octeontx2/nic/qos_sq.c

nit: this patch is a little long

> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c
> index ef10aef3cda0..050be13dfa46 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c
> @@ -463,12 +463,14 @@ static int otx2_tx_napi_handler(struct otx2_nic *pfvf,
>  			break;
>  		}
>  
> -		if (cq->cq_type == CQ_XDP) {
> +		qidx = cq->cq_idx - pfvf->hw.rx_queues;
> +
> +		if (cq->cq_type == CQ_XDP)
>  			otx2_xdp_snd_pkt_handler(pfvf, sq, cqe);
> -		} else {
> -			otx2_snd_pkt_handler(pfvf, cq, sq, cqe, budget,
> -					     &tx_pkts, &tx_bytes);
> -		}
> +		else
> +			otx2_snd_pkt_handler(pfvf, cq, &pfvf->qset.sq[qidx],
> +					     cqe, budget, &tx_pkts, &tx_bytes);
> +
>  

nit: there are now two blank lines here

>  		cqe->hdr.cqe_type = NIX_XQE_TYPE_INVALID;
>  		processed_cqe++;