MIME-Version: 1.0
References: <20230123220500.21077-1-kirill.shutemov@linux.intel.com> <20230123220500.21077-7-kirill.shutemov@linux.intel.com>
In-Reply-To: <20230123220500.21077-7-kirill.shutemov@linux.intel.com>
From:   Alexander Potapenko <glider@google.com>
Date:   Fri, 10 Feb 2023 16:18:56 +0100
Message-ID: <CAG_fn=UVa=x+idoHoHjfe+ASsT30aQGHLW3KkEgfmsOcwh_fQA@mail.gmail.com>
Subject: Re: [PATCHv15 06/17] x86/uaccess: Provide untagged_addr() and remove
 tags before address check
To:     "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc:     Dave Hansen <dave.hansen@linux.intel.com>,
        Andy Lutomirski <luto@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, x86@kernel.org,
        Kostya Serebryany <kcc@google.com>,
        Andrey Ryabinin <ryabinin.a.a@gmail.com>,
        Andrey Konovalov <andreyknvl@gmail.com>,
        Taras Madan <tarasmadan@google.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        "H . J . Lu" <hjl.tools@gmail.com>,
        Andi Kleen <ak@linux.intel.com>,
        Rick Edgecombe <rick.p.edgecombe@intel.com>,
        Bharata B Rao <bharata@amd.com>,
        Jacob Pan <jacob.jun.pan@linux.intel.com>,
        Ashok Raj <ashok.raj@intel.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

> +#define untagged_addr_remote(mm, addr) ({                              \
> +       u64 __addr = (__force u64)(addr);                               \
> +       mmap_assert_locked(mm);                                         \
> +       __addr = __untagged_addr(__addr, (mm)->context.untag_mask);     \
> +       (__force __typeof__(addr))__addr;                               \
> +})
> +
> +#else
> +#define untagged_addr(addr)    (addr)
Could you please use tabs for indentation here?