Message-ID: <c64bb7b8-ab50-78c3-bb56-820ce96a1e14@amd.com>
Date:   Fri, 10 Feb 2023 10:22:00 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH] drm/amd/display: Remove duplicate/repeating expression
Content-Language: en-US
To:     Deepak R Varma <drv@mailo.com>, Leo Li <sunpeng.li@amd.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc:     Saurabh Singh Sengar <ssengar@microsoft.com>,
        Praveen Kumar <kumarpraveen@linux.microsoft.com>
References: <Y+YYZ4SbMQBcpTZP@ubun2204.myguest.virtualbox.org>
From:   Harry Wentland <harry.wentland@amd.com>
In-Reply-To: <Y+YYZ4SbMQBcpTZP@ubun2204.myguest.virtualbox.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bTRzck1US2lsNUpQZm4yRDRHTkJiYUJpTlU5YkpXV2xJSTF3VUJPRU01Z0hZ?=
 =?utf-8?B?UjUwZ3RrZ09lL0VqdU0yVXc1cUEya2VYTGd4RmhjdGV0aUZqOHZTRWRoSFdP?=
 =?utf-8?B?ckhUQkRCUFJEZHpiMUJKdkpranR1N2ZtZkY0clo0Q0M4RWZkeXNRUXo4VTJv?=
 =?utf-8?B?QkIxd1Y5OVJtTDdmZUoyMjNzWHF6M3FNQWVPVnhSQzJxYkZNTFFZK01jWlJ1?=
 =?utf-8?B?bmpSeHhXY0VCOGpNSVd4ZkxZT0pqTlI2ZWVwdXQ3K0tNSzgxMXRjTzdpREtF?=
 =?utf-8?B?WDRxWHVybXZxSWFWS1lsS1pxSTdjSGdheWJNUjZUNDFzWXZqTUN6Mm5lb01p?=
 =?utf-8?B?ZVNFVFNiUmVKN3FaNlF1ZlJRTWU5MTMrZHNNSCs4K28wSjNMK0c3MmpsaUdB?=
 =?utf-8?B?ZjgrQWErWEJyMW93akQ2WHNCNzQ2SHV6aW8wU05ISFVKREhwa2E5N3Z2UEJn?=
 =?utf-8?B?dkhkLzNQemJJMkFsNit2dVk1MDFjZk5oQnA2eVh2NXpEa3JtbTRUZGVnVnpn?=
 =?utf-8?B?VlIvQTBVOThnSDlCYjkvK0xOc0p0ejU2ZUwrOFQ3VE04c3RBQUM5dzhZazBh?=
 =?utf-8?B?QkpJQlcwZUFwZ0JZbm5RQ2tIV2FSSnhXeEFUWnpWSVlTeUp6UTg4ZjNhUDJq?=
 =?utf-8?B?VXUwTW5HazF4aXEwK2IxTjlpOTUwSDhnNzIrVmtSMFNSQjJIOXMyNTQrR1RR?=
 =?utf-8?B?OXJYRVpJYTE4QTB4ZkhXOC9pMU9RY3MrRkFzbnJBOUEvWVZmLzRvSHdrR3A0?=
 =?utf-8?B?L0YvemxrRDV0SFhCamJWakRKZkFQSXgvZlgxbGVHZ2FGT2F1eE9SR3RXNFZs?=
 =?utf-8?B?UlRTVllZZDNzb0JPQmhUREFPVjZLWXpqWWl6ZE1Pd2J0UUozMVlLRnJFaVRm?=
 =?utf-8?B?RzNRL0lWcTY4WGxNUytlTzNkTUVrOXNSY3V2bkNlazNUYUZDS1NhWHZDazdS?=
 =?utf-8?B?bWdTREdtTERMNTNuaVlwdDdWVERscjFZK3VVUmdNZDZ3ZTZIR3J3NHQrLzFK?=
 =?utf-8?B?OHdhMm1aM0drQk5wQ05KaWYwQnRnVktUK1h5ZVUwV0RueXYveUZ1VlhjVzAz?=
 =?utf-8?B?U0tueWFkcGN6bG1NbHVpdVdrSzNISTRTYVY1ZmdsbjYzRy8rM0ZOeWhkQlFD?=
 =?utf-8?B?K1ZjbVR6UWYvVEJaM09oNnl5US9pdEpKVjhWRm13N3RGdno4Yk1EZVhTTEx0?=
 =?utf-8?B?NWtPNklWdVVOSTNCNjYwdCtxSVpCVTRHdVZVZGdGcXpYd05qYTFLb0grRksy?=
 =?utf-8?B?Y3NwR01uVnFvSEZXWEJ1dXpIa0o5WDFpd1dJajZSMFJxeWhMbC81NjhJZElz?=
 =?utf-8?B?aFRSaXBXTFcwQXBnUnh0UTQ5NTRlOTlmd2VOYzhuRmJLbUpkV1NqNHNmeVFC?=
 =?utf-8?B?OWpzYkZaR2s0QnRiR1EvMmJKeDlpSVh5S0ExandUbEFPV0Q4cURXQTAvWnVI?=
 =?utf-8?B?N0JwQStNZVA1aW56UUZUWFVuUWJTakFxc3U4NTdFQVk2dEVjMFQyclhXOHp4?=
 =?utf-8?B?SldhMHRsSzNTcmFuT2FSYjg2OWl5b2hJUE1uN0RubGMxYUduL1hvNG9veitx?=
 =?utf-8?B?dW1Eb2p4Q0hxTTE4b2xCQ3dOSU9BODdDSjVWamRYREtFNGIybDVtWmk1SnFB?=
 =?utf-8?B?MGVPeVFRaHd5MGtGa1pFNUNqaGtGSmxJOGxCWGNpRTlrK0ZIcmJ0NkZnR29x?=
 =?utf-8?B?NW9xRllKdWNOcHpjR0lRek4vNmlFK0QvSVZJVG1tN0hITVFWTFpja3lOTDlH?=
 =?utf-8?B?N1owMklqTmlYcWtBRlJJcVFlWWRDZkVPTk9vRnMrMXZsckJhM21KOENvRjEw?=
 =?utf-8?B?ek9CY1RDV0orcTNydGFQNm1haU16TmhLSHJacnI5Uzg3MEhlbUQxcUh0WEJK?=
 =?utf-8?B?Y05QTEVGSFNMcGNXcWRFUUZ4TU1INU1RejUyT0kwL0tXTSt5MmVsRllZQ3Ji?=
 =?utf-8?B?OU9QbHFIQUtxckpvUUlTQWM4LzdpUnBmK2hmak5wN1pQRUNFZG1veW1QTVhS?=
 =?utf-8?B?OHYwTVN6T3ZXcFZHbkFYY0Y2ZzQzYVBzbUZlTlZkL3NuZjRCTDduUjNJSkFI?=
 =?utf-8?B?MlhwSWgxcVEyYTdOeGczT29Nc0pmR0ZMZW92dTU2Z2IyVmM0R0ZPbWZLY3l4?=
 =?utf-8?Q?I0dc0aEoYUHXNMNjphv4D2YWb?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 59cae427-a75f-4d59-73dd-08db0b7a9130
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5427.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2023 15:22:05.5968
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: K5snxdU4WV4rZZcQv6joEMWl2xEVTfzY20jGs3zzb7oCTbxzalFIYCzVw19B/PUohePiPU5x7pSuq+DUI6HDXg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7411
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2/10/23 05:11, Deepak R Varma wrote:
> Remove duplicate or repeating expressions in the if condition
> evaluation. Issue identified using doubletest.cocci Coccinelle semantic
> patch.
> 
> Signed-off-by: Deepak R Varma <drv@mailo.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>  .../gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c b/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c
> index 61ee9ba063a7..6576b897a512 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c
> @@ -51,7 +51,7 @@ static bool CalculateBytePerPixelAnd256BBlockSizes(
>  		*BytePerPixelDETC = 0;
>  		*BytePerPixelY = 4;
>  		*BytePerPixelC = 0;
> -	} else if (SourcePixelFormat == dm_444_16 || SourcePixelFormat == dm_444_16) {
> +	} else if (SourcePixelFormat == dm_444_16) {
>  		*BytePerPixelDETY = 2;
>  		*BytePerPixelDETC = 0;
>  		*BytePerPixelY = 2;