Message-ID: <826cc9912f56dddd3b0bccdaf742167d5006c669.camel@gmail.com>
Subject: Re: [PATCH net-next v7 5/9] net: phy: add
 genphy_c45_ethtool_get/set_eee() support
From:   Alexander H Duyck <alexander.duyck@gmail.com>
To:     Oleksij Rempel <o.rempel@pengutronix.de>,
        Woojung Huh <woojung.huh@microchip.com>,
        UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Wei Fang <wei.fang@nxp.com>,
        Heiner Kallweit <hkallweit1@gmail.com>
Cc:     kernel@pengutronix.de, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, Arun.Ramadoss@microchip.com
Date:   Fri, 10 Feb 2023 07:43:51 -0800
In-Reply-To: <20230209095113.364524-6-o.rempel@pengutronix.de>
References: <20230209095113.364524-1-o.rempel@pengutronix.de>
         <20230209095113.364524-6-o.rempel@pengutronix.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2023-02-09 at 10:51 +0100, Oleksij Rempel wrote:
> Add replacement for phy_ethtool_get/set_eee() functions.
>=20
> Current phy_ethtool_get/set_eee() implementation is great and it is
> possible to make it even better:
> - this functionality is for devices implementing parts of IEEE 802.3
>   specification beyond Clause 22. The better place for this code is
>   phy-c45.c
> - currently it is able to do read/write operations on PHYs with
>   different abilities to not existing registers. It is better to
>   use stored supported_eee abilities to avoid false read/write
>   operations.
> - the eee_active detection will provide wrong results on not supported
>   link modes. It is better to validate speed/duplex properties against
>   supported EEE link modes.
> - it is able to support only limited amount of link modes. We have more
>   EEE link modes...
>=20
> By refactoring this code I address most of this point except of the last
> one. Adding additional EEE link modes will need more work.
>=20
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  drivers/net/phy/phy-c45.c | 238 ++++++++++++++++++++++++++++++++++++++
>  include/linux/mdio.h      |  58 ++++++++++
>  include/linux/phy.h       |   7 ++
>  include/uapi/linux/mdio.h |   8 ++
>  4 files changed, 311 insertions(+)
>=20
>=20

<...>

> diff --git a/include/linux/mdio.h b/include/linux/mdio.h
> index e75583f5d967..e3568e44efd0 100644
> --- a/include/linux/mdio.h
> +++ b/include/linux/mdio.h
> @@ -428,6 +428,64 @@ static inline void mii_eee_cap1_mod_linkmode_t(unsig=
ned long *adv, u32 val)
>  			 adv, val & MDIO_EEE_10GKR);
>  }
> =20
> +/**
> + * mii_eee_cap1_mod_linkmode_t
> + * @adv: the linkmode advertisement settings
> + *
> + * A function that translates linkmode to value for IEEE 802.3-2018 45.2=
.7.13
> + * "EEE advertisement 1" register (7.60)
> + */
> +static inline u32 linkmode_to_mii_eee_cap1_t(unsigned long *adv)

So the function comments don't match the name for the function. Perhaps
a copy/paste error? Otherwise the rest of the function description
looks fine.

> +{
> +	u32 result =3D 0;
> +
> +	if (linkmode_test_bit(ETHTOOL_LINK_MODE_100baseT_Full_BIT, adv))
> +		result |=3D MDIO_EEE_100TX;
> +	if (linkmode_test_bit(ETHTOOL_LINK_MODE_1000baseT_Full_BIT, adv))
> +		result |=3D MDIO_EEE_1000T;
> +	if (linkmode_test_bit(ETHTOOL_LINK_MODE_10000baseT_Full_BIT, adv))
> +		result |=3D MDIO_EEE_10GT;
> +	if (linkmode_test_bit(ETHTOOL_LINK_MODE_1000baseKX_Full_BIT, adv))
> +		result |=3D MDIO_EEE_1000KX;
> +	if (linkmode_test_bit(ETHTOOL_LINK_MODE_10000baseKX4_Full_BIT, adv))
> +		result |=3D MDIO_EEE_10GKX4;
> +	if (linkmode_test_bit(ETHTOOL_LINK_MODE_10000baseKR_Full_BIT, adv))
> +		result |=3D MDIO_EEE_10GKR;
> +
> +	return result;
> +}
> +