From:   Nick Alcock <nick.alcock@oracle.com>
To:     mcgrof@kernel.org
Cc:     linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-pci@vger.kernel.org
Subject: [PATCH 2/8] kbuild, PCI: mobiveil: comment out MODULE_LICENSE in non-modules
Date:   Fri, 10 Feb 2023 16:47:43 +0000
Message-Id: <20230210164749.368998-3-nick.alcock@oracle.com>
In-Reply-To: <20230210164749.368998-1-nick.alcock@oracle.com>
References: <20230210164749.368998-1-nick.alcock@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nhSWxxNUPfqHvv8mHeO/dR3cDERUilhdD4ipnSQVsryT4llJdd0qH/XJtn+D?=
 =?us-ascii?Q?ND7v0Xsa2tU0rn8omN6iBsMjzSPrUeG9XzFJqz4q6xqV19xzRTvXtSA4VF1S?=
 =?us-ascii?Q?kRkrJA7/9w5aekPi+tGJAS8Xdr0FiM1ualOVxi2LX6u6r+tmTSLei2Cxqycb?=
 =?us-ascii?Q?54XBIXwOUItYNEW7GLiam6SQVPL712CUpeRWZUp50t5Md7U7aa46jlBGTUQa?=
 =?us-ascii?Q?tSmEiqp70F/ZqPTlx93Wox3PO65cuIvEhWc+mg3K3YrC0NosaEXzNhDj5sR6?=
 =?us-ascii?Q?E/vHTLjDnfG8nTNhMFgnVd6VNUdIPRWO1RWdhb3r0l4KYmm25BV2MT1yxwsT?=
 =?us-ascii?Q?eS0EyCY7lGW0NPE+FCfvegAJ6brUvvooEmGB28VWU2qpbVQZdYtyc5QehLO3?=
 =?us-ascii?Q?zvrPNWw8Wzh2glHLYUplELEarZzSS0h7wGw6d8w4axifBwlIzA0YXwhlGX1g?=
 =?us-ascii?Q?3+l2kgAn/n93HihHO9rcdkR0HAf6qTG5o/QzsIG9BbZomYkIbm9XztJr+Io0?=
 =?us-ascii?Q?KkvIOWhFQA8xNYWHp9VnVr82ZUUA7vrd/uDsIjQZdYZvCSpFmpCI7yhFCQFB?=
 =?us-ascii?Q?yg6e74n1ne+6V9JNTKwUCR5ScsMnFOV4Ps6hS8BT4Stc1rzL3dUeLfV5DigL?=
 =?us-ascii?Q?beNXA3rPv3lJVf0e1oACCUBjbh+bqEZ2qiZp3kcCPdHdzPhRPyBMtXNtIWms?=
 =?us-ascii?Q?mw6/D4pDNdIJkbuIsEFsImx0nhQDUQsRcwTdzX2P84A/JuZQxgu9dAIx4+VV?=
 =?us-ascii?Q?D4w7j9od6RbGdZ//mV5d7dBVQw6kr4r4oV0CVyVg/WEay3zbBOItLGktlbkr?=
 =?us-ascii?Q?z1dZGLQHsCNcNvbiz+oZjlbz+krbCRw9jgOlaUHhGsEGUNFxFvDYBQp2jzMv?=
 =?us-ascii?Q?mhp3BpC4ik/EAC3mqsrmI57Q63CSCWBrnTcouXvqVpkWFGqI1RZX+EP1TDRw?=
 =?us-ascii?Q?eVdk8lKy7iaCiIiwsFeo4+l1olvYvZgFy//BafKSinf0zDqe+o2KnjAqBNK6?=
 =?us-ascii?Q?thK6RXbmiDPr1ywIukStRcK4CLL5Tmd4eckBm+iDp4zSPq0I7DOF4Amw5/2Z?=
 =?us-ascii?Q?WpaDAKik/f0IvcqVTEeO/cQMOyeEy3u8d8xl21wNRvnLY2NS06HrL8TEK2Vp?=
 =?us-ascii?Q?bagjQDUcK7jlVqTawRhTf6Irq7mLC8KrNCnb+1L1E721Hkmw6ieHJV+9/8Nd?=
 =?us-ascii?Q?A2BJCZr+BGpjmV2B/9a1mMn7i4ka3KWrm77BaVPcVHmvA21Y+f9qhBvrx2XB?=
 =?us-ascii?Q?/HldLlnrkjhlnafEfpNnNi/m4IQb5+9pDB9H9Cz4xniZ/V1bO0JmkMvATL/R?=
 =?us-ascii?Q?/BOiyeWg15egqHyAa4R4SpbR6vvDsg71iJETyR8iPDqT67bAkXXXJOa43biI?=
 =?us-ascii?Q?seSl+2XM5Bw1djbHCE3cFM1Pq6l9zZHqO2JP5OF5qz/RLLhuAfqBZnyIcw9N?=
 =?us-ascii?Q?EpRr3CdU5EzEQPhJyU5LtQk8V4PS7PyxP6RupTvIrJZ6ipBp4R4KNmq0mkHp?=
 =?us-ascii?Q?NYQUt1Yq/d4qA9reJI40OSO4+YXpyewLYMUQt0aPysxxGcwzU1IsMctjYK7n?=
 =?us-ascii?Q?Ia+se0NoFVWCAbUnR1yjVM3qiF/nzGReLUFZfeVpV/lhywFyXJ0sMRTDNjc/?=
 =?us-ascii?Q?vg=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: PTPhDHw336Al2KDrZg5cCiEQCF7oEpMu819VE3ImbOzUMkhByRa7HKrK4nKib8v3SRUBT6fOIsOmlcJsCP6AhR7jcd669vR5k/rpz+3bsVl/P+FenFYGjtkLEQGcRlZ7dqkGy50yXM0HcfTu5eW1/Xfs6MEotxqjG+S3UzLxN7tnPinwMoOydPnQzhrjdcq3oLcxf6TDRYIEsQHDiw+WgLrxEQWa3XoKvz78VrblVHoxf1uTSDFqRYNh4E7w2L9Imn+qr/aEsXfgIY0Vo6JLPeePPD6WGWZNOO+xhm6RiXX+7lduQGhzpK6EaX6FcjR6i5PLs5sgfJjnAlKXpFIuKyxUmqYWqIBP+HZ56NQ3SShiLQy9to5xoS3oh6kc88PNcdnSaYPheGbMum0PE+MyYkclkbAT9CbcIwygQtR48t91NfyiONVXa6g6/lz+lasPBEgER59lHKxMYwfCgMqwkGOcLmMbgKyu/Tz6xwCQ0IHDdQuAPFQ4NNWIb1m+k5FD+WvJOL5FDnmKlWmWZ06JilqjsrqyyCqWUbqodBLZ/dDOrErMo/OZ1gaGvdNUSfeUfIey7Uj52oqlBc7yTduCm3Tzja/rX0f1tGbjxAWWQNXxq16G67NBJIyABkRnZV5Giz4PciqbuW5TBLZTMoI57yx53lsCY8TQS5XH6yPXH5JVl+2VdjqgYhMChmlL4uTyUAHzTl61Bj9vjhgXJxY1GbhTJIRqWpcGQYfBdomvID8NTELcTlwRe/yBd4OBy1iI3asBBN1+4tip3S0SxMRCPxl9fCQU91qxBjh99//bWyU=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eb25ac6b-7f99-4da0-e115-08db0b8a4e6e
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB6798.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2023 17:14:45.3589
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ooKi1BlpkKkRXWm2+pePftmZNf0A5XouUAPNsJLZe/VyO6e/dLsCYA/FYYkF44d3EG5ZGCTZWF4UxxNnWQmcDg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4750
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22
 definitions=2023-02-10_11,2023-02-09_03,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 adultscore=0
 malwarescore=0 mlxscore=0 phishscore=0 spamscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2302100144
X-Proofpoint-GUID: P3QtUEdG5pTlXKlA21vTUX7XJAXpDDU3
X-Proofpoint-ORIG-GUID: P3QtUEdG5pTlXKlA21vTUX7XJAXpDDU3
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.

So comment out all uses of MODULE_LICENSE that are not in real modules
(the license declaration is left in as documentation).

Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-pci@vger.kernel.org
---
 drivers/pci/controller/mobiveil/pcie-mobiveil-plat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/mobiveil/pcie-mobiveil-plat.c b/drivers/pci/controller/mobiveil/pcie-mobiveil-plat.c
index f6fcd95c2bf5..d16e4f5c726e 100644
--- a/drivers/pci/controller/mobiveil/pcie-mobiveil-plat.c
+++ b/drivers/pci/controller/mobiveil/pcie-mobiveil-plat.c
@@ -56,6 +56,6 @@ static struct platform_driver mobiveil_pcie_driver = {
 
 builtin_platform_driver(mobiveil_pcie_driver);
 
-MODULE_LICENSE("GPL v2");
+/* MODULE_LICENSE("GPL v2"); */
 MODULE_DESCRIPTION("Mobiveil PCIe host controller driver");
 MODULE_AUTHOR("Subrahmanya Lingappa <l.subrahmanya@mobiveil.co.in>");
-- 
2.39.1.268.g9de2f9a303