From:   Nick Alcock <nick.alcock@oracle.com>
To:     mcgrof@kernel.org
Cc:     linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
        Philipp Zabel <p.zabel@pengutronix.de>,
        linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org
Subject: [PATCH 3/8] kbuild, ARM: tegra: comment out MODULE_LICENSE in non-modules
Date:   Fri, 10 Feb 2023 16:47:44 +0000
Message-Id: <20230210164749.368998-4-nick.alcock@oracle.com>
In-Reply-To: <20230210164749.368998-1-nick.alcock@oracle.com>
References: <20230210164749.368998-1-nick.alcock@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0tz//CR4436HU3STDCx7j8ZwWXh0WoUz/P889N0P2GVo3Bb4mL3rAy99vXKd?=
 =?us-ascii?Q?AQYKSSYPjne8TMKznSuSaCLgsVyE415LHI5O5reWYDfGMjshTjayxr4v5MkY?=
 =?us-ascii?Q?jZID6d1CkkD4ACHI2fmrlXDcAkc43Pcr/f8o7XQIU/gjjDk/6PlZwW5ERMfQ?=
 =?us-ascii?Q?hRjb7vFTGnKWGBxY/Pbi8/n2X23f7yvRlk2br6PqtxRBWPhYpPzgq7Cfpjd0?=
 =?us-ascii?Q?wXKTj5rHU/TBB67jjjRco5qPUZKButN00p2InqEk5li7zmM9Viiwy5btQR5j?=
 =?us-ascii?Q?eO/Igq7NSmOf0hWlZSvpMMHZt0nsaiAzgaPQTCfpSuiUriW7oNqg7xpLJB43?=
 =?us-ascii?Q?HpcTwgGpdWiubsmk5qYIE85X7ZpaLiXXVeOBCP12Iy6PvLw1yU3E8TxL+B1q?=
 =?us-ascii?Q?hjeP6bhoUocPRsbN3l/e7ygWVwPcsh+HF+d4xrltgBu1miVomq0/Fy/vh8QZ?=
 =?us-ascii?Q?HhaXb1uMRPx+U2zkbPOPHIjeUYdlg2+/pO/4fbwwOzKct0twC8iKd/JE/t72?=
 =?us-ascii?Q?0f1op+DcY+D42Vu/0SoQGAPlCE6MaYrQTaYIqxT4hhC445EH0zB/GElgleBo?=
 =?us-ascii?Q?ZWSgpvLCkk4Qy0peoM92UCVQY+pWE6fIpMDJ8w1iaZVKdPUyIb6m0ch7PmEb?=
 =?us-ascii?Q?4Z6JaIY3NjoS+BnWJtvb1l1eLsomLvGSNUgFTueDtxd6buY/WuBzssL3+Rtz?=
 =?us-ascii?Q?LxBjdlgX/RXjgnlxbDl3Ej2oIWs8DNkOy5wqaICDzVWuG4XYpqlG9rNSAsWx?=
 =?us-ascii?Q?Aako4WAYJBP0eNXWTjH86+8dHBBVilgBSIhuPFJAm3zKjKQWIHN6md/lpxib?=
 =?us-ascii?Q?FdZeqa1w+wMlRDiubo+/6YrSgVhOiOpsY+uaLFPT4CAVmckHFNO6NOgOY+Tw?=
 =?us-ascii?Q?ttOYPirMfgtxy1VHQnw91MB72bEaeofMUtkjoS9GBZLnH72YpggSiqFT+i9z?=
 =?us-ascii?Q?wyhQGAos8dK6kg05P9Pqfjpz4umOKJ8jNnn5T1omooXZEQThkGdjpQ4ydq3n?=
 =?us-ascii?Q?ZC/Fanq5eGQCSgeEQTy6+9Ra1Mc2Z7mcRL0gvPeSrI1+4pDyy3CEY+GMtR2E?=
 =?us-ascii?Q?5RwXwb0L2DDPs7/mMHrGmKi4HxqetDktuwG6A1tClNs6wnpsQDp4+L9MSwoT?=
 =?us-ascii?Q?h+ZLAzKNMsjCSI3Jjxa96Rbz/RnObfwmvdnHD3GjY2+COatWU4NfajtctfN0?=
 =?us-ascii?Q?Zs61ghaDFp0bsbJK6+jFSxPjmlinXgDj9syK4dldCakYwxje2rSetLEpycG9?=
 =?us-ascii?Q?Jsb7n0+8pPZW5yiWVMfPc4cH6lSnLh1tuk6SbRp8YuS5+oLiiVY9GxH/9mMm?=
 =?us-ascii?Q?31RtQ5CFaH5PxOpKJi1899W+zSKcp4/Lw8rA5AxxpjEpy9q0f6FyBj25Qt2M?=
 =?us-ascii?Q?VbUZ38UxmlIiRelhc2Y4xGdqYDvz8+wdVjO0N+w1XYhyEVZUc+8EbHw5h5N4?=
 =?us-ascii?Q?fIuwvFVn3TIbcg5U2b0OvlIzvkcyu1k/2Ngh6PzEWpoeOqwDGR5lPJK3XYe3?=
 =?us-ascii?Q?A5x/rOTxhZvUd4TrxW7Aetfbh1GAtBP3/xc8wVgSMsU3M6X0ndww3Tevd2hf?=
 =?us-ascii?Q?cgz0fey6LFYqUUip/ym/9X9dijNMqmEVQXyJf+5s2q+LXdiD/GDCPV08d88a?=
 =?us-ascii?Q?gw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Brk2xETjXJQ8gAcWcw1LlRyjG+HdGEBc5Rc9VWu6v0iEhxjX94d46MRDegiIhqIwdrFNKUYvgOMBA4J4o8Px3MZagmg2retbMrzRjz8a+SzN9wY5opMvoks/XDDbHtjFt2GUFVGCGn2sBXiF/567j7Gcm+/4I6E8573izEAVc02DBBzbckG7UJ4kfhfJ9GGv8Y8lzcj4k2eIk3y4Ijuf3y/mwF+3rD1jFlLIvOtdtiLGKVSXPi2CTg2vENJhy7TZuR6ZhkvaHzt4vsAu21AQql0g8B5r3oNjSy8ACaZONKsgjejJOw9AYHY+c4OzQhZ/YyDGwkTb6Es7o3/6GmmQ76qL2nsuY9yRwjIo0kLPj8JG3mW1b0W9BWHweHQ8q0j68aYjdY5OVQIGWOhBkJXfsF4i/JGnUTNwZ+uVJXW6VjZEGUMiZ+g1Qbhgx8XFTvCoV2jd42CIPXCnEjIjRIzcN2hv02JFULyAU39/Vn10SX2T6Jar3daS4JJjF4LVGqFoviFcC8LvvpD89J257yppO+G5Fjg/X2nRvWxcC7SLiBpiRF20bOcRoYdVAeCbzhG/A7o3mQBzGc2mFiXKkuEF+5K6v5SgCU0s/nb9dMfxsZEe5DV9G4BFiFlKRu8Qva5V3Mh/GmFZMld0P5XPjUhcObAsJtqfLfKR5DghJOudnyrb4Q8FD6abtoB9bmkYKtf98X2j6VnQm/+z37PRBbQqq16T6KqW5iiGywMqyyQvaFJvomPrMX0GYqPGoGd0lxpiAQzKDcBSS8eCe9ePXRhoaxKavfa0OLBYMtRJR9lxZ7FnvLdxJTvALMu+gNokEH3eTswrGjq6CBt6M4/FLQlIxg==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 22cade77-60b5-48e5-091d-08db0b8ccc34
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB6798.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2023 17:32:35.3752
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0MjUtOIhW77NQqj3R6snJ/Hl5qEkHem7LvdiRY/KWY0L7kekoAi/N7FkB45Mz4Q8C5PfewFJoeA6fGXtbljfdw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB6809
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22
 definitions=2023-02-10_12,2023-02-09_03,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 bulkscore=0
 malwarescore=0 mlxscore=0 mlxlogscore=999 adultscore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2302100145
X-Proofpoint-GUID: jTs4Txu9ocAbe3pmHnB87Zdfc2V7MN_-
X-Proofpoint-ORIG-GUID: jTs4Txu9ocAbe3pmHnB87Zdfc2V7MN_-
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.

So comment out all uses of MODULE_LICENSE that are not in real modules
(the license declaration is left in as documentation).

Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-tegra@vger.kernel.org
Cc: linux-pci@vger.kernel.org
---
 drivers/pci/controller/pci-tegra.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c
index 929f9363e94b..aab1497411c4 100644
--- a/drivers/pci/controller/pci-tegra.c
+++ b/drivers/pci/controller/pci-tegra.c
@@ -2814,4 +2814,4 @@ static struct platform_driver tegra_pcie_driver = {
 	.remove = tegra_pcie_remove,
 };
 module_platform_driver(tegra_pcie_driver);
-MODULE_LICENSE("GPL");
+/* MODULE_LICENSE("GPL"); */
-- 
2.39.1.268.g9de2f9a303